Confirm interactive RSC permission updates#2906
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit confirmation step to the interactive RSC permission editor in the Teams CLI, to prevent accidental uploads while still supporting non-interactive “auto-confirm” flows via --yes.
Changes:
- Add
confirmPermissionUpdate()helper to print a concise add/remove summary and prompt for approval. - Gate the interactive upload (
setRscPermissions) behind the new confirmation, with a “No changes uploaded.” early-exit path. - Bypass the prompt when
--yesis active viaisAutoConfirm().
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
@heyitsaamir I just happened to see this feedback in the docs repo the other day: MicrosoftDocs/msteams-docs#14067 Is that assertion correct? This seems like an appropriate place to add said big warning banner (if I'm understanding this PR correctly). |
Collaborator
Author
I believe this is the same as #2737 which has been fixed for a few months. |
corinagum
approved these changes
Jul 1, 2026
heyitsaamir
added a commit
that referenced
this pull request
Jul 2, 2026
## Summary Prepare stable CLI 3.0.2 by merging current `main` into `release/v3` and setting explicit stable release metadata. ## CLI package commits since 3.0.1 - `1f11cdaf1` perf(cli): add in-memory caching for redundant TDP reads (#2902) - `2a969dd29` Fix CLI template issues and remove AI/MCP/MCPClient templates (#2904) - `553685c6b` Confirm interactive RSC permission updates (#2906) - `082e79830` Merge main into release/v3 for CLI 3.0.2 - `17d2170a6` Prepare CLI 3.0.2 release ## Validation - `npx turbo build --filter=@microsoft/teams.cli` - `npm -w @microsoft/teams.cli test` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Umang <3513186+umangsehgal@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SirajShaik-MSFT <v-sirshaikh@microsoft.com> Co-authored-by: Hugo Gonzalez <hugogonzalez@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kavin <115390646+singhk97@users.noreply.github.com> Co-authored-by: Rido <rido-min@users.noreply.github.com> Co-authored-by: Ricky Castaneda <126518272+MSFTRickyCastaneda@users.noreply.github.com> Co-authored-by: Shanmathi Mayuram Krithivasan <37715033+ShanmathiMayuramKrithivasan@users.noreply.github.com> Co-authored-by: Nick Walker <nickwalk@microsoft.com> Co-authored-by: Mehak Bindra <mhk0397@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--yesby bypassing the promptValidation
npm -w @microsoft/teams.cli test -- rsc-set.test.ts rsc-web-app-info.test.tsnpx turbo build --filter=@microsoft/teams.cli