Add New Gen Channels readiness skill to teams-sdk plugin + GitHub Copilot CLI support#2905
Add New Gen Channels readiness skill to teams-sdk plugin + GitHub Copilot CLI support#2905anandvnath wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the ngc-readiness skill into the teams-sdk plugin and introduces GitHub Copilot CLI plugin metadata alongside the existing Claude plugin manifests, with updated descriptions/versioning to surface both skills.
Changes:
- Add new
ngc-readinessskill definition and ruleset (SKILL.md). - Add GitHub Copilot CLI plugin manifests under
.github/plugin/andplugins/teams-sdk/.github/plugin/. - Update
teams-devskill routing note + bump plugin descriptions/version to reference both skills.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/teams-sdk/skills/teams-dev/SKILL.md | Adds routing note to defer NGC readiness audits to ngc-readiness. |
| plugins/teams-sdk/skills/ngc-readiness/SKILL.md | Introduces the ngc-readiness audit skill content and report format. |
| plugins/teams-sdk/.github/plugin/plugin.json | Adds Copilot CLI plugin manifest (lists both skills) and bumps to 1.4.0. |
| plugins/teams-sdk/.claude-plugin/plugin.json | Updates Claude plugin version/description to include both skills. |
| .github/plugin/marketplace.json | Adds Copilot CLI marketplace manifest pointing at the teams-sdk plugin. |
| .claude-plugin/marketplace.json | Updates Claude marketplace description to include NGC readiness auditing. |
anandvnath
changed the title
Pluralize 'shared & private channel' to 'shared & private channels' in the teams-sdk plugin/marketplace manifests and the ngc-readiness skill positioning note, addressing GitHub Copilot review comments on microsoft#2905. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate the ngc-readiness skill from microsoft/teams-platform-skills into the teams-sdk plugin, and add GitHub Copilot CLI (.github/plugin/) manifests alongside the existing Claude Code ones. Installing the teams-sdk plugin now surfaces two complementary, verb-partitioned skills: - teams-dev: build / configure / scaffold Teams apps, bots, and agents. - ngc-readiness: audit / validate an existing app for New Gen Channels (shared & private channels) readiness and generate a report. Changes: - New skill plugins/teams-sdk/skills/ngc-readiness/SKILL.md (rule body byte-identical to the source; frontmatter and a short positioning note reworked for discoverability). - Routing note in teams-dev/SKILL.md deferring NGC audit requests to the ngc-readiness skill so the two skills do not collide. - New ghcp manifests: .github/plugin/marketplace.json and plugins/teams-sdk/.github/plugin/plugin.json (both skills listed). - Version bump to 1.4.0 and expanded descriptions in the Claude manifests. teams-platform-skills is left untouched (copy, not move). No runtime/CLI code changes - skill and manifest content only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anandvnath
force-pushed
the
migrate-ngc-readiness-to-teams-sdk
branch
from
d5f975b to
c18013e
Compare
|
Hi @anandvnath, I'm a devex PM on Teams Platform, particularly around Teams SDK. Can you give some context about what this is and where it's coming from? I don't think anyone who works in this repo is familiar with |
|
Hi @nickwalkmsft , I am working with Teams platform IDC for the mobile side. This skill started off as part of a hack project where we found that all apps needs to be updated to support the new gen channels (NGC). There is public documentation around this. This skill that I developed along with Gaurav (Platform PM from IDC at that time) was to convert the documentation into a skill using which the apps code base can be scanned. The output is a report which calls out what needs to change in the app to be NGC ready (and hence the skill name microsoft/teams-platform-skills is a one off repo that I spun off to host my skill related to platform apps. I later found out that teams-sdk is hosting all platform related skills and hence merging it back here. Do let me know your feedback. I am happy to make adjustments to skill name, placement and way it should be integrated to teams-sdk, provide more context in skill documentation if it helps make it more relevant and easy for the teams-sdk skill users. |
heyitsaamir
left a comment
heyitsaamir
left a comment
There was a problem hiding this comment.
Hello, thanks for the PR. Instead of introducing a new skill we should instead create better documentation for this. You'll find that having good documentation will automatically improve the skills because the skill basically points the LLM to the docs. We are reserving skills for extremely nuanced things otherwise.
Additionally, I noticed a slew of content in the skill - manifest updates, lots of edge cases etc. Are all these necessary?
Summary
Migrates the
ngc-readinessskill (frommicrosoft/teams-platform-skills) into theteams-sdkplugin, and adds GitHub Copilot CLI (.github/plugin/) support alongside the existing Claude Code manifests.Installing the
teams-sdkplugin now surfaces two complementary skills, cleanly partitioned by verb:teams-dev— build / configure / scaffold Teams apps, bots, and agents.ngc-readiness— audit / validate an existing Teams app codebase for Next Gen Channels (NGC) readiness and generate a report.What changed
plugins/teams-sdk/skills/ngc-readiness/SKILL.md— copied from teams-platform-skills; rule body is byte-identical to the source. Frontmatter description reworked for discoverability, with a short positioning note so it doesn't overlap withteams-dev.teams-dev/SKILL.md: defers "validate an existing app for NGC readiness" requests to thengc-readinessskill, so the two skills don't collide..github/plugin/marketplace.json(mirrors the Claude.claude-plugin/marketplace.json)plugins/teams-sdk/.github/plugin/plugin.jsonlisting both skills explicitly.1.4.0and expanded descriptions in the Claude manifests.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com