perf(cli): add in-memory caching for redundant TDP reads

[heyitsaamir]

Summary

Adds process-scoped in-memory caching to eliminate redundant TDP (Teams Developer Portal) network reads within a single teams CLI invocation. Started with app-detail reads (the worst hotspot) and extended to bot reads, with a small reusable caching layer shared by both.

Caches are process-scoped (one CLI invocation = one process), Map-backed, and clone-on-read/write (structuredClone) so callers can't corrupt cached objects. Writes refresh the cache from authoritative POST responses; mutations that bypass the normal path explicitly invalidate.

What changed

• Reusable layer — src/utils/resource-cache.ts: generic createResourceCache<T>() with clone-safe get/set/invalidate.
• App details (hotspot #1) — fetchAppDetailsV2 is now cache-first with a { force } opt-out; updateAppDetails write-refreshes from its POST response (so uploadIcon benefits); importAppPackage invalidates. This collapses the ~7–9 GET /appdefinitions/v2/{id} reads per teams app update (read-modify-write) down to 1.
• Bot reads (hotspot #2) — fetchBot and getBotLocation now share a single GET /botframework/{botId} round-trip via one readBotResource() classifier (200 → Teams-managed with details, 404 → Azure). Only those two meaningful outcomes are cached; other statuses throw uncached so transient failures still retry. updateBot refreshes; deleteBot/registerBot invalidate.
• Spinner — fetchAppDetail keeps its spinner silent when both underlying reads are already warm (fixes the duplicate spinner seen on App → details → back → details).

Tests

• Unit tests written first (TDD, red→green): app-details-cache.test.ts, bot-cache.test.ts.
• Gated live timing integration test (RUN_INTEGRATION=1) demonstrating the saved round-trips.
• Full suite: 206 passed / 34 skipped, tsc --noEmit and npm run build clean.

Notes

• No TTL — caches live only for the duration of a single command, so staleness across invocations is impossible by construction.
• Within an invocation, every mutation point (update.ts, doctor.ts, bot/migrate.ts, bot-handler.ts) was traced for read-after-write staleness; all refresh or invalidate correctly.

[Copilot]

Pull request overview

Adds process-scoped, in-memory caching for high-frequency TDP read paths in the teams CLI (app details + bot reads), using a small reusable cache helper to reduce redundant network round-trips within a single invocation.

Changes:

• Introduce a generic createResourceCache<T>() utility (Map-backed, clone-safe get/set/invalidate).
• Cache fetchAppDetailsV2 reads with a { force } bypass; refresh cache on updateAppDetails; invalidate on package import.
• Cache bot read outcomes (200→Teams-managed w/details, 404→Azure), shared by fetchBot and getBotLocation; add tests + an opt-in live integration test.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/cli/src/utils/resource-cache.ts	Adds reusable clone-safe, process-scoped cache primitive.
packages/cli/src/apps/app-details-cache.ts	App-details cache wrapper + invalidation API.
packages/cli/src/apps/bot-cache.ts	Bot read-result cache wrapper shared across call sites.
packages/cli/src/apps/api.ts	Makes fetchAppDetailsV2 cache-first w/ { force }; refreshes cache on update.
packages/cli/src/apps/tdp.ts	Adds cached bot reader + bot cache refresh/invalidate hooks; invalidates app-details cache on import.
packages/cli/src/apps/bot-location.ts	Reuses cached bot reader instead of issuing its own GET.
packages/cli/src/apps/home.ts	Avoids spinner noise when required resources are already warm in cache.
packages/cli/src/apps/index.ts	Re-exports cache modules.
packages/cli/tests/app-details-cache.test.ts	Unit tests for app-details caching/force/invalidate/clone-safety.
packages/cli/tests/bot-cache.test.ts	Unit tests for bot caching, shared read, refresh, invalidate, clone-safety.
packages/cli/tests/app-details-cache.integration.test.ts	Opt-in live test demonstrating reduced round-trips.
packages/cli/tests/update-app-details-bump.test.ts	Ensures cache is cleared between tests to avoid cross-test coupling.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.