Rename app create tenant audience option#2889
Merged
Merged
Conversation
heyitsaamir
force-pushed
the
cli/sign-in-audience-naming
branch
from
0e0eea1 to
df82f86
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the teams app create tenant audience flag to make the CLI surface align with Microsoft Entra’s signInAudience concept while keeping a friendly, non-Graph enum interface.
Changes:
- Replaces
--single-tenantwith--sign-in-audience <audience>(myOrg|multipleOrgs, defaultmultipleOrgs). - Adds upfront validation (pre-auth) + coverage for invalid
--sign-in-audiencevalues. - Updates CLI docs and removes the old flag detail from
AGENTS.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| teams.md/docs/cli/commands/app/create.md | Updates public CLI docs/examples to the new --sign-in-audience flag. |
| packages/cli/tests/app-command-validation.test.ts | Updates existing test to new flag and adds pre-auth validation coverage for invalid values. |
| packages/cli/src/commands/app/create.ts | Implements new option parsing/validation and maps myOrg/multipleOrgs to Entra signInAudience values. |
| packages/cli/AGENTS.md | Removes mention of the old --single-tenant mapping detail. |
Comments suppressed due to low confidence (1)
packages/cli/src/commands/app/create.ts:103
- [NIT] Consider trimming
--sign-in-audiencebefore validation so accidental whitespace (e.g.myOrg) doesn't produce a confusing validation error.
.action(
singhk97
approved these changes
Jun 15, 2026
nickwalkmsft
approved these changes
Jun 15, 2026
nickwalkmsft
left a comment
nickwalkmsft
left a comment
Member
There was a problem hiding this comment.
Sorry, just realize I never actually left an Approve on this, least I could do 😁
heyitsaamir
force-pushed
the
cli/sign-in-audience-naming
branch
2 times, most recently
from
850d209 to
83f644f
Compare
heyitsaamir
force-pushed
the
cli/sign-in-audience-naming
branch
from
3802052 to
b46a277
Compare
heyitsaamir
added a commit
that referenced
this pull request
Jun 15, 2026
Renames the tenant audience switch to make the CLI surface more explicit. Why: `single-tenant` and `multi-tenant` are overloaded terms and hid the actual Entra app setting. `--sign-in-audience myOrg|multipleOrgs` maps more directly to the product concept. Interesting bits: - Replaces `--single-tenant` with `--sign-in-audience <audience>`. - Supports `myOrg` and `multipleOrgs`; default is still `multipleOrgs`. - Removes product-specific flag details from `AGENTS.md`. Tips for reviewers: Start in `packages/cli/src/commands/app/create.ts`; the rest is tests/docs. Testing: - `npm -w @microsoft/teams.cli run test -- app-command-validation.test.ts` - `npx turbo build --filter=@microsoft/teams.cli`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the tenant audience switch to make the CLI surface more explicit.
Why:
single-tenantandmulti-tenantare overloaded terms and hid the actual Entra app setting.--sign-in-audience myOrg|multipleOrgsmaps more directly to the product concept.Interesting bits:
--single-tenantwith--sign-in-audience <audience>.myOrgandmultipleOrgs; default is stillmultipleOrgs.AGENTS.md.Tips for reviewers:
Start in
packages/cli/src/commands/app/create.ts; the rest is tests/docs.Testing:
npm -w @microsoft/teams.cli run test -- app-command-validation.test.tsnpx turbo build --filter=@microsoft/teams.cli