Revert Python GCC 11 portability change while replacement is validated - #97
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Reverts PR #96’s Linux toolchain/linker adjustments to restore the repo-wide GCC 13 compiler selection and remove Python extension static-linking changes, with the goal of unblocking DSLE’s Linux R-extension validation that regressed under GCC 11.
Changes:
- Switch root
restore-packages.shback to installing/usinggcc-13/g++-13viaupdate-alternatives. - Revert Python extension Linux linker flags by removing
-static-libstdc++,-static-libgcc, and--exclude-libs,ALL. - Revert Boost.Python / Boost.NumPy library discovery back to non-
.alookup withoutNO_DEFAULT_PATH.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| restore-packages.sh | Restores GCC 13 as the shared compiler toolchain used by Linux extension builds. |
| language-extensions/python/src/CMakeLists.txt | Reverts static-linking and Boost static library enforcement introduced in #96 to return to prior Linux linking behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aniruddh Munde (Aniruddh25)
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert #96 to restore the repository-wide GCC 13 toolchain and unblock DSLE's Linux R-extension validation while a replacement Python portability design is developed and validated privately.
Regression
#96 changed the root
restore-packages.shfrom GCC 13 to GCC 11. That script is shared setup: DSLE runs it before building every Linux extension, not only Python.R 4.5.3 compiles source packages as C23 and its public
R_ext/Boolean.huses a fixed-underlying-type enum. GCC 11 cannot parse that construct. DSLE consequently failsRExtensionLibraryApiTests.InstallPrivatePublicwhile compiling thelazyevaltest fixture:Evidence
172355579passed the R tests before consuming Python extension Linux: build RHEL9-portable (GCC 11 + static Boost/libstdc++) #96.173126831, still using GCC 13, passedBuild RExtension,Build RExtension test, andTest RExtension-test.RExtensionLibraryApiTests.InstallPrivatePublicwith the GCC 11 C23 parse error.Scope
This reverts only squash commit
049f13c4(#96):The Logging SDK facade from #94 is unaffected.
Validation
main.86d6282is SSH-signed and GitHub Verified.049f13c4to this revert commit.173362723is queued to confirm the R pipeline is restored without masking failures.Follow-up
The Python RHEL9 portability work will be re-landed only after a private cross-repository design proves all of the following together:
continueOnErrormasking.