Skip to content

Stop linking libc++ into the Java extension on Linux #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SicongLiu2000 merged 3 commits into from
Aug 11, 2026
Merged

Stop linking libc++ into the Java extension on Linux #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fad606
Stop linking libc++ into the Java extension on Linux
SicongLiu2000 Aug 10, 2026
1d1e6f7
Trim the comment
SicongLiu2000 Aug 11, 2026
54294ac
State the invariant the link list maintains
SicongLiu2000 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions language-extensions/java/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,13 @@ if (${PLATFORM} STREQUAL linux)
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -shared -L${OUTPUT_DIRECTORY}/lib -L${LIBS} -Wl,-rpath,${JRE_ROOT}:/opt/mssql-extensibility/lib")
set(USR_LIB_PATH "/usr/local/lib")

find_library(CXX_LIB c++ ${USR_LIB_PATH})
find_library(ABI_LIB c++abi ${USR_LIB_PATH})
# Keep this .so dependent only on the C/C++ runtime every SQL container image provides:
# libstdc++, libgcc_s and libc, which GCC supplies for us, plus libdl linked below.
# Any other library named here becomes a runtime dependency the images must also carry,
# and they are not required to - RHEL images ship no LLVM runtime, for example.
find_library(DL_LIB dl ${USR_LIB_PATH})

target_link_libraries(JavaExtension ${CXX_LIB} ${ABI_LIB} ${DL_LIB})
target_link_libraries(JavaExtension ${DL_LIB})
set(ADDITIONAL_INCLUDES ${JDK_INCLUDE} ${JDK_INCLUDE_LINUX})

elseif(${PLATFORM} STREQUAL windows)
Expand Down