Allow for constant Result arrays in Adaptive Profile#3389
Draft
swernli wants to merge 3 commits into
Draft
Conversation
This change updates the data types in RIR to allow for variables of type Result to be used in the Adaptive Profile. This makes it possible to emit constant arrays of result identifiers into the data section of the generated QIR the same way arrays of qubit identifiers are supported. This also updates how Result literals are handled, allowing for their emission into RIR, transforming `Zero` into an extra result id allocation and detecting and rejecting `One` as unhandled during QIR codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the data types in RIR to allow for variables of type Result to be used in the Adaptive Profile. This makes it possible to emit constant arrays of result identifiers into the data section of the generated QIR the same way arrays of qubit identifiers are supported. This also updates how Result literals are handled, allowing for their emission into RIR, transforming
Zerointo an extra result id allocation and detecting and rejectingOneas unhandled during QIR codegen.