feat: add brace expansion support for glob patterns - #368
Merged
Merged
Conversation
Performance Report (Linux) ➖
Legend
|
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (macOS)
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (Windows) ➖
Legend
|
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
March 2, 2026 20:50
Karthik Nadig (karthiknadig)
enabled auto-merge (squash)
March 2, 2026 20:50
Connor Peet (connor4312)
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
{a,b}brace expansion support to glob pattern handling, enabling patterns like./**/{bin,Scripts}/python{,.exe}to work as search paths.Changes
pet-fs/src/glob.rs: expands{a,b}groups before passing patterns to theglobcrate (which doesn't support braces natively)is_glob_pattern()correctly identifies brace patterns (requires matched{...}pair with comma, scans all groups)searchPathsFixes #366