URI handler (2/3): extract shared auth/environment service#1626
Closed
amitjoshi438 wants to merge 2 commits into
Closed
URI handler (2/3): extract shared auth/environment service#1626amitjoshi438 wants to merge 2 commits into
amitjoshi438 wants to merge 2 commits into
Conversation
Convert `UriHandler.handleUri` from an if/else chain into a `ReadonlyMap<string, UriRouteHandler>` built in the constructor. The two existing paths (`/pcfInit`, `/open`) keep identical behavior; unrecognized paths are now ignored for forward compatibility instead of falling through. Add the versioned deep-link contract constants that the Power Pages home page will use to launch VS Code: - reserved paths `/agenticCreate` and `/pacCreate` (registered but not yet wired to any handler) - shared params `region`, `tenantid`, `source`, `agenthost`, `v` - enumerated `SOURCE_VALUES`, `AGENT_HOST_VALUES`, and `CONTRACT_VERSION` Export the `UriHandler` class so dispatch can be covered by an integration test. Adds a pure unit test asserting the constants contract and an integration test asserting each path routes correctly (including the reserved/unknown no-op paths). This change is behavior-preserving and ships dark: no new user-facing behavior. Follow-up PRs extract shared auth/env helpers and add the flag-gated skeleton handlers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the PAC CLI authentication, environment-selection, and process-reset logic out of the `UriHandler` class into a new `utils/authEnvironment.ts` `AuthEnvironmentService` that takes a `PacWrapper`. `UriHandler` now composes the service and delegates: - `handleOpenPowerPages` (`/open`) calls `authEnvironmentService.prepareAuthenticationAndEnvironment(...)` - `executeDownload` calls `authEnvironmentService.resetPacProcessSafely(...)` This is a behavior-preserving refactor: the moved methods (`prepareAuthenticationAndEnvironment`, `ensureAuthentication`, `ensureCorrectEnvironment`, `resetPacProcessAndThrow`, `resetPacProcessSafely`) keep identical logic, telemetry, prompts, and error handling. Extracting them lets the upcoming `/pacCreate` and `/agenticCreate` handlers reuse the exact same auth/environment flow instead of duplicating it. Adds an integration test (`test/integration/authEnvironment.test.ts`) covering the no-prompt happy path, the environment-switch path, and the reset-safely / reset-and-throw error behaviors with a stubbed PacWrapper. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of 3 (Phase 0-1 foundation). Stacked on #1625.
Focus commit
2c5d46e - Extract shared PAC auth/environment helpers into AuthEnvironmentService (behavior-preserving). Moves prepareAuthenticationAndEnvironment / ensureAuthentication / ensureCorrectEnvironment / resetPacProcess* out of uriHandler.ts into a reusable AuthEnvironmentService so the upcoming create handlers can share them.
Validation
gulp lint clean; compile-tests clean; npm test 106 passing; npm run build OK.
Note on diff
Base is main because the PR 1 branch cannot be pushed to the upstream repo (contributor works from fork amitjoshi438/powerplatform-vscode). This PR's diff therefore also contains PR 1's commit (9d91979). Review only the focus commit 2c5d46e, and merge after #1625.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com