fix(reporter): spread AggregateError sub-errors into testInfo.errors#40925
Open
Skn0tt wants to merge 1 commit into
Open
fix(reporter): spread AggregateError sub-errors into testInfo.errors#40925Skn0tt wants to merge 1 commit into
Skn0tt wants to merge 1 commit into
Conversation
Contributor
Test results for "MCP"1 failed 7180 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky42034 passed, 850 skipped Merge workflow run. |
dgozman
approved these changes
May 20, 2026
| this._tracing.appendForError(serialized); | ||
| const visit = (error: Error | unknown) => { | ||
| const serialized = testInfoError(error); | ||
| const step: TestStepInternal | undefined = typeof error === 'object' ? (error as any)?.[stepSymbol] : undefined; |
Collaborator
There was a problem hiding this comment.
I think the step should be gathered only once, for the top-level error. Inner errors are unlikely to have the step attached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AggregateError.errors[](any error exposing anerrorsarray) into separate entries ontestInfo.errors, pre-order DFS, symmetric with how soft assertion failures appear.Fixes #40856