feat(assertions): allow asserting JS undefined in ToHaveJSPropertyAsync - #3346
Closed
Darío Kondratiuk (kblok) wants to merge 1 commit into
Closed
feat(assertions): allow asserting JS undefined in ToHaveJSPropertyAsync#3346Darío Kondratiuk (kblok) wants to merge 1 commit into
Darío Kondratiuk (kblok) wants to merge 1 commit into
Conversation
.NET has no undefined value, so ToHaveJSPropertyAsync could not match the JS matcher. Introduce JSUndefined.Value as a sentinel used only by this assertion, leaving Evaluate serialization unchanged. Fixes microsoft#3299 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Opened on the kblok fork instead: kblok#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSUndefined.ValuesoToHaveJSPropertyAsynccan assert a JavaScriptundefinedproperty, matching the JS matcher.EvaluateAsyncstill sends C#nullas JSnull.Fixes #3299
Made with Cursor