chore(transport): pass the call timeout as an argument - #3339
Merged
Devin Rousso (dcrousso) merged 1 commit intoJul 30, 2026
Conversation
Devin Rousso (dcrousso)
force-pushed
the
timeout-argument
branch
from
July 30, 2026 17:49
af222bf to
c9ad38a
Compare
`InnerSendMessageToServerAsync` picked the call timeout out of the parameters by name, which silently claims any future protocol parameter that happens to be called `timeout` thread it through `SendMessageToServerAsync` as its own argument instead, matching the `playwright` and `playwright-java` clients
Devin Rousso (dcrousso)
force-pushed
the
timeout-argument
branch
from
July 30, 2026 18:26
c9ad38a to
f148f2d
Compare
Devin Rousso (dcrousso)
marked this pull request as ready for review
July 30, 2026 18:26
Devin Rousso (dcrousso)
requested review from
Simon Knott (Skn0tt) and
Dmitry Gozman (dgozman)
July 30, 2026 18:26
Dmitry Gozman (dgozman)
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the call timeout as a separate
SendMessageToServerAsyncargument instead of extracting atimeoutentry from the parameter dictionary.This matches the Java and JavaScript clients and avoids claiming any future protocol field named
timeout.The full Chromium suite remains at
1818passed tests and33skipped tests. The only two local failures requirepwsh, which is not installed on the validation machine.