Skip to content

feat(fetch_grpc): add empty fetch_grpc crate scaffold#561

Open
martintmk wants to merge 1 commit into
mainfrom
user/martintmk/20260710-add-fetch-grpc-crate
Open

feat(fetch_grpc): add empty fetch_grpc crate scaffold#561
martintmk wants to merge 1 commit into
mainfrom
user/martintmk/20260710-add-fetch-grpc-crate

Conversation

@martintmk

Copy link
Copy Markdown
Member

Adds a new placeholder crate fetch_grpc that will adapt a fetch HTTP client into a transport for the grpc crate, mirroring the structure of the existing fetch_azure adapter.

The crate is an empty scaffold for now (crate-level docs only, no dependencies); a real implementation will follow in a subsequent PR. It is registered in the workspace and the root README/CHANGELOG crate lists.

Add a new placeholder crate that will adapt a fetch HTTP client into a
transport for the grpc crate (https://docs.rs/grpc). The crate is an empty
scaffold for now; a real implementation will follow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a2e246c4-80ba-4ce1-9395-70193adf4092
@martintmk martintmk added the road-to-gas-town Touched by a Road to Gas Town skill label Jul 10, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Breaking Changes Detected

error: failed to retrieve local crate data from git revision

Caused by:
    0: failed to retrieve manifest file from git revision source
    1: possibly due to errors: [
         failed when reading /home/runner/work/oxidizer/oxidizer/target/semver-checks/git-origin_main/9a588f2deda6512c7151858a7203fa68074cfc1e/scripts/crate-template/Cargo.toml: TOML parse error at line 9, column 26
         |
       9 | keywords = ["oxidizer", {{CRATE_KEYWORDS}}]
         |                          ^
       missing key for inline table element, expected key
       : TOML parse error at line 9, column 26
         |
       9 | keywords = ["oxidizer", {{CRATE_KEYWORDS}}]
         |                          ^
       missing key for inline table element, expected key
       ,
         failed to parse /home/runner/work/oxidizer/oxidizer/target/semver-checks/git-origin_main/9a588f2deda6512c7151858a7203fa68074cfc1e/Cargo.toml: no `package` table,
       ]
    2: package `fetch_grpc` not found in /home/runner/work/oxidizer/oxidizer/target/semver-checks/git-origin_main/9a588f2deda6512c7151858a7203fa68074cfc1e

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
   1: cargo_semver_checks::rustdoc_gen::RustdocFromProjectRoot::get_crate_source
   2: cargo_semver_checks::rustdoc_gen::StatefulRustdocGenerator<cargo_semver_checks::rustdoc_gen::CoupledState>::prepare_generator
   3: cargo_semver_checks::Check::check_release::{{closure}}
   4: cargo_semver_checks::Check::check_release
   5: cargo_semver_checks::exit_on_error
   6: cargo_semver_checks::main
   7: std::sys::backtrace::__rust_begin_short_backtrace
   8: main

If the breaking changes are intentional then everything is fine - this message is merely informative.

Remember to apply a version number bump with the correct severity when publishing a version with breaking changes (1.x.x -> 2.x.x or 0.1.x -> 0.2.x).

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (ece85ff) to head (ec0b146).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         356      356           
  Lines       27378    27378           
=======================================
  Hits        27378    27378           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martintmk martintmk marked this pull request as ready for review July 10, 2026 12:44
Copilot AI review requested due to automatic review settings July 10, 2026 12:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new workspace crate, fetch_grpc, as a placeholder scaffold for a future adapter that will let the fetch HTTP client back a transport for the grpc crate (mirroring the existing fetch_azure adapter pattern).

Changes:

  • Introduces a new crates/fetch_grpc crate with initial package metadata and crate-level documentation.
  • Registers fetch_grpc in the workspace dependency list and updates root README/CHANGELOG crate indexes.
  • Adds crate branding assets (logo + favicon) and updates the spellchecker dictionary for “grpc”.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Adds fetch_grpc to the top-level crate list.
crates/fetch_grpc/src/lib.rs Adds crate-level docs and rustdoc logo/favicon metadata.
crates/fetch_grpc/README.md Adds the crate README scaffold content.
crates/fetch_grpc/logo.png Adds crate logo asset (Git LFS pointer).
crates/fetch_grpc/favicon.ico Adds crate favicon asset (Git LFS pointer).
crates/fetch_grpc/CHANGELOG.md Adds initial changelog file scaffold.
crates/fetch_grpc/Cargo.toml Adds new crate manifest with workspace-inherited settings and metadata.
CHANGELOG.md Adds fetch_grpc to the root changelog index list.
Cargo.toml Adds fetch_grpc to [workspace.dependencies].
Cargo.lock Adds lockfile entry for the new workspace crate.
.spelling Adds “grpc” to the spellchecker word list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

road-to-gas-town Touched by a Road to Gas Town skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants