Skip to content

[Draft] arm64: extend shared cold-runtime validation - #1516

Draft
Gautam Ahuja (ahuja-gautam) wants to merge 9 commits into
gautamahuja-microsoft-nvx-phase-2-prfrom
gautamahuja-microsoft-nvx-phase-3-pr
Draft

Gautam Ahuja (ahuja-gautam) wants to merge 9 commits into
gautamahuja-microsoft-nvx-phase-2-prfrom
gautamahuja-microsoft-nvx-phase-3-pr

Conversation

@ahuja-gautam

@ahuja-gautam Gautam Ahuja (ahuja-gautam) commented Nov 12, 2026 •

Copy link
Copy Markdown

Refs #1509, #1510.

What and why

Current published Phase 3 slice and qualification (24bd)

Head 24bdced073a24418c1ebbf1d0775bb5ba42266ba, tree b9a15cd955dda2352d2cfe94b39fbdd752ef3685, sole parent 2000aa078713467add77565acdae688a6d6ecfcf, is on Phase 2 aacccd99e132233f4ae6e440b30aeadf941031f4 and frozen NVX dev c9817ae73263a0c32498dd43ebeb089164af8cbe. All nine layer commits / sixteen feature commits above those bases have one parent and zero new merges. Stack 1517 remains #1509 -> #1510 -> #1516, all actual Draft, published heads 3103f24c / aacccd99 / 24bdced0, no queue/auto-merge. Later live dev 1ad73759022f2ded66cfc93197288064cb02ad6a and its OpenVMM 09cd771c061aa1d1b406b41eaf2eda851db87c15 are observations only, not incorporated or qualified.

Mergeability is not clean: fresh GraphQL/REST report CONFLICTING / DIRTY / mergeable=false. PR3's baseRefOid, baseRef.target, REST base.sha, and actual Phase 2 branch all equal aacccd99; its head fields/actual branch equal 24bd. That immediate base is an ancestor of 24bd, not stale 413586. The live-dev/full-stack comparison diverges from c981 (16 feature / 6 later-dev commits); pins 09cd and b09 diverge from 73cf (4 upstream / 3 ARM commits). This is consistent with cumulative native final-base assessment, not proof of GitHub's internal cause or a complete conflict-path list. No hypothetical conflict resolution, retarget, merge, rebase or latest-dev intake is performed or authorized by this description.

The selected OpenVMM pin is b09c58843ae310dfff9ae68e9e822f9c5846b914, tree 0ab5ac89b10bf83d0a129d0a328abe682bc97835, the published head of microsoft/openvmm#5045: three linear ARM/import commits on 73cf403574a8907ee94dab0ab9d648152b832b05, roadmap positions 270-272 after inherited 269, mapped tip 124. This v6.1 baseline includes the reviewed upstream PIT/RTC/loader/state changes; the old C5/5d/6036/no-PIT descriptions below are historical, not current. The source signature remains unsigned, not verified. The actual tested native ARM64 VMM reports openvmm 0.5.0+gb09c58843, executable SHA256 f171f776a76c7aeef5faae7221e7a508d4d3de48f7e62f227bc7fbc372eb7653, owner provenance SHA256 fea523f0e1f3114a0920a79ec3679f16fd8c3ec45fe0254f6269c691b9eb6691. Its real build has opt-level 0, debug info 2, debug assertions/overflow checks enabled; its directory name is not an optimized-release claim. OpenVMM must still land before NVX; no landing or trusted-CI admission is implied.

Runtime executed at 2000, tests at 24bd: the sole ordinary test-only follow-up changes two Python test files / three methods, 6 insertions / 9 deletions, correcting the missing legitimate Azure Linux selector conjunct and restoring default-x86 progress/report expectations. It leaves all 1,032 other tracked mode/type/blob/path rows unchanged, digest 73ae1805271658bcb25d876f5bd113afee42a70a05830713901ae56abdd0da28. Independent bridge SHA256 7787029762c5560e2420c41a8986bc9c2839d27078cd5ab484c395d58cc4c3b0 verifies product/source identity: the 2000 runtime results apply to 24bd by that identity, not by claiming VM reexecution at 24bd. Old f775/38016/6036/0d9460dc smokes and old matrices remain historical only.

Current aacccd99 -> 24bd: 218 modified existing test/wiring assets, 23 additions, zero unchanged relocations, not 218 methods. python scripts\check_test_changes.py --base aacccd99e132233f4ae6e440b30aeadf941031f4 --head 24bdced073a24418c1ebbf1d0775bb5ba42266ba --repository microsoft/nvx PASS. Follow-up-only 2000 -> 24bd is 3 modified / 0 added, also PASS. The restored progress test is AST-identical to the lower base, explaining the prior 219-to-218 reduction; no test was removed/skipped. tests-modified, the original 29-file rationale and all historical receipts below remain; original 215/18, 217/20, 217/23 and 219/23 counts retain only their named old scopes.

Legacy x86 NIC/admission/one-VP boot+managed/template assertions and explicit ARM expansion remain covered. Azure Linux selected-guest download, literal Windows/Linux native-Python binders, selected-ISA/debug-config admission, and ISB/MRS/ISB with no nomem counter ordering survive. The workflow remains blob 7281163234a69bdbd13624622f7bf41137590456; the ordinary strict helper remains original blob ec94c583a73e0a8b22aef3249ca198f1895e9ab1, raw SHA256 5381eb15c7a1b0aafa03332ab6fe8abe3f48c1a12bbe8e3e103303a185e9df57. No active _TRIAL_ allowance/tests/docs, double-revert or fork-proof substitution exists. All remaining qualification/proof limits are listed below; this is not overall green CI or host qualification.

Historical first guarded rebase (f865 -> 34aa; superseded)

The historical first in-place rebase replayed only the same six Phase 3 commits onto the reviewed Phase 2 tip f865578bdd7a4767e4b208f67d99792cb9215ac2, whose reviewed Phase 1 ancestor is d06bf47f89eddf2fa68edeb99caf3fd697d35f45. The historical head was 34aa63aacad12bac4943727c0c465af33f949853, tree c089a20a5977cde44816a6795cf8c5166889d033. No dev intake, merge, pin change, new implementation commit, unstack/recreate, or auto-merge is part of this rebase. Native stack 1517 stays #1509 -> #1510 -> #1516, all actual Ready; the literal [Draft] title is retained. Earlier Draft-state descriptions below are historical.

The replay was conflict-free. All six git range-diff cb017cf8..44d5cca8 f865578b..34aa63aa entries are equal (=). Ignoring hunk offsets/blob headers, the old-top-to-new-top semantic patch is exactly the old-base-to-new-base lower-review patch (10 files, 209 insertions/12 deletions): native source-archive selection and exact option spellings, ARM remembered-directory path admission, and the inert Windows PE fixture correction. All lower regression ASTs and byte-identical Rust/path-admission files remain in the final tree. Phase 3's explicit monitor architecture override/native fallback regression remains AST-identical. Local backup refs preserve the original top/base and reviewed new base under refs/backup/nvx-phase3-rebase-20261112-2025/.

Historical Phase 3 commit Replayed commit
f77577b4963b7b4ae8f8e73e5c0b6728cb8b19df 587f5dba36346325435e1b3334cfd0260544a503
19d29ebc7a6b4d825fb070317f4d534be5d59b3c 1cb8daba8cbbb6d9cd1547bf508048bf55a16fa7
934b9c2a85b2c8f7762688cba9d76b5c44fe2691 7442fa08fdc5206c15d293da77be8683e9dff913
8e0016bb65e28e9b6baaec2af1fc4c1337b08cce ae932b9e2b5660e0ed69dba69785e6cb955f750e
a0f5e4e336cda405eacc1142b8267563d292c5c1 d926833d60aa28fa801b1522605940b225330e2f
44d5cca8e296286515a28ac7515820f42266e5f0 34aa63aacad12bac4943727c0c465af33f949853

The temporary allowance remains reverted in the final tree. The ordinary OpenVMM CI helper is raw-byte/AST-identical to the original blob ec94c583a73e0a8b22aef3249ca198f1895e9ab1 (SHA256 5381eb15c7a1b0aafa03332ab6fe8abe3f48c1a12bbe8e3e103303a185e9df57); no _TRIAL_ allowance is active. The permanent Windows literal-Python binder workflow remains exact blob f93c8be4922720dd537750f4c107a80c25d2dcd1. The NVX OpenVMM gitlink is still 38016f6637f0c61fb55c9ee31033ceec428e346c, not a newer OpenVMM PR head.

Historical first-rebase committed slice f865578b -> 34aa63aa: 217 existing test/wiring changes, 20 additions, zero unchanged relocations. python scripts\check_test_changes.py --base f865578bdd7a4767e4b208f67d99792cb9215ac2 --head 34aa63aacad12bac4943727c0c465af33f949853 --repository microsoft/nvx --report <comment-report> --summary <full-report> PASS, exit 0. Full maintained report SHA256 0b9970b7f280a32c562e8f24c53c2e66a47a419a9f1088e31980224a37665c76; per-file rationale below remains applicable and tests-modified remains required.

Historical first-rebase resource guards passed immediately before the scoped test/static/formatting stages (pr3-20261112-rebased-static-prelaunch-01, -02, and pr3-20261112-rebased-format-prelaunch-03). Each checked min(available physical, available commit) >= 3072 MiB, found no matching compiler/VMM/Docker processes, and recorded Docker API unavailability as unknown running containers, not zero.

Historical first-rebase validation used the maintained Python interpreter via $Python as defined below: & $Python -m unittest scripts.test_guest_binaries.GuestBinaryArchitectureTests scripts.test_time_abi.MonitorTests scripts.test_nvx_tools.OpenVMMCiTests scripts.test_nvx_tools.CiConfigurationTests -q PASS, 140 selected/134 passed/six unchanged platform skips. & $Python -m ruff check scripts .github\specula and & $Python -m ruff format --check scripts .github\specula PASS (127 files formatted); & $Python -m pyright --pythonplatform Linux --pythonpath $Python and the Windows view PASS, zero errors/warnings, with PYTHONPATH unset. & $Python scripts\check_test_layout.py, & $Python scripts\check_markdown_links.py, & $Python scripts\nvx.py check-kernel-config and the same inventory check with --architecture aarch64 PASS; six maintained PowerShell setup files parsed without errors. cargo +1.97.1 fmt --all --check --manifest-path nvx-rs\Cargo.toml and the same command for tests\runtime-adapter\Cargo.toml PASS. git diff --check f865578bdd7a4767e4b208f67d99792cb9215ac2 HEAD PASS.

& $Python scripts\local_gates.py --base f865578bdd7a4767e4b208f67d99792cb9215ac2 PASS as the applicable-gate inventory. The initial system-Python invocation lacked PyYAML; selecting the existing maintained dependency environment resolved that tooling prerequisite without a source change. This scope did not rerun the full Rust/Python action suites, unavailable submodule-coupled checks, native builds, heavy VM campaigns, or Linux-only shell/Specula/platform qualification. Rebase inspection, exact lower-fix retention, focused tests and static checks do not claim those gates passed.

The bounded strict command python scripts\nvx.py check-openvmm-ci --revision 38016f6637f0c61fb55c9ee31033ceec428e346c --architecture aarch64 retains expected exit 1 / eight missing-evidence results under the restored trust policy. H4/H7/full UTC/host and actual native ARM runner admission remain unqualified. The old manual run 43162791571 checked the historical a0f5e4e3 checkout only; neither its success nor the reviewed lower-layer evidence is relabeled as CI/native execution of 34aa63aa, the replayed intermediate d926833d, or final-base integration.

Historical pre-rebase full Phase 3 committed test accounting (cb017cf8aee13e5e7276236d1b0ab328e1b52e7f -> 44d5cca8e296286515a28ac7515820f42266e5f0): 217 existing test/wiring changes, 20 added items, zero relocated unchanged. python scripts\check_test_changes.py --base cb017cf8aee13e5e7276236d1b0ab328e1b52e7f --head 44d5cca8e296286515a28ac7515820f42266e5f0 --repository microsoft/nvx --report <comment-report> --summary <full-report> passed as the maintained committed inventory command. Full report SHA256: 01509f794a010186d59b6dca163c9651d75be468fc52f4c6034ef0b28f6eec8f. The original 215/18 below is explicitly historical CB017 -> f775 accounting; rollback-only 8/0 is a0 -> 44, not this current full PR slice. All per-file rationale remains applicable and tests-modified remains required.

TEMPORARY evidence-admission trial: completed and reverted

Rollback completed in 44d5cca8e296286515a28ac7515820f42266e5f0, a normal new commit whose sole parent is a0f5e4e336cda405eacc1142b8267563d292c5c1. The coordinator explicitly ended the bounded trial after its objectives passed. Only isolated temporary commit 19d29ebc7a6b4d825fb070317f4d534be5d59b3c was reverted; all permanent 934b9c2a / 8e0016bb / a0f5e4e3 portability repairs remain. scripts/nvx_tools/openvmm_ci.py is raw-byte/blob/AST-identical to pretrial f775, blob ec94c583a73e0a8b22aef3249ca198f1895e9ab1 (SHA256 5381eb15c7a1b0aafa03332ab6fe8abe3f48c1a12bbe8e3e103303a185e9df57). No active trial allowance, trial policy documentation or temporary policy tests remain in the repository. The native-shell workflow remains exactly the a0 blob f93c8be4922720dd537750f4c107a80c25d2dcd1; all permanent binder/configuration AST nodes and five documentation lines remain unchanged. The history below records the completed trial, not an active exception or pending rollback.

Historical hosted trial success remains bound to immutable a0, not the rollback head: workflow-dispatch run 43162791571, attempt 1, checked out exact a0f5e4e336cda405eacc1142b8267563d292c5c1. Its pin gate completed successfully with the exact temporary-proof warning and all eight actual passed result lines; raw log SHA256 ca51bdafcc13c64fec01de3d66edd9e801ca591f363c096eaf6456ad22af282f. Actual Windows binder steps passed in guests, adapter, shard 1 and shard 2, with each Linux alternative skipped by its OS guard. These are real step outcomes, not full runtime-job, native ARM admission, UTC/host or final-base qualification. The existing dispatch was not cancelled or redispatched and may continue independently after the revert.

One fresh post-revert snapshot at 2026-11-12 06:00:36 UTC still reports that immutable a0 dispatch queued overall: 35 successful jobs, six skipped, two queued, zero failed. All four Windows consumer jobs named above have now completed successfully, not just their binders. The native ARM CLI/VMM jobs remain queued without assigned runners. This newer snapshot does not establish a completed full workflow, native ARM admission or final-base integration.

Rollback validation: python -m unittest scripts.test_nvx_tools.OpenVMMCiTests scripts.test_nvx_tools.CiConfigurationTests -q PASS, 106 selected/100 passed/six unchanged platform skips; focused Ruff lint/format and strict Linux/Windows type views PASS, zero type errors/warnings; layout, Markdown links and staged whitespace checks PASS. The bounded actual normal command python scripts\nvx.py check-openvmm-ci --revision 38016f6637f0c61fb55c9ee31033ceec428e346c --architecture aarch64 now returns expected exit 1 / eight missing-evidence results, without the trial warning: restored fork rejection, not a new regression. python scripts\check_test_changes.py --base a0f5e4e336cda405eacc1142b8267563d292c5c1 passed at the committed revert, reporting eight existing test changes/no additions: restore the two original fake-API helpers, remove trial-only get and _trial_api helpers, and retire the four trial-only admission/mismatch/latest-job tests with the allowance they exercised. Permanent binder tests are preserved; tests-modified remains.

The user explicitly authorized a reversible trial after the original f775 publication. Temporary commit 19d29ebc7a6b4d825fb070317f4d534be5d59b3c, parent f77577b4963b7b4ae8f8e73e5c0b6728cb8b19df, admits only upstream-hosted OpenVMM run 43109699910, PR microsoft/openvmm#5045, pin 38016f6637f0c61fb55c9ee31033ceec428e346c, fork ahuja-gautam/openvmm, head ref openvmm-arm64-microvm-dev-20261111, event pull_request, and workflow .github/workflows/openvmm-pr.yaml with audited Git blob 2cabb910cd6d8c974b809a30870502f69ac68e83 (421776-byte regular file). The live PR must remain open/unmerged with that head and the expected upstream base repository/ref; no moving base SHA is trusted. Missing/malformed/mismatched proof fails closed. The ordinary trusted-upstream path, default six x86 requirements, and all eight selected latest-attempt job assessments remain unchanged: no failed, skipped or missing job waiver, no other fork/run/PR/pin admitted. The actual eight-job check passes locally with that exact proof; the overall upstream AMD-SNP failure remains retained/deferred, not green.

Separate permanent repair 934b9c2a85b2c8f7762688cba9d76b5c44fe2691, parent 19d29ebc7a6b4d825fb070317f4d534be5d59b3c, fixes the Phase 3 shared correctness binder's unconditional Bash dependency on self-hosted Windows. The binder now uses the native Python custom shell; its Python AST, environment, argument guards, JSON shape and step output are unchanged. Tests execute the actual script file with an empty PATH (no Bash or shell tools), preserving Linux/x86, Windows/x86 and ARM shapes and refusals. Dependent Windows ARM paths were inspected; remaining shared-workflow Bash steps are Linux/KVM-only. No Bash installation, runner/security/service/clock change, native rerun, build, pin change, lower-history rewrite or stack mutation was made.

Permanent follow-up 8e0016bb65e28e9b6baaec2af1fc4c1337b08cce, parent 934b9c2a85b2c8f7762688cba9d76b5c44fe2691, selects that shell through the declared inputs.backend (whp selects Windows Python). The first automatic startup run at 934b9c2a failed before creating any jobs because GitHub does not expose runner context in shell; this failure is retained, not relabeled as a trial-gate pass. The follow-up restricts the test harness to the same allowed input context and keeps the Linux refusal fixture on its Linux backend. The 110 maintained policy/configuration tests passed again (104 passed, six platform skips), and both strict type views, lint and formatting passed. python scripts\check_test_changes.py --base 934b9c2a85b2c8f7762688cba9d76b5c44fe2691 passed at the follow-up, reporting three existing test/wiring changes and no additions. Reverting the temporary policy commit must preserve both permanent portability commits.

Final portability head a0f5e4e336cda405eacc1142b8267563d292c5c1, parent 8e0016bb65e28e9b6baaec2af1fc4c1337b08cce, replaces shell expressions entirely with mutually exclusive OS-guarded literal python {0} / python3 {0} steps sharing one YAML-anchored script/environment; the existing artifact consumer reads the selected step's output. GitHub also rejected inputs in the shell field in the retained second startup failure, before any jobs. At the final head, both binder Python ASTs and environments match the original exactly, the 110 targeted tests pass (104 passed/six platform skips), both strict type views and lint pass, and the final committed test/wiring inventory reports ten existing changes/no additions against 8e0016bb (shared-script/env anchors, exactly-one-OS selection, and equivalent output coalescing). A read-only reverse-apply check proves that reverting only the temporary commit applies over all three permanent portability commits without undoing their repair; no actual revert was performed. No successful hosted trial-gate result is claimed from either failed startup run.

Final-head CI admission blocker: bounded automatic-run observation at a0f5e4e3 found no pull_request CI workflow run. PR #1516 is reported CONFLICTING / DIRTY (REST mergeable=false), while its immediate base remains the exact Phase 2 commit. Only test-change pull_request_target runs and the dynamic reviewer started at that head; neither is the NVX pin gate or runtime CI. There is no final-head hosted pin-gate/Windows-binder outcome to claim, and no new reusable-workflow startup failure was observed after the literal-shell correction. Stack/final-base compatibility remains for coordinator inspection; no pin choice, rebase, manual dispatch or rollback was performed. Final committed inventories passed: 14 existing/8 added follow-up changes versus preserved f775, and 611 existing/227 added for the separate all-stack comparison to local origin/dev. These scopes do not replace the original Phase 3 inventory.

The coordinator-directed rollback of only 19d29ebc7a6b4d825fb070317f4d534be5d59b3c is now complete in the new commit named above; it was not an automatic revert or cancellation of the immutable a0 dispatch. The permanent Windows repair remains. The original source/product audit and qualification disclosures below describe the preserved f775 snapshot, not fresh rollback-head native qualification. The exact temporary exception described above is historical and is no longer active.

Follow-up validation using the isolated session Python environment: python -m unittest scripts.test_nvx_tools.OpenVMMCiTests scripts.test_nvx_tools.CiConfigurationTests -q PASS, 110 selected/104 passed/6 unchanged platform skips; python -m ruff check scripts\nvx_tools\openvmm_ci.py scripts\test_nvx_tools.py PASS; python -m ruff format --check scripts\nvx_tools\openvmm_ci.py scripts\test_nvx_tools.py PASS; python -m pyright --pythonplatform Linux --pythonpath <isolated-python> scripts\nvx_tools\openvmm_ci.py scripts\test_nvx_tools.py and the same command with --pythonplatform Windows PASS, zero errors/warnings each; python scripts\check_test_layout.py, python scripts\check_markdown_links.py and git diff --check PASS. python scripts\nvx.py check-openvmm-ci --revision 38016f6637f0c61fb55c9ee31033ceec428e346c --architecture aarch64 changed from eight missing jobs before the trial to eight passed with the exact approved evidence; this is not an NVX CI success claim.

Committed test-change inventories passed: python scripts\check_test_changes.py --base f77577b4963b7b4ae8f8e73e5c0b6728cb8b19df at temporary commit 19d29ebc reports 2 existing helper changes/6 additions (API proof fixture support and fail-closed regression coverage); python scripts\check_test_changes.py --base 19d29ebc7a6b4d825fb070317f4d534be5d59b3c at permanent commit 934b9c2a reports 4 existing test/wiring changes/2 additions (execute the real custom-shell binder rather than stripping the Bash wrapper, remove the wrapper, preserve argument/output shapes and input refusal coverage). python scripts\check_test_changes.py --base origin/dev also passed as a committed inventory command. These follow-up counts are separate from the original Phase 3 215-existing/18-added inventory below; tests-modified remains required.

Phase 3 of the authorized three-PR ARM64 stack, dependent on Phase 2 (#1510), which depends on Phase 1 (#1509). The lower PRs remain actual Drafts. This PR was initially Ready for review/CI, with a literal [Draft] title at the user's request. It is now actual Draft with both lower PRs; neither state nor the title claims qualification is complete.

Publish the existing audited commit f77577b4963b7b4ae8f8e73e5c0b6728cb8b19df unchanged: sole parent cb017cf8aee13e5e7276236d1b0ab328e1b52e7f, tree 0339a9c7365fb8dd08ded08f5ff9d1ef8e4ff93e, exactly 64 changed paths against Phase 2. Publication adds no commits, source edits, rebases, merges, builds, or duplicate native runs.

Extend the existing shared cold-runtime paths to native ARM64/WHP: architecture-bound guest/OpenVMM artifacts and native host/PE consumers; complete cold-case selection and CI argument, shard, duration, artifact and aggregate-status wiring; capability-scoped cold runtime-adapter tests; bounded same-provision scratch/RAM repetitions; and the actual ARM counter-warp probe. Correct DT CPU address-cell decoding, exact named MMIO/DT and GIC observations, layered Ubuntu control bootstrap, lifecycle time observations, and early quiet-console parity. Preserve x86 defaults/full snapshot tails, the existing 1000-iteration race, normal teardown, the exact required-status name, and the existing fork-headed workflow acceptance/rejection function. No trust exception or new every-job H5/H7 requirement is introduced.

Historical original f775 pin, provenance and landing constraints

The gitlink changes from 61cdd63978ea58ce045d159208ed4ca22f30cbb8 to 38016f6637f0c61fb55c9ee31033ceec428e346c, the published head of microsoft/openvmm#5045, available through upstream's refs/pull/5045/head from ahuja-gautam/openvmm. The committed roadmap maps its ARM cold-boot foundation ca913105d at position 252, following 174da3a0d at position 251, and its shared CPU/time verifier 38016f663 at position 253. The verifier uses the shared TimeAbiReport, preserves x86 output and rejects ARM fault hooks; it does not establish UTC discipline, snapshots, or a wider PA contract.

The audit records source correspondence for the actual tested VMM gca913105d.dirty, binary prefix 2f776ab9, to the selected published 38016 source. This is not a clean 38016 rebuild or a clean f775 product rebuild; no provenance/product relabel is made. The source/product freeze, committed-blob inventory correspondence, and paired parent audit identify the exact tested inputs below.

Required landing order remains OpenVMM first, with a reviewed fast-forward of feature/microvm/dev to the pin, before NVX integration. This publication does not perform that landing, grant a fork-CI trust exception, or assert it already happened. The audit reports all eight NVX-selected upstream jobs (six x86 plus native Windows ARM unit/VMM jobs) passed for 38016; the overall upstream workflow is not claimed green. Its failed AMD-SNP receipt is retained and investigation is deferred per the user. Those eight jobs do not prove NVX runner/account admission.

The historical publication snapshot of live NVX dev was fc59c9065ceb2a939874123f9cdc856ad7784cf6, pinning OpenVMM 90f87319d30d8c35bc3526f12fc7b6529c882cf0, divergent from the selected pin at 174da3a0d236b4b01182a8d73a47598e4fcb1eca (four upstream versus two selected feature commits). The exact Phase 2 base does not prove final-base compatibility. That remains for coordinator inspection after publication, not permission to intake newer dev, replace the pin, or rewrite the stack.

Validation

Current published-head execution and limits (24bd / b09)

Exact final descriptor: C:\Users\gautamahuja\aci\phase3-refresh-20261113\evidence\final-phase3-refresh-qualification-handoff.json, SHA256 4877476782c70b72978e7060b41f249429341c49246e32e1e5cb05d2c4d9f83a, preserving 568 raw command receipts and verified logs. Its status is requested execution complete; overall qualification NOT GREEN. $RefreshEvidence denotes that evidence directory; $Python is the maintained interpreter already recorded below. These are recorded execution receipts, not new runs by this metadata session.

Exact execution scope Result
2000 NVX with clean b09 ARM VMM, bound by current-native-runtime-inputs-refresh1.json SHA256 f5223d14bb7060a4182f3a93f863256402148b2d7d14625d950591f3f6935a06 173 CLI commands PASS: 45 cold / 53 scenario records / 28 scenarios, plus 128 repetition commands / 135 records. These are not VM counts. Scratch and RAM each run 10 Start/Stop cycles on one provision.
Consolidated cold runtime adapter at the same pair 115 tests / 9 targets PASS; 46 snapshot tests excluded, not passed.
Guest registry at the same pair 845 selected: 833 PASS / exact 12 ignored, zero failures; ignored-name registry verified.
Real ARM debug kernels and explicit AUTO/HOST profiles 8 debug cells + 8 profile cells PASS, covering 1/2/4/8 VP SMP/sample/warp. Quiet 0 versus normal 115 kernel lines from actual passing boots. Normal product capture refusal: exact ARM cold-only error / exit 1 PASS.
Native Rust/action coverage Core all-feature library 1194 PASS / 6 ignored, default 1027 PASS / 6 ignored; 25 of 27 selected native gate commands exit 0. Windows adapter library 57 PASS / 1 FAIL (unchanged Win1314 error-kind outcome) remains a failure; missing-symlink branches were not executed. Independent recovery/interfaces/checks are recorded, not an all-native-gates green claim.
Separate coordinated OpenVMM-owner evidence for exact b09 Native ARM 514 PASS / 3 ignored, x64-on-ARM 210 PASS, 20 package groups, both-ISA checks/clippy/docs/fmt and three verifier cases (guest_started=false) passed. These do not replace strict upstream GitHub CI or physical x64 execution qualification.
Linux language/interface/shell checks ARM/MSRV/API and pinned shell checks resolved to PASS; Specula 25 PASS, guest-tool integration 20 PASS, adapter guest libtest groups passed. x86 guest/macOS results are cross-compilation only. Original missing dependency/target/git failures remain archived; dependencies were restored only after actual missing-prerequisite failures, with no silent skips.

Actual 24bd full maintained 37-module Python suite: & $Python -m unittest scripts/test_performance.py scripts/test_nvx_tools.py scripts/test_kconfig.py scripts/test_kernel_config.py scripts/test_guest_binaries.py scripts/test_microvm_tests.py scripts/test_nightly_ci.py scripts/test_development_release.py scripts/test_crate_release.py scripts/test_host_telemetry.py scripts/test_time_abi.py scripts/test_tool_versions.py scripts/test_markdown_links.py scripts/test_module_diagrams.py scripts/test_nvx_rs_mutants.py scripts/test_nvx_rs_coverage.py scripts/test_nvx_rs_scenario_coverage.py scripts/test_setup_azure.py scripts/test_setup_azure_linux.py scripts/test_setup_azure_windows.py scripts/test_powershell_testing.py scripts/test_test_layout.py scripts/test_test_changes.py scripts/test_public_api.py scripts/test_scripts_coverage.py scripts/test_openvmm_git.py scripts/test_openvmm_pin.py scripts/test_openvmm_release.py scripts/test_local_gates.py scripts/test_pr_threads.py scripts/test_ci_triage.py scripts/test_issue_workspace.py scripts/test_host_worktree.py scripts/test_rebase_check.py scripts/test_nvx_hosts.py scripts/test_host_probe.py scripts/test_benchmark_series.py -v returned exit 1, 2255 tests / 896.212 s / ZERO assertion failures. The precise outcome is 2147 complete-success methods, two partially successful methods, 3 Win1314 setup-error records in two unchanged Ubuntu methods, 107 skip records (104 whole-method + 3 subcases). Log SHA256 28d3f3cbe761bc5c7924f333a9149a19d2a7813c168d1b2bbf2091e8782a68d4. Errors remain in BuildTests.test_ubuntu_customization_keeps_an_existing_wget_link (busybox/wget.real subcases) and BuildTests.test_ubuntu_customization_keeps_wget_installed_by_a_package; those bodies and failing _ensure_symlink helper retain baseline ASTs, not a claim that their entire files match baseline. No added skip/elevation/assertion weakening fixes those errors.

The exact six-case regression command & $Python -m unittest -v test_nvx_tools.CiConfigurationTests.test_ci_runs_the_steps_after_the_default_microvm_suite_beside_it test_microvm_tests.MicrovmTests.test_runner_flushes_each_progress_line_before_its_scenario test_microvm_tests.MicrovmTests.test_runner_reports_every_scenario_execution test_microvm_tests.MicrovmTests.test_only_arm_expands_boot_and_managed_processor_selection test_microvm_tests.MicrovmTests.test_runner_dispatches_selected_scenarios_once test_nvx_tools.CiConfigurationTests.test_ci_jobs_download_exactly_the_guest_artifacts_that_they_read PASS, covering all three corrected methods plus existing explicit ARM/default-x86 and artifact-binding fixtures. This owner's prior 58 selectors plus the three corrections also PASS: 61 / zero skips; raw red-at-2000 and green-at-corrected-source evidence is retained. & $Python -m compileall -q scripts, & $Python -m ruff check scripts .github\specula, & $Python -m ruff format --check scripts .github\specula, both & $Python -m pyright --pythonpath $Python --pythonplatform Linux / Windows, & $Python scripts\nvx.py verify, test-layout, links, kernel inventories and recorded format/PowerShell syntax checks PASS; full strict type views have zero errors/warnings. Exact commands/results are preserved in the final descriptor and linked static/source ledgers. No complete 37-module duplicate rerun occurred in this owner.

Current host doctor is NOT green: doctor --backend whp --architecture aarch64 --checks H1 H2 H3 H4 H5 H6 H7 used the full 13 samples / 10 s schedule and returned exit 1. H1/H2/H3/H5/H6 PASS; H4 FAIL (host UTC free-running, GetSystemTimeAdjustmentPrecise disabled=1) and H7 FAIL (W32Time not started, 0x80070426). Current H5: 66 pairs, 26 ns offset / 156 ns uncertainty, unchanged 1000 ns bound. Current H6: 128 MiB, 8 VP five rounds with idle gaps 0.1/1/5/1 s plus one VP; zero backward, 52 ns offset / 391 ns uncertainty. Older host 52/182, guest 52/313 and previous full matrices below remain their historical source-pair evidence. No host service, clock, security, threshold or CI waiver was applied.

Explicit proof limits: normal-product ARM restore refusal is NOT PROVED (retained pre-manifest empty-fixture failure; source/unit guard is separate). Deterministic active-VP0/AP-overlap product proof is NOT PROVED. The 37-callback MMIO unit test is not raw-product concurrency proof. No ARM restore/snapshot/Phase4 qualification is claimed. Exact b09 trusted upstream CI and actual NVX native-ARM CI are not qualified; normal policy rejects untrusted/missing evidence with no active trial allowance. Old strict 6036 eight-MISSING results and failed upstream AMD-SNP receipts remain historical/unwaived, not a current b09 gate run or overall CI-green claim. Final source/conflict/architecture/consumer review found no required redesign or obsolete primitive, but that is not runtime/CI proof beyond the receipts above.

Historical original-source validation (all results below retain their original scope)

Previously executed, audited evidence; not rerun by this publication session. The authoritative command definitions were inspected in .github/actions/check-quality/action.yml, .github/actions/validate-nvx/action.yml, and .github/actions/check-nvx-rs/action.yml. This is not a claim that every action or the full suite passed.

For the command spellings below, $Python is the recorded interpreter C:\Users\gautamahuja\aci\phase1-20261106\nvx\target\phase1-python\Scripts\python.exe, $Evidence is C:\Users\gautamahuja\aci\phase3-20261111\evidence, and the original source working directory is C:\Users\gautamahuja\aci\phase3-20261111\nvx. These are receipt locations, not paths expected to exist on a CI runner.

Source and CLI checks

Recorded command Audited result
& $Python -m ruff check scripts .github\specula PASS, exit 0.
& $Python -m ruff format --check scripts .github\specula PASS, exit 0.
& $Python -m compileall -q .github\specula PASS, exit 0.
& $Python -m pyright --pythonplatform Linux --pythonpath $Python PASS, zero errors/warnings, exit 0, with helper-injected PYTHONPATH unset.
& $Python -m pyright --pythonplatform Windows --pythonpath $Python PASS, zero errors/warnings, exit 0, with helper-injected PYTHONPATH unset. Earlier failed receipts retained.
& $Python scripts\nvx.py verify PASS, exit 0.
& $Python scripts\check_markdown_links.py PASS, exit 0.
& $Python scripts\check_test_layout.py PASS, exit 0; obsolete test hooks removed, not allowlisted more broadly.
& $Python scripts\nvx.py check-kernel-config PASS, exit 0.
& $Python scripts\nvx.py check-kernel-config --architecture aarch64 PASS, exit 0.
& $Python scripts\check_test_changes.py --base origin/dev PASS as an inventory command, exit 0; not a claim of unmodified tests.
& $Python scripts\check_test_changes.py --base cb017cf8aee13e5e7276236d1b0ab328e1b52e7f Final committed-blob comparison reports 215 existing test/wiring assets changed and 18 added items. Precommit invocations at CB017 are not the final top-layer inventory.
& $Python scripts\test_adversarial.py -v Unit suite PASS: 84 selected, 73 executed/passed, 11 platform skips. Not an adversarial campaign.
git --no-pager diff --check HEAD PASS, exit 0, in the original precommit source check.

The exact final maintained Python suite command was:

& $Python -m unittest scripts\test_performance.py scripts\test_nvx_tools.py scripts\test_kconfig.py scripts\test_kernel_config.py scripts\test_guest_binaries.py scripts\test_microvm_tests.py scripts\test_nightly_ci.py scripts\test_development_release.py scripts\test_crate_release.py scripts\test_host_telemetry.py scripts\test_time_abi.py scripts\test_tool_versions.py scripts\test_markdown_links.py scripts\test_module_diagrams.py scripts\test_nvx_rs_mutants.py scripts\test_nvx_rs_coverage.py scripts\test_nvx_rs_scenario_coverage.py scripts\test_setup_azure.py scripts\test_setup_azure_linux.py scripts\test_setup_azure_windows.py scripts\test_powershell_testing.py scripts\test_test_layout.py scripts\test_test_changes.py scripts\test_public_api.py scripts\test_scripts_coverage.py scripts\test_openvmm_git.py scripts\test_openvmm_pin.py scripts\test_openvmm_release.py scripts\test_local_gates.py scripts\test_pr_threads.py scripts\test_ci_triage.py scripts\test_issue_workspace.py scripts\test_host_worktree.py scripts\test_rebase_check.py scripts\test_nvx_hosts.py scripts\test_host_probe.py scripts\test_benchmark_series.py -v

NOT GREEN, exit 1: 2230 selected methods, 2123 executed, 2121 passed, 107 skipped, three WinError 1314 error records in two AST-unchanged Ubuntu methods (BuildTests.test_ubuntu_customization_keeps_an_existing_wget_link and BuildTests.test_ubuntu_customization_keeps_wget_installed_by_a_package), zero assertion failures. No symlink-privilege workaround or test weakening was applied. Six maintained PowerShell setup files also parsed without errors; no publication-time rerun is claimed.

Rust and native cold evidence

The initial maintained Rust batch was 22/24 gates passing, not fully green. The unchanged Windows host-adapter library outcome was 57/58 with a WinError 1314 error-kind mismatch (Uncategorized versus PermissionDenied); the other nonzero gate was intentional ARM-host rejection of the x86 release-catalog bundle. Independent adapter integrations passed. Explicit x64 bundling with NVX_BUNDLE unset was compile-only, not fresh native x86 execution.

Recorded command or receipt Audited result
cargo +1.97.1 fmt --all --check PASS, exit 0.
cargo +1.97.1 test --locked --target aarch64-unknown-linux-musl --no-default-features --features guest --lib time_probe -- --nocapture PASS in the recorded Linux Docker environment; actual ARM probe tests.
cargo +1.97.1 clippy --locked --all-targets --target aarch64-unknown-linux-musl --no-default-features --features guest -- -D warnings PASS in that recorded environment, exit 0.
cargo +1.97.1 doc --locked --no-deps --target aarch64-unknown-linux-musl --all-features PASS with NVX_BUNDLE=skip and RUSTDOCFLAGS=-D warnings; the separate guest-only Rustdoc attempt failed unchanged host links and remains disclosed.
cargo +1.89.0 check --locked --target aarch64-unknown-linux-musl --no-default-features --features guest --all-targets PASS, current ARM guest MSRV cross-check, exit 0.
cargo +1.97.1 clippy --locked --target x86_64-unknown-linux-musl --no-default-features --features guest --all-targets -- -D warnings PASS cross-check, not x86 hardware qualification.
python3 scripts/nvx.py test-guest-binaries --architecture aarch64 --binaries /out/guest-binaries PASS inside the recorded ARM Docker validation environment, exit 0.
& $Python "$Evidence\native_guest_units.py" coldfix1-ubuntu ubuntu normal-devfs current-native-runtime-inputs-coldfix1.json PASS: actual current static ARM guest ELF, 845 selected, 833 passed, 12 existing ignored; normal Ubuntu 4-VP fixture with guest-only devpts/FD links.
& $Python "$Evidence\native_console_proof.py" PASS, explicit normal 115 kernel lines versus quiet 0 kernel lines; no blanket ARM console suppression.
& $Python "$Evidence\native_matrix_restart.py" cold coldfix1-full current-native-runtime-inputs-coldfix1.json PASS: complete 45 CLI cells / 53 scenario records / 28 distinct scenarios on native ARM64/WHP.
& $Python "$Evidence\native_matrix_restart.py" adapter coldfix1 current-native-runtime-inputs-coldfix1.json PASS: 115 tests / 9 targets, with 46 snapshot tests deferred, not passed.
& $Python "$Evidence\native_matrix_restart.py" repeat coldfix1 current-native-runtime-inputs-coldfix1.json PASS: 128 CLI invocations / 135 scenario records, including ten Start/Stop cycles within ONE provision each for scratch and RAM-upper. These are not total VM counts.
& $Python "$Evidence\final_native_accounting.py" PASS, final native receipt/count reconciliation, exit 0.

Historical original-source runtime results are bound to pair SHA256 d7d0cb48294230956b619903258f873532388a9be907d0ade6bff123c4709532, the new kernel prefix c0101427, native static-CRT CLI prefix 00158fd2, and actual VMM prefix 2f776ab9 (gca913105d.dirty) with the disclosed source correspondence. Historical H6 passed 8 VP twice plus 1 VP once at the unchanged 1000 ns bound: maximum offset 52 ns, uncertainty 313 ns, backward step 0.

Original Docker namespace/mount EPERM failures, minimal-Alpine userland failures, missing-helper H6 failures (guest exit 97/127), and the original cold outcomes (28 PASS/17 FAIL, then 14 PASS/3 FAIL) remain in the evidence. The corrected complete batch removes no applicable ARM cells and does not weaken assertions or bounds.

Not passed, not run, or left to CI

H4/H7 and full UTC/host qualification remain NOT PASS (published-correction predicate and service/source proof). H1/H2/H3/H5/H6 passed in the scoped admission evidence, but the complete host command returned exit 1. disabled=TRUE alone is not independent proof of unsynchronized UTC. No service/security/clock change is authorized by publication.

Actual NVX native ARM pool admission and NetworkService admission (both SIDs) remain unproved; inventory access returned 403. The existing fork-headed workflow rejection is unchanged. Upstream selected-job evidence does not establish NVX CI admission, and this PR does not approve any exception.

No ARM snapshots/restore, optional adversarial campaign, PA widening, fresh native x86/KVM/MSHV qualification, Linux-only public-API/macOS gate success, performance result, or full-suite/overall-upstream-CI success is claimed. Leave applicable cross-platform/action gates and real CI runner admission to CI. The original Ready publication was the intended PR-event trigger at that time; the subsequent immutable manual trial is disclosed above. All three PRs are now actual Draft. No new manual dispatch, merge, queue admission, or auto-merge is requested.

Existing-test and CI-wiring change explanations

Apply tests-modified. The maintained committed comparison is against Phase 2 cb017cf8aee13e5e7276236d1b0ab328e1b52e7f, not the dirty precommit tree or an all-stack comparison to dev: 215 existing test/wiring changes, 18 added items. The frozen per-file explanation inventory covers these 29 changed files. Enclosing ISA cfg changes also affect the unchanged x86 time_probe/clock/tests.rs and time_probe/latency/tests.rs; both remain x86-only. The shared parent now admits aarch64 without admitting those x86-only modules there. Counts include inherited enclosing-cfg effects, not 215 newly written test methods.

File Reason and retained behavior
nvx-rs/src/guest/time_probe/format/tests.rs Exercise ISA-specific counter labels; preserve x86 TSC formatting and expectations.
nvx-rs/src/guest/time_probe/support/tests.rs Match the production ARM warp subset; keep x86-only overrides explicit errors.
nvx-rs/src/guest/time_probe/tests.rs Add focused ARM command admission/refusal tests; unsupported latency/clock/TSC override paths still fail explicitly.
nvx-rs/src/guest/time_probe/warp/tests.rs Exercise ISA-specific counter/frequency selection and the existing shared warp algorithm without changing bounds.
nvx-rs/tests/guest_tools.rs Execute the actual exported ARM probe entry point and warp command alongside existing guest-binary behavior, not a synthetic helper.
nvx-rs/tests/openvmm_cpu_profiles.rs Make the existing profile/verifier consumer architecture-aware; preserve original x86 profile checks.
scripts/test_guest_binaries.py Bind ARM producer inventory to the actual maintained SMP/H6 helper dependency so omission of the real time probe fails.
scripts/test_microvm_tests.py Cover shared cold selection, unchanged x86 full-case tails, VP/root/cycle forwarding, DT CPU address-cell decoding, and exact named MMIO/DT observations, including real shell fragments where applicable.
scripts/test_nvx_tools.py Cover native ARM host/PE consumers and existing producer/CI argument, artifact and status bindings, upstream six-plus-two job coverage and preserved trust rejection; retain unchanged Ubuntu symlink tests and the maintained PowerShell helper.
scripts/test_time_abi.py Exercise architecture-aware native verifier/catalog/time consumers and explicit wrong-ISA refusal without fabricating host or UTC qualification.
scripts/test_tool_versions.py Verify native ARM tool/target selection and bootstrap behavior; preserve x86 tool defaults.
scripts/test-layout-allowlist.json Remove obsolete architecture/test support seams after making required primitives real production support; tighten rather than loosen the allowlist.
scripts/nvx_tools/benchmark_scripts/smp-probe.sh.in Read DT-declared one- or two-cell CPU reg width and normalize identity; retain topology, timer, IPI and counter-warp assertions.
scripts/nvx_tools/microvm_test_scripts/filesystem-shares.sh Use shared ISA-correct fixed-device assertions rather than requiring x86 command-line enumeration on ARM.
scripts/nvx_tools/microvm_test_scripts/interrupt-map.sh.in Reuse exact named-resource readers; validate ARM DT/GIC SPI bindings without treating Linux allocated IRQ numbers as GIC INTIDs.
scripts/nvx_tools/microvm_test_scripts/lifecycle.sh Preserve exact raw-byte assertions; observe ARM time through the maintained sample interface and platform DATA device, not a fictional RTC or blanket console suppression.
scripts/nvx_tools/microvm_test_scripts/sandbox-blocks.sh Validate the same fixed block devices through actual ARM named MMIO/DT resources; preserve x86 observation paths.
scripts/nvx_tools/microvm_test_scripts/virtio-net.sh Validate the fixed network device using the shared architecture-correct assertion helper.
scripts/nvx_tools/microvm_test_scripts/virtio-mmio.sh New shared test prelude for exact Linux named MMIO ranges and ISA-specific DT/interrupt observations; no broad device-discovery fallback.
scripts/nvx_tools/microvm_tests.py Explicitly project supported cold cases, preserve default x86 full/snapshot tails, forward selected runtime dimensions, and use existing Alpine sandbox-control bootstrap for Ubuntu layered workloads.
scripts/nvx_tools/runtime_adapter_tests.py Select the existing capability-scoped cold registry on ARM and prove registry/listing consistency; report 46 unsupported snapshot tests as deferred.
scripts/nvx_tools/sandbox_lifecycle_tests.py Add bounded repeated Start/Stop within one provisioned scratch sandbox; retain state/refusal/overlap/crash/teardown assertions and default cycle behavior.
scripts/nvx_tools/sandbox_ram_upper_tests.py Add bounded repeated Start/Stop within one RAM-upper provision and assert state clears on each restart; retain default behavior.
.github/actions/build-guest-artifacts/action.yml Produce existing exports natively for selected architecture with architecture-bound artifact identity; preserve x86 outputs/defaults and pinned Docker/BuildKit mechanisms.
.github/actions/build-openvmm/action.yml Forward selected target through the existing action rather than adding an independent ARM build framework.
.github/actions/validate-runner/action.yml Use architecture-aware existing host/PE checks, selected-check semantics and resource prerequisites; no ARM-only H5/H7-per-job dependencies or H4 waiver.
.github/workflows/build-openvmm-binary.yml Bind existing reusable VMM artifact names and targets to requested architecture.
.github/workflows/run-nvx-microvm-tests.yml Forward architecture, scope, VP/root/memory/cycle dimensions and isolate artifacts through the existing reusable runner with normal teardown.
.github/workflows/ci.yml Wire fresh ARM producers/native consumers, complete cold cells, cold adapter and serial repetitions into existing artifact/duration/shard/required-status accounting; preserve x86 shards and exact aggregate status; require Windows ARM unit/VMM upstream evidence in addition to all six x86 jobs.

Production-file test-hook removals in guest status/clock/parse/scheduler support account for corresponding committed-report entries; they remove test-only gating from real shared support rather than adding inline tests or widening the allowlist.

Immutable evidence identity

The original local evidence is retained under $Evidence; these hashes identify audit artifacts, not downloadable GitHub attachments:

Artifact SHA256
phase3-final-pushed-publication-handoff.json 72b68e0d627306baadccd363d8259a0a70a0d0f73abec05cfe1d4f8fddc87a12
phase3-committed-inventory-correspondence.json 8e34a98a864d7eabb8bf05ce50140c9279261b708e86a0d7420a36759bfaa951
phase3-committed-test-changes.md 01a7eb19844aea9b8e4a221639d1114b333cd522f75f11ff5420c3d35ac8e9e7
phase3-test-change-explanations.json 4b0eebd4c95f264042b8d000b26db3a96fc5e0d5e280e4af8db920749f897630
phase3-final-source-product-gate-handoff.json e0c2401554ca69a159b585de430f1c6c9f7083b49b16017c98c3e40e07e2fbf8
Frozen source inventory 5d9c179097ee7fc64b3fa0f58f5f9ca5f96805db5be1e5658e7b565ffae40f8e
Accepted paired parent precommit audit 60a73b91ff6c9ba1318ab1e06930a773f8d4c635f96f8164c6819da0ff41e46c

The final committed test report, rather than an earlier precommit zero-change result, is authoritative. Original failures and protected logs remain preserved.

@ahuja-gautam Gautam Ahuja (ahuja-gautam) added the tests-modified Changes existing tests, test data, or test wiring label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

This pull request changes existing tests

It modifies or removes 218 existing test asset(s), listed below. Review each with care: a change to a test can hide a regression that the test caught. See doc/contribute.md#changes-to-existing-tests.

Test code

Change What Before After
modified attributes the inner attributes of guest::time_probe::clock::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/clock/tests.rs:1 nvx-rs/src/guest/time_probe/clock/tests.rs:1
modified attributes the inner attributes of guest::time_probe::format::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/format/tests.rs:1 nvx-rs/src/guest/time_probe/format/tests.rs:1
modified attributes the inner attributes of guest::time_probe::latency::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/latency/tests.rs:1 nvx-rs/src/guest/time_probe/latency/tests.rs:1
modified attributes the inner attributes of guest::time_probe::support::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/support/tests.rs:1 nvx-rs/src/guest/time_probe/support/tests.rs:1
modified attributes the inner attributes of guest::time_probe::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/tests.rs:1 nvx-rs/src/guest/time_probe/tests.rs:1
modified attributes the inner attributes of guest::time_probe::warp::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/warp/tests.rs:1 nvx-rs/src/guest/time_probe/warp/tests.rs:1
modified helper fn diagnostic in guest::time_probe::support::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/support/tests.rs:40 nvx-rs/src/guest/time_probe/support/tests.rs:43
modified helper fn args in guest::time_probe::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/tests.rs:6 nvx-rs/src/guest/time_probe/tests.rs:6
modified helper const GIGAHERTZ in guest::time_probe::warp::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/warp/tests.rs:5 nvx-rs/src/guest/time_probe/warp/tests.rs:5
modified helper fn leader in guest::time_probe::warp::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/warp/tests.rs:13 nvx-rs/src/guest/time_probe/warp/tests.rs:31
modified helper fn pair in guest::time_probe::warp::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/warp/tests.rs:26 nvx-rs/src/guest/time_probe/warp/tests.rs:44
modified helper fn measured in guest::time_probe::warp::tests (it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" and test hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" and test did) nvx-rs/src/guest/time_probe/warp/tests.rs:39 nvx-rs/src/guest/time_probe/warp/tests.rs:57
modified helper fn first_allowed_cpu in guest_tools (tests) (moved, and it now compiles where any ( target_arch = "x86_64" , target_arch = "aarch64" ) and feature = "guest" and target_os = "linux" hold, not where feature = "guest" and target_arch = "x86_64" and target_os = "linux" did) nvx-rs/tests/guest_tools.rs:1250 nvx-rs/tests/guest_tools.rs:1250
modified helper fn identity in openvmm_cpu_profiles (tests) nvx-rs/tests/openvmm_cpu_profiles.rs:17 nvx-rs/tests/openvmm_cpu_profiles.rs:17
modified helper fn by_id in openvmm_cpu_profiles (tests) nvx-rs/tests/openvmm_cpu_profiles.rs:39 nvx-rs/tests/openvmm_cpu_profiles.rs:57
modified helper def PublicSandboxLifecycleTests._run in scripts/test_microvm_tests.py scripts/test_microvm_tests.py:1541 scripts/test_microvm_tests.py:1601
modified helper def PublicSandboxRamUpperTests._run in scripts/test_microvm_tests.py scripts/test_microvm_tests.py:2812 scripts/test_microvm_tests.py:2908
modified helper def FilesystemSharesScenarioTests._run in scripts/test_microvm_tests.py scripts/test_microvm_tests.py:3487 scripts/test_microvm_tests.py:3622
modified helper def FilesystemPolicyScenarioTests._run in scripts/test_microvm_tests.py scripts/test_microvm_tests.py:3746 scripts/test_microvm_tests.py:3888
modified helper def MicrovmTests._interrupt_report in scripts/test_microvm_tests.py scripts/test_microvm_tests.py:11449 scripts/test_microvm_tests.py:11886
modified helper def _matrix_legs in scripts/test_nvx_tools.py scripts/test_nvx_tools.py:555 scripts/test_nvx_tools.py:555
modified helper def _resolve_inputs in scripts/test_nvx_tools.py scripts/test_nvx_tools.py:589 scripts/test_nvx_tools.py:589
modified helper def RuntimeAdapterSuiteTests._run in scripts/test_nvx_tools.py scripts/test_nvx_tools.py:21248 scripts/test_nvx_tools.py:22002
modified helper def DoctorTests.setUp in scripts/test_time_abi.py scripts/test_time_abi.py:2198 scripts/test_time_abi.py:2267
modified helper assignment PLATFORMS in scripts/test_tool_versions.py scripts/test_tool_versions.py:46 scripts/test_tool_versions.py:46

... and 105 more, which the job's summary lists.

End-to-end tests

Change What Before After
modified file scripts/nvx_tools/microvm_test_scripts/filesystem-shares.sh scripts/nvx_tools/microvm_test_scripts/filesystem-shares.sh scripts/nvx_tools/microvm_test_scripts/filesystem-shares.sh
modified file scripts/nvx_tools/microvm_test_scripts/interrupt-map.sh.in scripts/nvx_tools/microvm_test_scripts/interrupt-map.sh.in scripts/nvx_tools/microvm_test_scripts/interrupt-map.sh.in
modified file scripts/nvx_tools/microvm_test_scripts/lifecycle.sh scripts/nvx_tools/microvm_test_scripts/lifecycle.sh scripts/nvx_tools/microvm_test_scripts/lifecycle.sh
modified file scripts/nvx_tools/microvm_test_scripts/sandbox-blocks.sh scripts/nvx_tools/microvm_test_scripts/sandbox-blocks.sh scripts/nvx_tools/microvm_test_scripts/sandbox-blocks.sh
modified file scripts/nvx_tools/microvm_test_scripts/virtio-net.sh scripts/nvx_tools/microvm_test_scripts/virtio-net.sh scripts/nvx_tools/microvm_test_scripts/virtio-net.sh
modified helper def configure_parser in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:781 scripts/nvx_tools/microvm_tests.py:852
modified helper def _read_script in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:990 scripts/nvx_tools/microvm_tests.py:1080
modified helper def run_guest_boot in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:1261 scripts/nvx_tools/microvm_tests.py:1358
modified helper def run_smp in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:1903 scripts/nvx_tools/microvm_tests.py:2002
modified helper def run_ipv6_egress_policy in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:3602 scripts/nvx_tools/microvm_tests.py:3704
modified helper def run_private_network_ingress in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:4570 scripts/nvx_tools/microvm_tests.py:4674
modified helper class InterruptMapEntry in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:5381 scripts/nvx_tools/microvm_tests.py:5488
modified helper def parse_interrupt_map in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:5408 scripts/nvx_tools/microvm_tests.py:5516
modified helper def check_interrupt_map in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:5458 scripts/nvx_tools/microvm_tests.py:5574
modified helper def _interrupt_map_script in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:5538 scripts/nvx_tools/microvm_tests.py:5687
modified helper def run_interrupt_map in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:5553 scripts/nvx_tools/microvm_tests.py:5705
modified helper def run_filesystem_shares in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:10009 scripts/nvx_tools/microvm_tests.py:10177
modified helper def run_filesystem_policy in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:10333 scripts/nvx_tools/microvm_tests.py:10504
modified helper def run in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:11369 scripts/nvx_tools/microvm_tests.py:11543
modified helper def _run_scenarios in scripts/nvx_tools/microvm_tests.py scripts/nvx_tools/microvm_tests.py:11506 scripts/nvx_tools/microvm_tests.py:11732
modified helper assignment GUEST_AGENT in scripts/nvx_tools/runtime_adapter_tests.py scripts/nvx_tools/runtime_adapter_tests.py:32 scripts/nvx_tools/runtime_adapter_tests.py:41
modified helper def configure_parser in scripts/nvx_tools/runtime_adapter_tests.py scripts/nvx_tools/runtime_adapter_tests.py:52 scripts/nvx_tools/runtime_adapter_tests.py:68
modified helper def cargo_test in scripts/nvx_tools/runtime_adapter_tests.py scripts/nvx_tools/runtime_adapter_tests.py:122 scripts/nvx_tools/runtime_adapter_tests.py:148
modified helper def suite_problems in scripts/nvx_tools/runtime_adapter_tests.py scripts/nvx_tools/runtime_adapter_tests.py:232 scripts/nvx_tools/runtime_adapter_tests.py:261
modified helper def command_test_runtime_adapter in scripts/nvx_tools/runtime_adapter_tests.py scripts/nvx_tools/runtime_adapter_tests.py:268 scripts/nvx_tools/runtime_adapter_tests.py:317

... and 8 more, which the job's summary lists.

CI test wiring

Change What Before After
added a line that may skip line if: runner.os == 'Windows' .github/workflows/run-nvx-microvm-tests.yml:160
added a line that may skip line if os.environ["RESULT_ID"] and re.fullmatch(r"[A-Za-z0-9_.-]+", os.environ["RESULT_ID"]) is None: .github/workflows/run-nvx-microvm-tests.yml:192
added a line that may skip line if not isinstance(scenarios, list) or not all(isinstance(s, str) for s in scenarios): .github/workflows/run-nvx-microvm-tests.yml:196
added a line that may skip line if not isinstance(processors, list) or not all(type(p) is int for p in processors): .github/workflows/run-nvx-microvm-tests.yml:198
added a line that may skip line if cycles < 1 or (os.environ["RUNNER_OS"] != "Windows" and cycles != 1): .github/workflows/run-nvx-microvm-tests.yml:201
added a line that may skip line if architecture == "aarch64": .github/workflows/run-nvx-microvm-tests.yml:205
added a line that may skip line if backend != "whp" or not cold or debug or os.environ["GUESTS_AND_SANDBOXES"] == "true": .github/workflows/run-nvx-microvm-tests.yml:206
added a line that may skip line if not scenarios and os.environ["RUNTIME_ADAPTER"] != "true": .github/workflows/run-nvx-microvm-tests.yml:208
added a line that may skip line for scenario in scenarios: .github/workflows/run-nvx-microvm-tests.yml:212
added a line that may skip line if processors: .github/workflows/run-nvx-microvm-tests.yml:214
added a line that may skip line for name, option in (("START_STOP_CYCLES", "--start-stop-cycles"), ("MEMORY_MIB", "--memory-mib")): .github/workflows/run-nvx-microvm-tests.yml:216
added a line that may skip line if value < 0: .github/workflows/run-nvx-microvm-tests.yml:218
added a line that may skip line if value: .github/workflows/run-nvx-microvm-tests.yml:220
added a line that may skip line if cold: .github/workflows/run-nvx-microvm-tests.yml:222
added a line that may skip line if debug: .github/workflows/run-nvx-microvm-tests.yml:224
added a line that may skip line if int(os.environ["SHARD"]): .github/workflows/run-nvx-microvm-tests.yml:226
added a line that may skip line if os.environ["MANAGED_ROOT"] != "initramfs": .github/workflows/run-nvx-microvm-tests.yml:228
added a line that may skip line if: runner.os != 'Windows' .github/workflows/run-nvx-microvm-tests.yml:249
added a line that may skip line if: ${{ (inputs.guests-and-sandboxes || inputs.guest == 'ubuntu') && !inputs.debug-kernel }} .github/workflows/run-nvx-microvm-tests.yml:282
added a line that may skip line if: ${{ !inputs.guests-and-sandboxes && !inputs.runtime-adapter && !inputs.debug-kernel && !inputs.shard && (steps.co... .github/workflows/run-nvx-microvm-tests.yml:298
added a line that may skip line if: ${{ (inputs.guests-and-sandboxes || inputs.guest == 'azurelinux') && !inputs.debug-kernel }} .github/workflows/run-nvx-microvm-tests.yml:315
added a line that may skip line for ($cycle = 1; $cycle -le $selected.cycles; $cycle++) { .github/workflows/run-nvx-microvm-tests.yml:385
added a line that may skip line if ($selected.cycles -gt 1) { .github/workflows/run-nvx-microvm-tests.yml:387
added a line that may skip line if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } .github/workflows/run-nvx-microvm-tests.yml:391
modified line name: guest-kernel .github/workflows/run-nvx-microvm-tests.yml:113 .github/workflows/run-nvx-microvm-tests.yml:265

... and 30 more, which the job's summary lists.

Relocated unchanged: 0; added: 23. Compared the merge base aacccd99e132 with 24bdced073a2.

Copilot AI balanced review requested due to automatic review settings November 12, 2026 05:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unproved native ARM64 admission and host-time qualification, together with an unmerged OpenVMM pin and temporary CI trust exception, require maintainer verification of landing order and coordinated rollback.

No open issues 🎉

What changed in this PR

This third layer of the ARM64 stack extends NVX’s existing cold-runtime validation to native Windows/WHP. It shares diagnostics, sandbox tests, artifact handling, and CI infrastructure with x86 while keeping ARM snapshot support outside scope.

Changes:

  • Add ARM counter-warp diagnostics and architecture-aware CPU, device, interrupt, and console checks.
  • Extend native tooling, artifact validation, cold-only adapter selection, and repeated sandbox Start/Stop checks.
  • Wire architecture-specific CI inputs and results, remove the shared Windows argument binder’s Bash dependency, and add the narrowly scoped temporary OpenVMM CI evidence exception.
File Description
tests/​runtime-adapter/​README.md Document native ARM execution and cold-only test selection.
scripts/​test-layout-allowlist.json Remove obsolete test-hook allowances.
scripts/​test_tool_versions.py Cover ARM tool selection and explicit runner host types.
scripts/​test_guest_binaries.py Verify ARM inventory includes the shared warp probe.
scripts/​setup/​tool-versions.conf Pin native Windows ARM tool artifacts.
scripts/​setup/​setup-windows-whp.ps1 Select native tools, targets, artifacts, and runner labels.
scripts/​setup/​setup-linux.sh Accept Windows ARM entries in the shared manifest.
scripts/​setup/​README.md Explain ARM provisioning and runner admission boundaries.
scripts/​nvx_tools/​time_abi.py Parse ARM profile identities and select counter validation.
scripts/​nvx_tools/​sandbox_ram_upper_tests.py Repeat RAM-upper starts and verify state resets.
scripts/​nvx_tools/​sandbox_lifecycle_tests.py Repeat scratch-backed starts and retain per-cycle evidence.
scripts/​nvx_tools/​runtime_adapter_tests.py Validate native artifacts and select classified cold tests.
scripts/​nvx_tools/​openvmm_ci.py Require ARM jobs and constrain the temporary fork-run exception.
scripts/​nvx_tools/​microvm_test_scripts/​virtio-net.sh Use shared architecture-aware network-device checks.
scripts/​nvx_tools/​microvm_test_scripts/​virtio-mmio.sh Add fixed MMIO resource and ARM interrupt-binding checks.
scripts/​nvx_tools/​microvm_test_scripts/​sandbox-blocks.sh Check fixed block-device windows across architectures.
scripts/​nvx_tools/​microvm_test_scripts/​lifecycle.sh Observe ARM time, early console, and raw-byte output.
scripts/​nvx_tools/​microvm_test_scripts/​interrupt-map.sh.in Report ARM device-tree bindings and interrupt errors.
scripts/​nvx_tools/​microvm_test_scripts/​filesystem-shares.sh Use shared fixed-device checks for filesystem shares.
scripts/​nvx_tools/​microvm_shards.py Exclude ARM and cold-only reports from x86 shard estimates.
scripts/​nvx_tools/​microvm_durations.py Record architecture, scope, and execution variants.
scripts/​nvx_tools/​host_time_probe.rs Add ARM architected-counter reads and frequency reporting.
scripts/​nvx_tools/​guest_binaries.py Include the time probe in ARM guest exports.
scripts/​nvx_tools/​common.py Add host architecture detection and Windows PE checks.
scripts/​nvx_tools/​ci.py Account for ARM producers, runtime checks, and repetitions.
scripts/​nvx_tools/​benchmark.py Forward architecture into time monitoring and SMP probes.
scripts/​nvx_tools/​benchmark_scripts/​smp-probe.sh.in Check ARM CPU identities, timers, and interprocessor interrupts.
nvx-rs/​tests/​openvmm_cpu_profiles.rs Compare ARM catalog identities with pinned OpenVMM profiles.
nvx-rs/​tests/​guest_tools.rs Exercise the actual ARM warp-probe executable.
nvx-rs/​src/​host/​cli/​cpu_profile.rs Keep ARM identities outside x86 CPU guidance.
nvx-rs/​src/​host/​cli/​cpu_generations.json Add the registered ARM CPU profile identity.
nvx-rs/​src/​guest/​time_probe/​warp/​tests.rs Test ARM counter frequency and affinity restoration.
nvx-rs/​src/​guest/​time_probe/​warp.rs Share warp algorithms with ARM counter reads.
nvx-rs/​src/​guest/​time_probe/​tests.rs Cover ARM output and unsupported-command refusals.
nvx-rs/​src/​guest/​time_probe/​support/​tests.rs Keep x86-specific parsing tests architecture-gated.
nvx-rs/​src/​guest/​time_probe/​support.rs Add ARM frequency metadata and isolate x86 helpers.
nvx-rs/​src/​guest/​time_probe/​mod.rs Expose ARM warp commands with architecture-specific help.
nvx-rs/​src/​guest/​time_probe/​format/​tests.rs Gate tests for x86-only formatting helpers.
nvx-rs/​src/​guest/​time_probe/​format.rs Restrict unused clock-formatting helpers to x86.
nvx-rs/​src/​guest/​sys/​scheduler.rs Make affinity queries available to ARM production code.
nvx-rs/​src/​guest/​sys/​mod.rs Export shared affinity support across architectures.
nvx-rs/​src/​guest/​sys/​clock.rs Expose the coarse monotonic clock on ARM.
nvx-rs/​src/​guest/​status.rs Share diagnostic setup-failure statuses with ARM.
nvx-rs/​src/​guest/​parse.rs Enable shared integer parsing on ARM.
nvx-rs/​src/​guest/​mod.rs Enable the ARM time-probe module.
nvx-rs/​src/​bin/​nvx-time-probe.rs Enable the real probe entry point on ARM Linux.
nvx-rs/​README.md Document ARM warp commands and counter reporting.
kernel/​patches/​arm64/​0001-nvx-platform-mmio.patch Apply log-level options before early-console output.
doc/​usage.md Describe architecture selection, cold scope, and repetitions.
doc/​openvmm-upstream-roadmap.md Map the selected ARM foundation and verifier commits.
doc/​ci.md Document ARM CI coverage, limitations, and the temporary exception.
doc/​build.md Describe the expanded ARM guest-helper inventory.
.github/​workflows/​run-nvx-microvm-tests.yml Bind shared inputs through Python and route architecture-specific evidence.
.github/​workflows/​build-openvmm-binary.yml Forward architecture to validation and build actions.
.github/​actions/​validate-runner/​action.yml Validate native architecture and select applicable qualification checks.
.github/​actions/​build-openvmm/​action.yml Verify the Windows binary’s PE architecture.
.github/​actions/​build-guest-artifacts/​action.yml Produce fresh native ARM artifacts in separate output paths.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 12, 2026 05:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainer review is required for the temporary fork-CI trust exception and rollback, OpenVMM landing and base compatibility, and unproved native ARM64/WHP NetworkService admission and host-time qualification.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 12, 2026 05:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainers must verify ARM64/WHP runner and Network Service admission, resolve nonpassing H4/H7 qualification, and coordinate the conflicted OpenVMM pin’s landing and rollback of the temporary fork-CI trust exception.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 12, 2026 05:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unverified native ARM64/WHP runner and service-account admission, runtime evidence from a dirty OpenVMM build, and unresolved pin compatibility require maintainer inspection before landing.

No open issues 🎉

Review effort: Balanced

@ahuja-gautam
Gautam Ahuja (ahuja-gautam) force-pushed the gautamahuja-microsoft-nvx-phase-3-pr branch from 44d5cca to 34aa63a Compare November 12, 2026 20:32
Copilot AI balanced review requested due to automatic review settings November 12, 2026 20:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ARM counter read lacks ordering needed for reliable skew measurements, and explicit Azure Linux scenarios can fail because the workflow skips the required initramfs download.

2 open issues

Review effort: Balanced

Comment thread scripts/nvx_tools/host_time_probe.rs Resolved
@ahuja-gautam
Gautam Ahuja (ahuja-gautam) marked this pull request as draft November 12, 2026 21:04
@ahuja-gautam
Gautam Ahuja (ahuja-gautam) force-pushed the gautamahuja-microsoft-nvx-phase-3-pr branch from 34aa63a to 810e881 Compare November 12, 2026 22:38
Copilot AI balanced review requested due to automatic review settings November 12, 2026 22:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Cross-ISA kernel and timing changes require maintainer assessment because final-head native ARM64/WHP runtime, H4/H7 qualification, service-account admission, and exact-pin integration remain unverified.

2 open issues

Review effort: Balanced

@ahuja-gautam
Gautam Ahuja (ahuja-gautam) force-pushed the gautamahuja-microsoft-nvx-phase-3-pr branch from 810e881 to 6967db8 Compare November 12, 2026 23:40
Copilot AI balanced review requested due to automatic review settings November 12, 2026 23:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description still names the old unchanged pin and six-commit replay, conflicting with the roadmap’s new baseline and leaving reviewers unable to distinguish current-head validation from historical results.

1 open issue
2 resolved since last review

Review effort: Balanced

Comment thread doc/openvmm-upstream-roadmap.md Resolved
Run the maintained host/PE probes, cold scenario inventory, bounded
same-provision repetitions and cold runtime-adapter tests on native
ARM64/WHP while retaining x86 defaults and full snapshot tails.

Carry architecture through existing artifact producers and CI callers,
require upstream Windows ARM unit/VMM evidence in addition to x86 jobs,
and preserve the existing workflow/repository trust filter.

Export the real ARM counter warp helper and correct ISA-specific device,
SMP, layered-bootstrap and console observations. Pin the published
OpenVMM verifier without rewriting the Phase 1/2 prefix.

Native functional evidence covers 45 cold CLI cells, 115 adapter tests
and 128 repetition CLI invocations. H4/H7, full UTC qualification and
actual CI service admission remain unqualified; no ARM release-catalog
or snapshot qualification is claimed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Admit only the authorized upstream-hosted run 43109699910 for PR 5045 and pin 38016, checking the live PR tuple and audited workflow blob. Keep trusted upstream admission and every selected latest-job verdict unchanged. Revert this isolated commit only after the coordinator ends the trial.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the existing shared Python binder directly with the native Python custom shell. Preserve its Python AST, environment, guards, argument JSON and step outputs. Execute the maintained binder tests with an empty PATH so a Bash dependency cannot be hidden by the test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
GitHub cannot resolve runner context while validating a step shell. Use the existing backend input, whose WHP jobs run on Windows, to select native Python. Restrict the regression harness to the same available input context and use the Linux backend for the Linux refusal case. Retain the failed startup run as evidence; do not rewrite either isolated commit.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
GitHub also rejects inputs context in the shell field. Use two mutually exclusive OS-guarded literal Python shells, sharing one anchored script and environment. Preserve the binder AST and JSON and coalesce the selected step output for its existing artifact consumer. Retain both failed startup receipts; do not rewrite history.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This reverts commit 19d29eb after the coordinator ended the bounded trial. Restore the exact pretrial evidence policy, tests and documentation while retaining all permanent native-Python correctness binder repairs. The immutable a0 workflow-dispatch evidence remains valid for that historical branch-only trial; do not cancel or redispatch it.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the original x86 fixed-NIC command-line assertion, guest-file adapter admission, and one-VP guest-boot/managed dispatch even with explicit SMP processor selections. Apply added native-ISA/static-ELF admission and processor expansion only to ARM, retaining its MMIO/DT and negative admission coverage. Restore the strict unresolved-template assertion over its original template scope. Add focused regression cases for both architectures and document the separate contracts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Download the Azure Linux initramfs for an explicit Azure Linux correctness selection while retaining the debug-kernel exclusion. Preserve both native-Python correctness binder steps unchanged. Match the maintained guest CNTVCT_EL0 read with leading and trailing ISB and a compiler memory barrier, leaving the x86 probe unchanged. Extend the existing artifact-binding and source-version probe regression tests.

The exact native ARM probe passed H5 across all 66 CPU pairs at the unchanged 1000 ns bound. Full-schedule H4 rate measurements met their existing limits but H4 still failed because the host publishes a free-running UTC clock (disabled=1); retain that failure, without retries or clock/service changes. This is host-diagnostic evidence, not OpenVMM backend or full host qualification.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Recognize the explicit Azure Linux guest-download conjunct in the workflow selector map without weakening its strict expression check. Restore default-x86 progress and execution expectations: boot and managed lifecycle stay at one VP while console exit and SMP variants expand the selected counts. Retain the existing explicit ARM processor-expansion parameterization and exact report assertions. Production code, workflow policy and runtime inputs are unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ahuja-gautam
Gautam Ahuja (ahuja-gautam) force-pushed the gautamahuja-microsoft-nvx-phase-3-pr branch from 6967db8 to 24bdced Compare November 13, 2026 21:27
Copilot AI balanced review requested due to automatic review settings November 13, 2026 21:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Exact-source ARM64/WHP runtime validation and runner/service-account admission remain unproven, leaving the early-console and counter-ordering changes dependent on maintainer review of trusted platform evidence.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py,
reads the pull request through gh api and passes it when GitHub links
it to an issue of the repository (closingIssuesReferences) or when
its description holds close, fix, resolve (in any form), Part of, or
Refs, with an optional colon, then #N, microsoft/nvx#N, or the
issue's URL, where N is an issue. A pull request's number, a missing
number, a bare #N, another repository's issue, and references in HTML
comments or Markdown code do not count, nor does a keyword that one
of them or the end of a block separates from its number: the script
reads quotes, lists, headings, code, and comments as CommonMark does.
It looks up at most the first 10 numbers, so a description cannot
make it call the API without bound. Pull requests by dependabot[bot]
or github-actions[bot], or labelled no-issue, are exempt, and closed
ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1678, which
GitHub links to #1677, flag #1675, #1516, and #1509, as reading
their descriptions confirms, and leave merged pull requests such
as #1672 alone; before they merged, they passed #1674, which
GitHub linked to #1666, and flagged #1671.

test_issue_link.py covers the parser, with indented code, fences that
end with their container, and hidden text or a block end between a
keyword and its number; the verdicts and the writes through a fake gh
api, the bound on lookups, an API error at each read, a comment that
quotes the marker, and the workflow's triggers, permissions, checkout,
concurrency, and inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py,
reads the pull request through gh api and passes it when GitHub links
it to an issue of the repository (closingIssuesReferences) or when
its description holds close, fix, resolve (in any form), Part of, or
Refs, with an optional colon, then #N, microsoft/nvx#N, or the
issue's URL, where N is an issue. A pull request's number, a missing
number, a bare #N, another repository's issue, and references in HTML
comments or Markdown code do not count, nor does a keyword that one
of them or the end of a block separates from its number: the script
reads quotes, lists, headings, code, and comments as CommonMark does.
It looks up at most the first 10 numbers, so a description cannot
make it call the API without bound. Pull requests by dependabot[bot]
or github-actions[bot], or labelled no-issue, are exempt, and closed
ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1678, which
GitHub links to #1677, flag #1675, #1516, and #1509, as reading
their descriptions confirms, and leave merged pull requests such
as #1672 alone; before they merged, they passed #1674, which
GitHub linked to #1666, and flagged #1671.

test_issue_link.py covers the parser, with indented code, fences that
end with their container, and hidden text or a block end between a
keyword and its number; the verdicts and the writes through a fake gh
api, the bound on lookups, an API error at each read, a comment that
quotes the marker, and the workflow's triggers, permissions, checkout,
concurrency, and inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py,
reads the pull request through gh api and passes it when GitHub links
it to an issue of the repository (closingIssuesReferences) or when
its description holds close, fix, resolve (in any form), Part of, or
Refs, with an optional colon, then #N, microsoft/nvx#N, or the
issue's URL, where N is an issue. A pull request's number, a missing
number, a bare #N, another repository's issue, and references in HTML
comments or Markdown code do not count, nor does a keyword that one
of them or the end of a block separates from its number: the script
reads quotes, lists, headings, code, and comments as CommonMark does,
and lets a comment run across blocks, as a browser does, until raw
HTML ends it. It looks up at most the first 10 numbers, so a
description cannot make it call the API without bound. Pull requests
by dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1678, which
GitHub links to #1677, flag #1675, #1516, and #1509, as reading
their descriptions confirms, and leave merged pull requests such
as #1672 alone; before they merged, they passed #1674, which
GitHub linked to #1666, and flagged #1671. Each parser case also
agrees with what GitHub's Markdown API renders, apart from a
reference that a comment splits and a pull request's URL.

test_issue_link.py covers the parser, with indented code, fences that
end with their container, setext headings, sibling list items,
comments that outlast their block or end as a browser ends them, and
hidden text or a block end between a keyword and its number; the
verdicts and the writes through a fake gh api, the bound on lookups,
an API error at each read, a comment that quotes the marker or has no
author, and the workflow's triggers, permissions, checkout,
concurrency, and inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py,
reads the pull request through gh api and passes it when GitHub links
it to an issue of the repository (closingIssuesReferences) or when
its description holds close, fix, resolve (in any form), Part of, or
Refs, with an optional colon, then #N, microsoft/nvx#N, or the
issue's URL, where N is an issue. A pull request's number, a missing
number, a bare #N, another repository's issue, and references in HTML
comments or Markdown code do not count, nor does a keyword that one
of them or the end of a block separates from its number: the script
reads quotes, lists, headings, code, and comments as CommonMark does,
and lets a comment run across blocks, as a browser does, until raw
HTML ends it. It looks up at most the first 10 numbers, so a
description cannot make it call the API without bound. Pull requests
by dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1678, which
GitHub links to #1677, flag #1675, #1516, and #1509, as reading
their descriptions confirms, and leave merged pull requests such
as #1672 alone; before they merged, they passed #1674, which
GitHub linked to #1666, and flagged #1671. Each parser case also
agrees with what GitHub's Markdown API renders, apart from a
reference that a comment splits and a pull request's URL.

test_issue_link.py covers the parser, with indented code, fences that
end with their container, setext headings, sibling list items,
comments that outlast their block or end as a browser ends them, and
hidden text or a block end between a keyword and its number; the
verdicts and the writes through a fake gh api, the bound on lookups,
an API error at each read, a comment that quotes the marker or has no
author, and the workflow's triggers, permissions, checkout,
concurrency, and inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py,
reads the pull request through gh api, in UTF-8 whatever the locale,
and passes it when GitHub links it to an issue of the repository
(closingIssuesReferences) or when its description holds close, fix,
resolve (in any form), Part of, or Refs, with an optional colon,
then #N, microsoft/nvx#N, or the issue's URL, where N is an issue. A
pull request's number, a missing number, a bare #N, another
repository's issue, and references in HTML comments or Markdown code
do not count, nor does a keyword that one of them or the end of a
block separates from its number: the script reads quotes, lists,
headings, code, and HTML blocks as GitHub's CommonMark does, reads
raw HTML as text but for its comments, and lets a comment run across
blocks, as a browser does, until raw HTML ends it. It looks up at
most the first 10 numbers, so a description cannot make it call the
API without bound. Pull requests by dependabot[bot] or
github-actions[bot], or labelled no-issue, are exempt, and closed
ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1678, which
GitHub links to #1677, flag #1675, #1516, and #1509, as reading
their descriptions confirms, and leave merged pull requests such
as #1672 alone; before they merged, they passed #1674, which
GitHub linked to #1666, and flagged #1671. Each parser case also
agrees with what GitHub's Markdown API renders, apart from a
reference that a comment splits, a pull request's URL, and the text
of a declaration, which GitHub hides.

test_issue_link.py covers the parser, with indented code, fences that
end with their container, setext headings, sibling and empty list
items, HTML blocks, comments that outlast their block or end as a
browser ends them, and hidden text or a block end between a keyword
and its number; the verdicts and the writes through a fake gh api,
gh's input and output in UTF-8, the bound on lookups, an API error at
each read, a comment that quotes the marker or has no author, and the
workflow's triggers, permissions, checkout, concurrency, and inputs.
validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py, reads
the pull request through gh api, in UTF-8 whatever the locale, and
passes it when GitHub links it to an issue of the repository
(closingIssuesReferences) or when its description holds close, fix,
resolve (in any form), Part of, or Refs, with an optional colon,
then #N, microsoft/nvx#N, or the issue's URL, where N is an issue. A
pull request's number, a missing number, a bare #N, and another
repository's issue do not count. The script reads the description as
GitHub renders it, through the Markdown API in the repository's context,
and only the text that GitHub shows counts: not an HTML comment, an
attribute such as a link's title, or code, inline, fenced, indented, or
in <pre>, nor a keyword that code or the end of a block, such as a list
item or a table cell, separates from its number. GitHub's own renderer
keeps the check in step with what the pull request's page shows, which a
parser of CommonMark, GFM tables, and raw HTML written here kept
missing. It looks up at most the first 10 numbers, so a description
cannot make it call the API without bound. Pull requests by
dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1687, #1686,
and #1682, which GitHub links to issues, and #1679, whose description
references #1676, and flag #1675, #1516, #1510, and #1509, as reading
their descriptions confirms. A 64 KiB description renders in about a
second, and its text reads in at most 60 ms.

test_issue_link.py covers the reading of GitHub's HTML, as gh api
markdown renders it: keywords and targets, other repositories, code and
<pre>, attributes, the ends of blocks and table cells, and inline
elements; the verdicts and the writes through a fake gh api, the render
request, gh's input and output in UTF-8, the bound on lookups, an API
error at each read, a comment that quotes the marker or has no author,
and the workflow's triggers, permissions, checkout, concurrency, and
inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py, reads
the pull request through gh api, in UTF-8 whatever the locale, and
passes it when GitHub links it to an issue of the repository
(closingIssuesReferences) or when its description holds close, fix,
resolve (in any form), Part of, or Refs, with an optional colon,
then #N, microsoft/nvx#N, or the issue's URL, where N is an issue. A
pull request's number, a missing number, a bare #N, and another
repository's issue do not count. The script reads the description as
GitHub renders it, through the Markdown API in the repository's context,
and only the text that GitHub shows counts: not an HTML comment, an
attribute such as a link's title, or code, inline, fenced, indented, or
in <pre>, nor a keyword that code or the end of a block, such as a list
item or a table cell, separates from its number. A link counts by where
it goes, whatever its text: a link to an issue or a pull request as
OWNER/REPO#N, and any other link as code does. GitHub's own renderer
keeps the check in step with what the pull request's page shows, which a
parser of CommonMark, GFM tables, and raw HTML written here kept
missing. It looks up at most the first 10 numbers, so a description
cannot make it call the API without bound. Pull requests by
dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1687, #1686,
and #1682, which GitHub links to issues, and #1679, whose description
references #1676, and flag #1675, #1516, #1510, and #1509, as reading
their descriptions confirms. A 64 KiB description renders in about a
second, and its text reads in at most 60 ms.

test_issue_link.py covers the reading of GitHub's HTML, as gh api
markdown renders it: keywords and targets, other repositories, code and
<pre>, attributes, links, the ends of blocks and table cells, and inline
elements; the verdicts and the writes through a fake gh api, the render
request, gh's input and output in UTF-8, the bound on lookups, an API
error at each read, a comment that quotes the marker or has no author,
and the workflow's triggers, permissions, checkout, concurrency, and
inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py, reads
the pull request through gh api, in UTF-8 whatever the locale, and
passes it when GitHub links it to an issue of the repository
(closingIssuesReferences) or when its description holds close, fix,
resolve (in any form), Part of, or Refs, with an optional colon,
then #N, microsoft/nvx#N, or the issue's URL, where N is an issue. A
pull request's number, a missing number, a bare #N, and another
repository's issue do not count. The script reads the description as
GitHub renders it, through the Markdown API in the repository's context,
and only the text that GitHub shows counts: not an HTML comment, an
attribute such as a link's title, or code, inline, fenced, indented, or
in <pre>, nor a keyword that code or the end of a block, such as a list
item or a table cell, separates from its number. A link counts by where
it goes, and of its text only a keyword that starts it: a link to an
issue or a pull request, absolute or root-relative, with nothing after
the number other than a slash, a query, or a fragment, as that keyword
and OWNER/REPO#N, and any other link as code does. GitHub's own renderer
keeps the check in step with what the pull request's page shows, which a
parser of CommonMark, GFM tables, and raw HTML written here kept
missing. It looks up at most the first 10 numbers, so a description
cannot make it call the API without bound. Pull requests by
dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1687, #1686,
and #1682, which GitHub links to issues, and #1679, whose description
references #1676, and flag #1675, #1516, #1510, and #1509, as reading
their descriptions confirms. A 64 KiB description renders in about a
second, and its text reads in at most 60 ms.

test_issue_link.py covers the reading of GitHub's HTML, as gh api
markdown renders it: keywords and targets, other repositories, code and
<pre>, attributes, links, the ends of blocks and table cells, and inline
elements; the verdicts and the writes through a fake gh api, the render
request, gh's input and output in UTF-8, the bound on lookups, an API
error at each read, a comment that quotes the marker or has no author,
and the workflow's triggers, permissions, checkout, concurrency, and
inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py, reads
the pull request through gh api, in UTF-8 whatever the locale, and
passes it when GitHub links it to an issue of the repository
(closingIssuesReferences) or when its description holds close, fix,
resolve (in any form), Part of, or Refs, with an optional colon,
then #N, microsoft/nvx#N, or the issue's URL, where N is an issue. A
pull request's number, a missing number, a bare #N, and another
repository's issue do not count. The script reads the description as
GitHub renders it, through the Markdown API in the repository's context,
and only the text that GitHub shows counts: not an HTML comment, an
attribute such as a link's title, or code, inline, fenced, indented, or
in <pre>, nor a keyword that code or the end of a block, such as a list
item or a table cell, separates from its number. A link counts by where
it goes, and of its text only a keyword that starts it: a link to an
issue or a pull request, absolute or root-relative, with nothing after
the number other than a slash, a query, or a fragment, as that keyword
and OWNER/REPO#N, which no text after the link extends, and any other
link as code does. An issue's URL that GitHub shows as text follows the
same rule, but for the punctuation that ends a sentence. GitHub's own
renderer keeps the check in step with what the pull request's page
shows, which a parser of CommonMark, GFM tables, and raw HTML written
here kept missing. It looks up at most the first 10 numbers, so a
description cannot make it call the API without bound. Pull requests by
dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1687, #1686,
and #1682, which GitHub links to issues, and #1679, whose description
references #1676, and flag #1675, #1516, #1510, and #1509, as reading
their descriptions confirms. A 64 KiB description renders in about a
second, and its text reads in at most 60 ms.

test_issue_link.py covers the reading of GitHub's HTML, as gh api
markdown renders it: keywords and targets, other repositories, code and
<pre>, attributes, links, the ends of blocks and table cells, and inline
elements; the verdicts and the writes through a fake gh api, the render
request, gh's input and output in UTF-8, the bound on lookups, an API
error at each read, a comment that quotes the marker or has no author,
and the workflow's triggers, permissions, checkout, concurrency, and
inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna) added a commit that referenced this pull request Nov 17, 2026
doc/contribute.md asks every pull request to reference an issue on the
first line of its description, but nothing checks it: pull requests
such as #1675, whose only references sit in the template's HTML
comment, and #1516, whose Refs #1509 names a pull request, reference
no issue, and a reviewer has to notice.

Add the Issue link workflow, which pull_request_target runs, from the
default branch, when a pull request is opened, reopened, pushed to,
edited, labelled, or unlabelled. Its script, check_issue_link.py, reads
the pull request through gh api, in UTF-8 whatever the locale, and
passes it when GitHub links it to an issue of the repository
(closingIssuesReferences) or when its description holds close, fix,
resolve (in any form), Part of, or Refs, with an optional colon,
then #N, microsoft/nvx#N, or the issue's URL, where N is an issue. A
pull request's number, a missing number, a bare #N, and another
repository's issue do not count. The script reads the description as
GitHub renders it, through the Markdown API in the repository's context,
and only the text that GitHub shows counts: not an HTML comment, an
attribute such as a link's title, or code, inline, fenced, indented, or
in <pre>, nor a keyword that code or the end of a block, such as a list
item or a table cell, separates from its number. A link counts by where
it goes, and of its text only a keyword that starts it: a link to an
issue or a pull request, absolute or root-relative, with nothing after
the number other than a slash, a query, or a fragment, as that keyword
and OWNER/REPO#N, which no text after the link extends, and any other
link as code does. An issue's URL that GitHub shows as text follows the
same rule, but for the punctuation that ends a sentence. GitHub's own
renderer keeps the check in step with what the pull request's page
shows, which a parser of CommonMark, GFM tables, and raw HTML written
here kept missing. It looks up at most the first 10 numbers, so a
description cannot make it call the API without bound. Pull requests by
dependabot[bot] or github-actions[bot], or labelled no-issue, are
exempt, and closed ones are left alone.

An unlinked pull request gets the needs-issue label and one marker
comment that says how to reference an issue, and the check fails;
editing the description reruns it, which then removes the label and
rewrites the comment. Only a comment of github-actions[bot] that starts
with the marker is the script's. The script does every read before its
first write, so an API error fails the check and changes nothing, and
its summary names the verdict and the numbers, never the description.

The job has no condition, since a skipped run would replace the
previous verdict, runs one check a pull request at a time, keeps no
checkout credentials, and gets only the pull request's number. Its
token reads contents and writes pull requests; reading an issue of a
public repository needs no issues permission, so the nightly report
and issue labelling stay the only workflows that write issues.

Evidence: dry runs against the live repository pass #1687, #1686,
and #1682, which GitHub links to issues, and #1679, whose description
references #1676, and flag #1675, #1516, #1510, and #1509, as reading
their descriptions confirms. A 64 KiB description renders in about a
second, and its text reads in at most 60 ms.

test_issue_link.py covers the reading of GitHub's HTML, as gh api
markdown renders it: keywords and targets, other repositories, code and
<pre>, attributes, links, the ends of blocks and table cells, and inline
elements; the verdicts and the writes through a fake gh api, the render
request, gh's input and output in UTF-8, the bound on lookups, an API
error at each read, a comment that quotes the marker or has no author,
and the workflow's triggers, permissions, checkout, concurrency, and
inputs. validate-nvx runs it on Linux and Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-modified Changes existing tests, test data, or test wiring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants