Repository navigation
Description
Problem
Stacked pull requests do not reliably receive the CI checks needed to merge.
There are two gaps: CI only starts for pull requests targeting dev, and
retargeting a pull request to dev does not start CI. Manually dispatching CI
does not supply the missing pull-request checks.
Evidence
Observed on November 2, 2026:
- nvx-rs: move the core modules' tests out of their sources #1195 was stacked on ci: check the test layout and flag changes to existing tests #1188. Its head was
2534729c29f61ff26863b7263ebabad8f23cf382. - CI run 41378921644, attempt 1
ran on that exact head with eventworkflow_dispatch. It succeeded,
including itsRequired status checkjob. - ci: check the test layout and flag changes to existing tests #1188 merged at 14:29:42 UTC. GitHub recorded
automatic_base_change_succeededfor nvx-rs: move the core modules' tests out of their sources #1195 at 14:29:45 UTC, retargeting it
todevwithout changing its head. - No
pull_requestCI run started after the retarget. The PR's check rollup
contained only Copilot Setup Steps, Flag changes to existing tests, and
license/cla.gh pr checks 1195 --repo microsoft/nvx --requiredreported
no required checks.
The CI trigger at the merged revision
filters pull requests to base dev and listens only for opened,
synchronize, reopened, and ready_for_review, not edited.
Separately, GitHub documents that workflow_dispatch job checks are not
evaluated for pull requests.
Even a successful run on the exact head neither appears in the PR's checks
section nor satisfies its required status check. This is not a failing test
or a superseded/cancelled CI run.
Proposed scope
- Start genuine
pull_requestCI for stacked layers before their parent
merges, rather than restricting PR CI to basedev. - Handle base-changing
editedevents, including automatic retargeting after
a parent merges, so CI validates the new base/head combination. - Ignore title/body-only edits without cancelling active CI or replacing a
genuine required-check result with a skipped or successful placeholder.
Account for both concurrency and the required-check aggregator; adding an
editedtrigger and skipping individual jobs is not sufficient. - Preserve draft and fork protections, the existing restrictions on
self-hosted execution,devpush and merge-queue behavior, and release and
performance-history publication restrictions. Do not execute PR code in a
privilegedpull_request_targetworkflow as a workaround. - Document stacked-PR behavior and the distinction between manual full-run
validation and PR-eligible checks.
Acceptance criteria
- A ready stacked PR targeting another topic branch automatically receives
genuine CI checks that GitHub evaluates for that PR. - Retargeting it to
dev, manually or automatically after its parent
merges, starts qualifying CI without requiring a new commit or close/reopen. -
Required status checkaccurately reflects the selected jobs for the
relevant revision; failed jobs cannot be hidden by an irrelevant edit. - Title/body-only edits neither cancel valid runs nor supersede their
required-check result with a skipped/successful no-op. - Regression coverage exercises stacked bases, base-changing edits,
metadata-only edits, ordinary PR events, and the affected concurrency and
required-check behavior. - Existing draft/fork safeguards and non-PR CI behavior remain intact,
and the CI documentation describes the new behavior. - Validate the reporting end to end on a real stacked PR and its retarget,
including GitHub's PR check rollup and required-check view, not only the
workflow run's overall conclusion.
Temporary workaround
After a stacked PR targets dev, closing and reopening it triggers a
qualifying pull_request run under the current configuration. Rerunning or
dispatching manual CI does not repair the missing PR status. No workaround
was applied to #1195 during this investigation.
Activity
scratch: check a classic stacked pull request
ppenna commentedon Nov 3, 2026
Closing as resolved by #1208. We intentionally excluded the
editedtrigger: stacked pull requests now receive genuine CI checks for their topic branch, and when GitHub retargets a PR todevwithout changing its head, the existingRequired status checkremains attached to that commit. This was verified end to end on scratch PR #1227, including the required-check view after retargeting. Starting a fresh run on retarget and addingedited-handling regression coverage remain intentionally out of scope.