Repository navigation
Open
OpenVMM/microVM umbrella: snapshot publication, the manifest, block identity, and restore claims#1180
Task
11 / 1211 of 12 issues completed
Copy link
Labels
area: openvmmInitial title-keyword triage suggestionInitial title-keyword triage suggestionarea: snapshotInitial title-keyword triage suggestionInitial title-keyword triage suggestion
Description
Objective. A snapshot is restorable exactly when its publication committed; its manifest's format and admitted command line are those that NVX and upstream OpenVMM agree on; restore refuses a malformed manifest, artifact, or RAM range with an error, not a panic, before it claims a resume snapshot; and sandbox blocks are identified only by their storage generation, as the architecture guide describes.
Children.
| Issue | Scope | Blocked by |
|---|---|---|
| #557 | Identify snapshot blocks only by storage generation, and stop hashing block artifacts. | — |
| #1144 | Unlinking the source's RAM file changes the inode's ctime, which invalidates an already-opened snapshot. | — |
| #1153 | A failed cleanup after a failed publication can leave a restorable snapshot while the source resumes. | — |
| #1362 | Outside Linux glibc builds, so in NVX's MSHV (musl) and WHP builds, publication's final rename replaces an empty destination directory that another process created. | — |
| #1210 | Align the manifest's tags with upstream SaveVM/RestoreVM (microsoft/openvmm#4553): give tag 8 to upstream's snapshot_id, move state_size_bytes, bump the version, and refuse v6 manifests with a recapture diagnostic. |
— |
| #995 | Admit a closed set of guest kernel tuning parameters, such as mitigations=off, on a platform snapshot's command line at publication and restore, then let an adapter's templates boot with them. |
— |
| #1361 | Opening a snapshot whose paired scratch has an unknown restore_mode panics instead of refusing it. |
— |
| #1364 | The memory-expansion range math overflows near the top of the GPA space, so a crafted manifest panics a debug build. | — |
| #1373 | The VM worker accepts decoded snapshot or restore RAM ranges that are unaligned or reversed, and load can then panic merging them. | — |
| #1154 | A writerless FIFO in place of a snapshot artifact hangs restore before validation. | — |
| #1157 | A nonregular paired scratch.img passes opening, so preparation can consume the resume claim before it fails. |
#1154 |
| #565 | Claim a resume snapshot before linking its direct-claimed scratch. | #1157 |
Order. #1154, then #1157, then #565:
- openvmm: nonregular paired scratch is accepted before a resume generation can be consumed #1157 is blocked by openvmm: a writerless FIFO snapshot artifact hangs restore before validation #1154: openvmm: nonregular paired scratch is accepted before a resume generation can be consumed #1157 checks the paired scratch's type before the claim, and a FIFO blocks that check's open until openvmm: a writerless FIFO snapshot artifact hangs restore before validation #1154 opens artifacts with
O_NONBLOCK. - microVM: claim a resume snapshot before linking its direct-claimed scratch #565 is blocked by openvmm: nonregular paired scratch is accepted before a resume generation can be consumed #1157: once the claim comes before the direct-claimed link, a nonregular
scratch.imgwould consume the claim before the link fails, unless openvmm: nonregular paired scratch is accepted before a resume generation can be consumed #1157's check runs first.
No other child blocks another. Outside this umbrella, #760 (the management RPC) is blocked by #557.
Notes.
- microVM: identify snapshot blocks only by storage generation; stop hashing block artifacts #557 and microVM: claim a resume snapshot before linking its direct-claimed scratch #565 both change how restore materializes paired scratch (
prepare_restoreand the paired-scratch materializers); land them one after the other. - openvmm: failed publication cleanup can leave a restorable snapshot while the source resumes #1153 and openvmm: snapshot publication can replace an empty directory on musl and Windows #1362 both concern publication's final rename in
StagingDirectory(openvmm/openvmm_helpers/src/snapshot/publish.rs): openvmm: failed publication cleanup can leave a restorable snapshot while the source resumes #1153 the cleanup after it fails, and openvmm: snapshot publication can replace an empty directory on musl and Windows #1362 its no-replace guarantee. - snapshot: align NVX manifest with upstream SaveVM/RestoreVM #1210 changes the manifest's layout and version, so existing snapshots need recapture; land other changes that invalidate snapshots with it, so that they need recapture once.
- openvmm: an unaligned or reversed decoded snapshot RAM range panics microVM load #1373 and openvmm: a microVM network prefix of 0 or over 32 panics config validation #1372 (in OpenVMM/microVM umbrella: network egress, ingress, and identity #1392) both add checks to
validate_machine_config(openvmm/openvmm_defs/src/microvm.rs); land them one at a time.
Metadata
Metadata
Assignees
Labels
area: openvmmInitial title-keyword triage suggestionInitial title-keyword triage suggestionarea: snapshotInitial title-keyword triage suggestionInitial title-keyword triage suggestion
Activity
[-]OpenVMM/microVM umbrella: snapshot publication, block identity, and restore claims[/-][+]OpenVMM/microVM umbrella: snapshot publication, the manifest, block identity, and restore claims[/+]