Skip to content

nvx-rs: artifacts.json pins a release from before time ABI 2, so bundled builds and the nightly Package nvx crate fail #1173

Closed

Description

Summary

The nightly full run of dev at 4f9a3214f failed in Package nvx crate: the build of the packed nvx crate with every feature panicked in its build script, because the release that nvx-rs/artifacts.json pins, v0.1.0-dev.9ceb89fcc31f, declares neither a time ABI version nor a restore-packet version in its SOURCE-MANIFEST.json. #1018 raised the crate's time ABI to 2 and its restore packet to 5, and made the build script require a release to declare both, but artifacts.json still pins the release of October 4, which predates them.

Every bundled build of dev that downloads the pinned release fails the same way, so crates.io gets no new version of nvx, and the nightly stays red, until a pull request repins a compatible release, as The nvx crate says. The OpenVMM pin plays no part: the job checks out no submodule, and #1133, which pins microVM v3.0, changes no contract.

Incident

  • Workflow: CI run 41276515539, attempt 1, schedule on dev, at 4f9a3214f09b1474311ad1bdc957014828f7f03b, the merge of openvmm: pin microVM v2.4, rebased onto upstream main #1075. Nightly failure report: ci: the nightly full run is failing #1134.

  • Failed job: Package nvx crate, step Package, check, and build the nvx crate, on ubuntu-latest with Rust 1.95.0. Since nvx-rs/ changed after 23ad267292b4, from which 0.1.0-alpha.8 was packed, the job packed 0.1.0-alpha.9, and then built it with every feature, bundling the KVM release:

    warning: nvx@0.1.0-alpha.9: nvx: downloading https://github.com/microsoft/nvx/releases/download/v0.1.0-dev.9ceb89fcc31f/nvx-0.1.0-linux-kvm.tar.gz
    thread 'main' (3117) panicked at build.rs:354:9:
    nvx bundled artifacts: .../nvx-0.1.0-linux-kvm/SOURCE-MANIFEST.json does not declare the compatible OpenVMM contracts (time_abi_version: expected 2, found none; restore_packet_version: expected 5, found none)
    
  • Downstream: Publish nvx crate was skipped. The run's other 35 jobs passed, and the rest of its skipped jobs run only for pushes, pull requests or merge groups.

  • Not superseded: this is the newest full run, and dev has since taken only two [skip ci] commits, which leave nvx-rs/ unchanged, so the next nightly fails the same way.

History

Root cause

The pinned release's SOURCE-MANIFEST.json declares these contract versions, and no others:

{"microvm_abi_version": 2, "control_session_protocol_version": 1, "control_contract_revision": "nvx-microvm-v2-control-v2"}

At 4f9a3214f, contract::manifest_mismatches also requires time_abi_version 2 and restore_packet_version 5, so stage() in nvx-rs/build.rs refuses the release. No pull request job builds bundled against the pin: the --all-features builds of check-nvx-rs set NVX_BUNDLE=skip, and its bundling test stages a synthetic release from the commit's own SOURCE-MANIFEST.json. Only the nightly Package nvx crate job downloads the pinned release, so a contract change that merges without a repin fails there first.

Reproduction

On Windows, with Rust 1.95.0:

  • The SOURCE-MANIFEST.json of each package, read from the release assets themselves: the pinned release's linux-kvm and windows-whp packages lack both fields, while v0.1.0-dev.10b405b29f0a and v0.1.0-dev.4f9a3214f09b declare all five values that the crate expects.
  • The build script of 4f9a3214f, run by cargo check --locked --features bundled with NVX_BUNDLE_DIR naming the pinned release's SOURCE-MANIFEST.json and SHA256SUMS, panics at build.rs:354:9 with the same two mismatches. With those of v0.1.0-dev.4f9a3214f09b, it passes the contract check.

Fix

Repin nvx-rs/artifacts.json to v0.1.0-dev.4f9a3214f09b, the release of the nightly's own commit. Its OpenVMM is dev's pin, and its SOURCE-MANIFEST.json declares every contract version of nvx::contract. The GitHub release API gives these digests:

Package SHA-256
linux-kvm 928aaf6f46c9b90346f45953268260d868fd52b49c0d58d9ce16ac897aba280c
linux-mshv a66fc9b6ba1579a5e9935af2d27e3b47b25a5f0f200315f0a4f2ff34bbfa327d
windows-whp 2690b089f07ceab05b0ed221db65be3132262eef34349d9630f68388fc5c9a53

Then dispatch CI on dev, or wait for the next nightly, so that Package nvx crate and Publish nvx crate publish 0.1.0-alpha.9, and a passing nightly closes #1134.

Activity

  1. added a commit that references this issue on Nov 4, 2026
    c4acffb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions