Skip to content

fix(windows): hide the console window forked by the console-list agent #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aikio (Aikiooo) wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix(windows): hide the console window forked by the console-list agent #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/windowsPtyAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import * as fs from 'fs';
import * as path from 'path';
import { fork } from 'child_process';
import { fork, ForkOptions } from 'child_process';
import { Socket } from 'net';
import { ArgvOrCommandLine } from './types';
import { ConoutConnection, IConoutConnection } from './windowsConoutConnection';
Expand Down Expand Up @@ -228,7 +228,11 @@ export class WindowsPtyAgent {
return Promise.resolve([]);
}
return new Promise<number[]>(resolve => {
const agent = fork(path.join(__dirname, 'conpty_console_list_agent'), [ this._innerPid.toString() ]);
// The helper needs a console (AttachConsole) but no window: without
// windowsHide, killing a pty flashes a console window on screen.
// Cast: @types/node's ForkOptions omits windowsHide.
const forkOptions = { windowsHide: true } as ForkOptions;
const agent = fork(path.join(__dirname, 'conpty_console_list_agent'), [ this._innerPid.toString() ], forkOptions);
agent.on('message', message => {
clearTimeout(timeout);
resolve(message.consoleProcessList);
Expand Down