[REBASE & FF] Revert Mu Commits in Favor of edk2 Commits#1810
Merged
Conversation
This reverts commit 1800e61 as it has been upstreamed to edk2.
Currently, MmCommunicationDxe expects the MM comm buffer to either be not added by the platform or added and allocated by the platform. However, not all platforms follow this pattern. This commit makes the handling more generic by checking to see if a GCD descriptor exists that covers this range. If it does, the capabilities are updated as needed. If only a partial desc exists for this range, the driver will fail as that is a platform misconfiguration. If the descriptor does not exist, the driver will add the buffer. Then, for all successful cases, the attributes are updated on the buffer to what the driver expects them to be. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com> (cherry picked from commit 4f80e9c52841589144fd12e6f4d9d46638bce8d1)
…for VA_LIST MSVC AARCH64 and CLANGPDB AARCH64 currently use the MS ABI for variadics in edk2. However, this breaks the AAPCS64 ABI and interopability with GCC/CLANGDWARF built binaries. Because the architecture defines the single ABI, MSVC AARCH64 has little usage, and CLANGPDB AARCH64 is new to edk2, coerce these toolchains to use the AAPCS64 ABI instead of the MS ABI. This allows interopability between all supported AARCH64 toolchains in edk2 for variadics. Note that variadic functions themselves are unaffected by this change, e.g. functions that take ... as the last parameter. This affects the VA_LIST structure and the associated helpers to parse it. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny <osde@microsoft.com> (cherry picked from commit 5608ef608767a401926881a352e1bf88ade56379)
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/26644389778 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Javagedes
approved these changes
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1810 +/- ##
=================================================
Coverage ? 2.21%
=================================================
Files ? 1634
Lines ? 420137
Branches ? 4949
=================================================
Hits ? 9308
Misses ? 410754
Partials ? 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts the Mu version of the MmCommunicationDxe Comm Buffer Init fix and cherry-picks the edk2 version as well as cherry-picking the VA_LIST ABI change.
How This Was Tested
N/A.
Integration Instructions
N/A.