fix: only use base_uri from http client - #481
Merged
Merged
Conversation
Member
|
depends on #483 to be merged first |
|
Vincent Biret (baywet)
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates logic for initializing kiota httpx request adapter to only use the base_uri from the http client. This aligns with the behavior in the other kiota http request adapters.
This leaves a dangling unused parameter, however removing it would be a breaking change so we're better to leave it for now.
Related Issue
Contributes to fixing: microsoftgraph/msgraph-beta-sdk-python#743
Testing Instructions