IParseNode.GetCollectionOf* methods can now return null - #174
Draft
Felix (Irame) wants to merge 2 commits into
Draft
IParseNode.GetCollectionOf* methods can now return null#174Felix (Irame) wants to merge 2 commits into
Felix (Irame) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Felix (Irame)
changed the title
Felix (Irame)
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
Contributor
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
Vincent Biret (baywet)
added
the
status:waiting-for-author-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the return type of
GetCollectionOfPrimitiveValues,GetCollectionOfEnumValuesandGetCollectionOfObjectValuesinIParseNodenullable to allow for null when the underlying type is not an collection type.This change is part of the solution for the problem discussed here microsoft/kiota#3976.