[shimV2] bind GCS/host hvsock listeners before starting the UVM#2723
Open
rawahars wants to merge 2 commits intomicrosoft:mainfrom
Open
[shimV2] bind GCS/host hvsock listeners before starting the UVM#2723rawahars wants to merge 2 commits intomicrosoft:mainfrom
rawahars wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
rawahars
commented
May 6, 2026
rawahars
commented
- Split guestmanager.Guest.CreateConnection into PrepareConnection (binds the GCS hvsock listener) + CreateConnection (accepts and runs the handshake) so the host is listening before the guest dials.
- Controller.StartVM now calls PrepareConnection and the entropy/logging listener setup before uvm.Start, and propagates their errors.
- LCOW/WCOW setupEntropyListener/setupLoggingListener now bind the hvsock listener synchronously and only Accept inside the goroutine; return error instead of swallowing/logging it.
- CloseConnection also closes a prepared-but-unaccepted listener.
- vmmanager.AcceptConnection: buffer the result channel to avoid a goroutine leak and close the listener on context cancellation.
- Split guestmanager.Guest.CreateConnection into PrepareConnection (binds the GCS hvsock listener) + CreateConnection (accepts and runs the handshake) so the host is listening before the guest dials. - Controller.StartVM now calls PrepareConnection and the entropy/logging listener setup before uvm.Start, and propagates their errors. - LCOW/WCOW setupEntropyListener/setupLoggingListener now bind the hvsock listener synchronously and only Accept inside the goroutine; return error instead of swallowing/logging it. - CloseConnection also closes a prepared-but-unaccepted listener. - vmmanager.AcceptConnection: buffer the result channel to avoid a goroutine leak and close the listener on context cancellation. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.