fix possible nil pointer dereference in providerCallback#360
Open
EvanDorsky wants to merge 1 commit into
Open
Conversation
Signed-off-by: Evan Dorsky <evan.dorsky@icloud.com>
EvanDorsky
force-pushed
the
provider-callback-nilcheck
branch
from
July 8, 2026 18:38
d98b815 to
c11364d
Compare
Author
|
I agree with the Contributor License Agreement on behalf of my employer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to hit a nil pointer dereference in
providerCallbackif a notification fires aftergo-winiohas already stopped tracking the provider -providerwill come backnilfromproviders.getProviderand then any access in theswitch(likeprovider.enabled = false) will panic.Seemed simple to fix by just wrapping the entire callback in a
nilcheck, I hope this is helpful!