fix linting issues#325
Conversation
thaJeztah
commented
Jan 10, 2025
thaJeztah
commented
- relates to Fix deadlock when closing pipe #324 (comment)
|
cc @kevpar if you have permissions to kick CI ❤️ |
|
@thaJeztah It looks like the CI is still failing |
|
Yeah, I noticed; I suspect the other failures may also be with newer go versions, or updated golangci-lint. I think they're all about integer conversion in generated code; haven't checked if they can be ignored (temporarily) or need fixing; |
|
I opened a separate PR to fix the «Go Generate» failure: #326 |
|
@mat007 @thaJeztah looks like the CIs are still failing |
|
Maybe these should be pinned versions? 🤷 go-winio/.github/workflows/ci.yml Lines 7 to 9 in bdc6c11 |
|
There are 104 linting errors remaining, all due to conversions. I’ve looked at a few and they all seem to be similar, for instance Line 165 in bdc6c11 What would be best here? To «nolint» them all? |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It currently produces too many (false) positives in generated code, which
needs to be reviewed. For the time being, exclude this check.
::high file=wim/lzx/lzx.go,line=137,col=13::G115: integer overflow conversion uint32 -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=191,col=26::G115: integer overflow conversion uint -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=200,col=38::G115: integer overflow conversion int -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=376,col=20::G115: integer overflow conversion uint32 -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=377,col=20::G115: integer overflow conversion uint32 -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=378,col=20::G115: integer overflow conversion uint32 -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=526,col=51::G115: integer overflow conversion int -> uint16 (gosec)
::high file=wim/lzx/lzx.go,line=546,col=23::G115: integer overflow conversion int64 -> int32 (gosec)
::high file=wim/lzx/lzx.go,line=547,col=16::G115: integer overflow conversion uint32 -> int32 (gosec)
::high file=wim/lzx/lzx.go,line=555,col=53::G115: integer overflow conversion int32 -> uint32 (gosec)
::high file=wim/lzx/lzx.go,line=567,col=32::G115: integer overflow conversion int -> uint16 (gosec)
::high file=internal/stringbuffer/wstring.go,line=131,col=47::G115: integer overflow conversion int -> uint32 (gosec)
::high file=pkg/bindfilter/bind_filter.go,line=231,col=66::G115: integer overflow conversion int -> uint32 (gosec)
::high file=pkg/bindfilter/bind_filter.go,line=241,col=16::G115: integer overflow conversion int -> uint32 (gosec)
::high file=pkg/process/process.go,line=19,col=23::G115: integer overflow conversion int -> uint32 (gosec)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| gosec: | ||
| excludes: | ||
| - G115 # G115: integer overflow conversion; TODO: currently too many (false) positives in generated code that need to be verified |
There was a problem hiding this comment.
I added a global ignore for this one for now; I think most of these are likely false positives in generated code, but would have to be reviewed by someone with more understanding of those parts of the code.
|
Pushed some changes, but I don't have a windows machine to verify on locally, but if someone could kick CI again ❤️ @kiashok @katiewasnothere |
| if err != nil { | ||
| u.T.Helper() | ||
| u.T.Fatalf(msgJoin(msgs, "%v"), err) | ||
| u.T.Fatalf(msgJoin(msgs, err.Error())) |
There was a problem hiding this comment.
This should be Fatal, not Fatalf, to stay consistent with the Must fix below, any % in the error message would be misinterpreted as a format verb
| } | ||
| case <-t.C: | ||
| u.T.Helper() | ||
| u.T.Fatalf(msgJoin(msgs, "timed out after %v"), d) |
There was a problem hiding this comment.
Looks like this timeout case was missed — it still uses the old Fatalf pattern while the identical case in Wait was fixed.
|
This PR has outstanding merge conflicts , can you pls check these @thaJeztah |
7 participants
