Support separate client and peer cluster endpoints - #2108
Draft
Mathieu Tremblay (Mathos1432) wants to merge 2 commits into
Draft
Support separate client and peer cluster endpoints#2108Mathieu Tremblay (Mathos1432) wants to merge 2 commits into
Mathieu Tremblay (Mathos1432) wants to merge 2 commits into
Conversation
Support per-node port translation without changing peer traffic or the required cluster configuration prefix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 344fb382-6217-4cdf-ad7e-7889d571811e
Align declarations, validation, tests, comments, and documentation with surrounding upstream style without changing endpoint behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 344fb382-6217-4cdf-ad7e-7889d571811e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support per-node client port translation while retaining direct peer endpoints. Adds optional client IP address, port, and hostname settings for
CLUSTER NODES,CLUSTER SLOTS,CLUSTER SHARDS,MOVED, andASK.Peer gossip, replication, migration, and failover keep using internal endpoints. Unset options preserve existing behavior. Client metadata uses an optional extension after the unchanged version 1 configuration prefix. Upgrade all nodes before relying on translated endpoints; older nodes ignore the extension and advertise peer endpoints.
Fixes #2107.
Validation
dotnet build Garnet.slnx -c Debug: passed for both target frameworks, no warnings.dotnet format Garnet.slnx --no-restore --verify-no-changes: passed.net10.0suites: Garnet.test 1,073 passed and 3 skipped; Garnet.test.cluster 175 passed; Garnet.test.cluster.replication 107 passed; Garnet.test.cluster.migrate 56 passed.Assisted-By: GitHub Copilot