Fix Helm chart version synchronization - #2088
Conversation
|
@microsoft-github-policy-service agree company="Archipelago AI" |
1 similar comment
|
@microsoft-github-policy-service agree company="Archipelago AI" |
There was a problem hiding this comment.
Pull request overview
Synchronizes Helm chart metadata with Garnet’s canonical release version and broadens OCI publishing triggers.
Changes:
- Aligns chart
versionandappVersionwithVersion.props. - Validates version consistency before packaging.
- Triggers publishing for all chart and version changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
charts/garnet/Chart.yaml |
Updates chart metadata to version 2.1.5. |
.github/workflows/helm-chart.yml |
Expands triggers and adds version validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
babykart (@babykart) - could you review this PR? Thank you. |
|
I see at least one major issue with this MR:
Ideally—and I was the first to overlook this—whenever the Helm chart is modified, the If we want to automate the Helm chart publishing process, we need to consider two scenarios:
|
|
Very well, I decoupled them again. Chart/app changes will trigger patch updates. If you want major/minor changes you can do it manually. You can see the results of merging https://github.com/esafak/garnet/pkgs/container/helm-charts%2Fgarnet and https://github.com/esafak/garnet |
Why?
The Helm chart and Garnet application have independent release lifecycles, but the chart metadata was coupled to the application version. Upstream releases also left the published chart and checked-in README metadata stale because chart version changes were not part of the application release process.
This PR will...
versionindependent from GarnetappVersion(0.2.3and2.1.5respectively).charts/garnet/README.md.appVersionsynchronized withVersion.props.helm-docs-genbranch.Version.propschanges; the bot increments the chart patch version, updatesappVersion, and regenerates the README before publication.The release bot performs patch bumps only. Maintainers can choose chart minor or major versions manually when chart compatibility changes require it.
Testing
actionlint .github/workflows/helm-chart.yml .github/workflows/helm-chart-check.yml .github/workflows/helm-chart-release-sync.ymlgit diff --checkhelm lint charts/garnethelm template garnet charts/garnethelm template garnet charts/garnet --set image.tag=1.0.65helm package charts/garnethelm-docs1.14.2 regeneration and README consistency check