Add ICompactionFunctions.OnImplicitlyDeleted#1956
Closed
kevin-montrose wants to merge 3 commits into
Closed
Conversation
…-_-); add OnImplicitlyDeleted to ICompactionFunctions
… this correct, needs consultation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also threads
ICompactionFunctionsthrough Garnet (asGarnetRecordTriggers).Changes
TsavoriteCompaction.csto make the callbacks where I think we'd want them.This removes pending operations from compaction to keep this easier to reason about, that will have to be restored before merging.
This is subtle enough that, while it compiles, I'm far from certain it's logically correct.
Pushing up for consultation, do not merge.