Add tests (and fix bugs) for commands WRONGTYPE'ing appropriately against Vector Sets

[kevin-montrose]

Most commands, when used on Vector Sets, should WRONGTYPE. Similarly, Vector Set commands when used on non-Vector Set keys should WRONGTYPE

We have a bunch of commands, and we've been pretty laxidasical about checking GarnetStatus so this is a pretty big PR, though mostly mechanical.

Changes:

• Add tests for all Vector Set commands operating on non-Vector Set types
• Implement VCARD
• Implement VISMEMBER
• Sketch out VLINKS, VRANDMEMBER, and VSETATTR - far enough to WRONGTYPE, but not fully implemented
• Add tests for (most) non-Vector Set commands on Vector Set keys
• Add tests to validate the commands that overwrite Vector Sets (SET, MSET, etc.) correctly free up their resources

---

Overwriting Vector Sets is a more complicated operation - if the value is still in memory, a IPU or CU needs a preceeding delete (because the RecordType is changing); while if the value is on disk the blind upsert is fine, but we need to cleanup the Vector Set at some later point.

My solution is to fail IPU/CU's with a WRONG_TYPE result and then retry in a transaction, and to implement ICompactionFunctions.IsDeleted on GarnetRecordType to cleanup Vector Sets which are unreachable but not explicitly tombstone'd.

This is approach is taken for:

• MSET
• PSETEX
• SET
• SETEX
• SETIFGREATER
• SETIFMATCH
• SETWITHETAG

This impacted one RI test ; I left this commented out with a TODO for review by someone with more RI knowledge.

[Copilot]

Pull request overview

This PR tightens WRONGTYPE behavior across Garnet when operating on Vector Set keys (and vice versa), adds broad test coverage for these expectations, and introduces overwrite/cleanup mechanics to ensure Vector Sets don’t leak resources when overwritten by string commands.

Changes:

• Added comprehensive tests to ensure (1) Vector Set commands WRONGTYPE on non-Vector Set keys, (2) most non-Vector Set commands WRONGTYPE on Vector Set keys, and (3) overwrite commands free Vector Set resources.
• Implemented VCARD and VISMEMBER end-to-end; sketched VLINKS, VRANDMEMBER, and VSETATTR enough to reach WRONGTYPE paths.
• Propagated WRONGTYPE status consistently through storage sessions, RESP handlers, and (where needed) Tsavorite RMW plumbing; added overwrite retry logic (DELETE + SET) for commands that intentionally overwrite Vector Sets.

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/standalone/Garnet.test/TestUtils.cs	Adds server creation knobs (compaction, segment sizing) used by overwrite/eviction tests.
test/standalone/Garnet.test/RespTests.cs	Minor assertion cleanup (IsNull).
test/standalone/Garnet.test.vectorset/VectorSetWrongTypeTests.cs	New broad meta-test suite ensuring WRONGTYPE correctness across key-taking commands.
test/standalone/Garnet.test.vectorset/VectorSetOverwriteTests.cs	New suite validating overwriting Vector Sets triggers cleanup (in-memory and evicted-to-disk scenarios).
test/standalone/Garnet.test.vectorset/RespVectorSetTests.cs	Adds TYPE coverage for Vector Sets (RedisType.VectorSet).
test/standalone/Garnet.test.rangeindex/RespRangeIndexTests.cs	Removes/defers a prior “SET over RI must WRONGTYPE” assumption (now allows overwrite).
test/standalone/Garnet.test.acl/Resp/ACL/RespCommandTests.cs	Updates ACL command checks to match new Vector Set command behaviors/return shapes.
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs	Fixes propagation so WrongType maps to OperationStatus.WRONG_TYPE.
libs/storage/Tsavorite/cs/src/core/Index/StoreFunctions/StoreFunctions.cs	Exposes recordTriggers publicly so it can be passed to compaction.
libs/server/Storage/Session/ObjectStore/SortedSetOps.cs	Preserves WRONGTYPE across multi-key collect operations.
libs/server/Storage/Session/ObjectStore/SortedSetGeoOps.cs	Returns actual status (incl. WRONGTYPE) instead of forcing NOTFOUND.
libs/server/Storage/Session/ObjectStore/SetOps.cs	Early-exits union on WRONGTYPE.
libs/server/Storage/Session/ObjectStore/ListOps.cs	Propagates WRONGTYPE in list move paths.
libs/server/Storage/Session/ObjectStore/HashOps.cs	Preserves WRONGTYPE across multi-key hash collect operations.
libs/server/Storage/Session/ObjectStore/Common.cs	Maps Status.IsWrongType to GarnetStatus.WRONGTYPE.
libs/server/Storage/Session/ObjectStore/AdvancedOps.cs	Ensures RMW wrapper returns WRONGTYPE when Tsavorite reports it.
libs/server/Storage/Session/MainStore/VectorStoreOps.cs	Adds VCARD, VISMEMBER, and stubs for links/randmember/attr; integrates with vector index reads.
libs/server/Storage/Session/MainStore/RangeIndexOps.cs	Returns WRONGTYPE on create failures due to mismatched existing type.
libs/server/Storage/Session/MainStore/MainStoreOps.cs	Propagates WRONGTYPE for string operations (GET/GETEX/GETDEL/etc.) and some multi-key flows (LCS).
libs/server/Storage/Session/MainStore/HyperLogLogOps.cs	Propagates WRONGTYPE for PFCOUNT/PFMERGE input keys.
libs/server/Storage/Session/MainStore/BitmapOps.cs	Returns WRONGTYPE for BITOP inputs; adds delete+retry for BITOP destination overwrite.
libs/server/Storage/Session/MainStore/AdvancedOps.cs	Returns WRONGTYPE for main-store RMW wrapper.
libs/server/Storage/Functions/UnifiedStore/ReadMethods.cs	Extends TYPE to return vectorset for Vector Set record type.
libs/server/Storage/Functions/ObjectStore/RMWMethods.cs	Adjusts WrongType paths in IPU/CU to ensure WrongType propagates correctly.
libs/server/Storage/Functions/MainStore/RMWMethods.Etags.cs	Ensures etag copy-update returns WRONGTYPE for non-string record types.
libs/server/Storage/Functions/MainStore/RMWMethods.cs	WRONGTYPEs non-legal updates on Vector Set records (command legality gate).
libs/server/Storage/Functions/MainStore/ReadMethods.cs	Ensures MGET reader path copies raw bytes (enables “return null for non-string key” behavior).
libs/server/Storage/Functions/GarnetRecordTriggers.cs	Adds ICompactionFunctions implementation intended to drive Vector Set cleanup during compaction.
libs/server/Resp/Vector/VectorManager.cs	Adds IsMember helper for VISMEMBER implementation.
libs/server/Resp/Vector/VectorManager.ContextMetadata.cs	Adds test helper GetContextState for cleanup assertions.
libs/server/Resp/Vector/RespServerSessionVectors.cs	Implements network handlers for VCARD, VISMEMBER, and stubs for VLINKS, VRANDMEMBER, VSETATTR.
libs/server/Resp/RangeIndex/RespServerSessionRangeIndex.cs	Correctly emits WRONGTYPE error instead of flushing with no response.
libs/server/Resp/MGetReadArgBatch.cs	Simplifies/clarifies MGET input initialization.
libs/server/Resp/KeyAdminCommands.cs	Treats WRONGTYPE in DUMP as “null” (non-string) and adds WRONGTYPE error for GETDEL.
libs/server/Resp/HyperLogLog/HyperLogLogCommands.cs	Returns WRONGTYPE errors when storage reports WRONGTYPE (not just 0xFF sentinel).
libs/server/Resp/CmdStrings.cs	Adds vectorsett for TYPE output.
libs/server/Resp/Bitmap/BitmapCommands.cs	Adds WRONGTYPE handling for bitmap ops; refactors BITFIELD* to lock key in txn for multi-subcommands and handle WRONGTYPE correctly.
libs/server/Resp/BasicEtagCommands.cs	Adds WRONGTYPE responses for etag GETs; adds overwrite retry (DELETE + SET) on WRONGTYPE for SET-with-etag paths.
libs/server/Resp/BasicCommands.cs	Adds WRONGTYPE responses for more string commands; adds overwrite retry logic for SET/SETEX/conditional SET variants.
libs/server/Resp/ArrayCommands.cs	Adds overwrite retry logic for MSET; adds WRONGTYPE handling for LCS.
libs/server/Resp/AdminCommands.cs	Adds WRONGTYPE responses for HCOLLECT/ZCOLLECT.
libs/server/Objects/ItemBroker/CollectionItemBroker.cs	Treats WRONGTYPE as type mismatch for item broker flows.
libs/server/Databases/DatabaseManagerBase.cs	Passes compaction functions (recordTriggers) into Tsavorite Log compaction.
libs/server/API/IGarnetApi.cs	Adds Vector Set APIs: VCARD, VISMEMBER, VLINKS, VRANDMEMBER, VSETATTR.
libs/server/API/GarnetWatchApi.cs	Wires WATCH instrumentation for new Vector Set APIs.
libs/server/API/GarnetApi.cs	Wires new Vector Set APIs to StorageSession; fixes IncrementByFloat return status propagation.

[Copilot]

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 5 comments.