Skip to content

docs(react-examples): fix GroupedList example a11y #36489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AK (AKnassa) wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

docs(react-examples): fix GroupedList example a11y #36489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions packages/react-examples/src/react/GroupedList/GroupedList.Custom.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,25 @@ const onRenderHeader = (props?: IGroupHeaderProps): JSXElement | null => {
props.onToggleCollapse!(props.group!);
};
return (
<div className={classNames.header}>
This is a custom header for {props.group!.name}
&nbsp; (
<Link
// eslint-disable-next-line react/jsx-no-bind
onClick={toggleCollapse}
>
{props.group!.isCollapsed ? 'Expand' : 'Collapse'}
</Link>
)
<div
className={classNames.header}
role="row"
aria-level={props.ariaLevel}
aria-setsize={props.ariaSetSize}
aria-posinset={props.ariaPosInSet}
aria-expanded={!props.group!.isCollapsed}
>
<div role="gridcell">
This is a custom header for {props.group!.name}
&nbsp; (
<Link
// eslint-disable-next-line react/jsx-no-bind
onClick={toggleCollapse}
>
{props.group!.isCollapsed ? 'Expand' : 'Collapse'}
</Link>
)
</div>
</div>
);
}
Expand All @@ -64,7 +73,11 @@ const onRenderCell = (nestingDepth?: number, item?: IExampleItem, itemIndex?: nu
};

const onRenderFooter = (props?: IGroupFooterProps): JSXElement | null => {
return props ? <div className={classNames.footer}>This is a custom footer for {props.group!.name}</div> : null;
return props ? (
<div className={classNames.footer} role="row">
<div role="gridcell">This is a custom footer for {props.group!.name}</div>
</div>
) : null;
};

const groupedListProps = {
Expand Down
35 changes: 24 additions & 11 deletions packages/react-examples/src/react/GroupedList/GroupedListV2.Custom.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,25 @@ const onRenderHeader = (props?: IGroupHeaderProps): JSXElement | null => {
props.onToggleCollapse!(props.group!);
};
return (
<div className={classNames.header}>
This is a custom header for {props.group!.name}
&nbsp; (
<Link
// eslint-disable-next-line react/jsx-no-bind
onClick={toggleCollapse}
>
{props.group!.isCollapsed ? 'Expand' : 'Collapse'}
</Link>
)
<div
className={classNames.header}
role="row"
aria-level={props.ariaLevel}
aria-setsize={props.ariaSetSize}
aria-posinset={props.ariaPosInSet}
aria-expanded={!props.group!.isCollapsed}
>
<div role="gridcell">
This is a custom header for {props.group!.name}
&nbsp; (
<Link
// eslint-disable-next-line react/jsx-no-bind
onClick={toggleCollapse}
>
{props.group!.isCollapsed ? 'Expand' : 'Collapse'}
</Link>
)
</div>
</div>
);
}
Expand All @@ -65,7 +74,11 @@ const onRenderCell = (nestingDepth?: number, item?: IExampleItem, itemIndex?: nu
};

const onRenderFooter = (props?: IGroupFooterProps): JSXElement | null => {
return props ? <div className={classNames.footer}>This is a custom footer for {props.group!.name}</div> : null;
return props ? (
<div className={classNames.footer} role="row">
<div role="gridcell">This is a custom footer for {props.group!.name}</div>
</div>
) : null;
};

const groupedListProps = {
Expand Down