feat(react-headless-components-preview): expose missing state data attributes - #36480
Open
Victor Genaev (mainframev) wants to merge 4 commits into
Open
feat(react-headless-components-preview): expose missing state data attributes#36480Victor Genaev (mainframev) wants to merge 4 commits into
Victor Genaev (mainframev) wants to merge 4 commits into
Conversation
📊 Bundle size report
🤖 This report was generated against c83bfa7666778640350f54991c8ebe712a8f389b |
|
Pull request demo site: URL |
Tudor Popa (tudorpopams)
requested review from
Martin Hochel (Hotell) and
Dmytro Kirpa (dmytrokirpa)
August 4, 2026 12:03
Martin Hochel (Hotell)
left a comment
Martin Hochel (Hotell)
left a comment
Contributor
There was a problem hiding this comment.
left some comments, those +2kb are not great :D
| }); | ||
|
|
||
| state.popover.open = popoverOpen; | ||
| state.root['data-open'] = stringifyDataAttribute(popoverOpen); |
Contributor
There was a problem hiding this comment.
isn't this boolean ? AFAIR we are going to toggle bool attributes instead of toggling value ?
|
|
||
| setMenuItemDataAttributes(state); | ||
| // eslint-disable-next-line react-hooks/immutability | ||
| state.root['data-checked'] = stringifyDataAttribute(state.checked); |
Contributor
There was a problem hiding this comment.
cant this be achieved just by calling the base hook and setting state.root ?
Victor Genaev (mainframev)
force-pushed
the
vgenaev/headless-data-attributes
branch
2 times, most recently
from
August 10, 2026 11:50
20545eb to
c1622bb
Compare
Victor Genaev (mainframev)
force-pushed
the
vgenaev/headless-data-attributes
branch
from
August 10, 2026 12:08
c1622bb to
eebc128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-*attributes.FUI Modern builds on headless components and needs stable selectors for state-driven styling: