[dev-v5][Theme] Fix data-theme for light and system values#4766
Open
MarvinKlein1508 wants to merge 2 commits intomicrosoft:dev-v5from
Open
[dev-v5][Theme] Fix data-theme for light and system values#4766MarvinKlein1508 wants to merge 2 commits intomicrosoft:dev-v5from
data-theme for light and system values#4766MarvinKlein1508 wants to merge 2 commits intomicrosoft:dev-v5from
Conversation
Collaborator
Author
|
See #4628 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes theme initialization so data-theme="light" and data-theme="system" on <body> are honored during startup, instead of being ignored.
Changes:
- Expand
tryGetThemeModeFromBody()to recognizelightandsystemin addition todark. - Validate the
data-themeattribute value against allowed modes before using it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR fixes an issue within the theme detection. The cases where the user has set
data-theme="light"ordata-theme="system"on the body were previously ignored by the initialization process.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps