Skip to content

Disable $includes for iterative includes#5620

Open
LTA-Thinking wants to merge 3 commits into
mainfrom
personal/rojo/disable-iterative-includes
Open

Disable $includes for iterative includes#5620
LTA-Thinking wants to merge 3 commits into
mainfrom
personal/rojo/disable-iterative-includes

Conversation

@LTA-Thinking

Copy link
Copy Markdown
Contributor

Description

$includes never supported iterative includes, but it currently throws a 500 when a search with iterative includes exceeds the max includes count. This change prevents that 500 and returns a warning instead.

Related issues

Addresses Bug 194365

Testing

New E2E test

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@LTA-Thinking LTA-Thinking added this to the FY26\Q4\2Wk\2Wk26 milestone Jun 17, 2026
@LTA-Thinking LTA-Thinking requested a review from a team as a code owner June 17, 2026 17:20
@LTA-Thinking LTA-Thinking added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs No-PaaS-breaking-change No-ADR ADR not needed labels Jun 17, 2026
Comment thread test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/IncludesOperationTests.cs Outdated

@mikaelweave mikaelweave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments - newline is moot - text is more important

Comment thread src/Microsoft.Health.Fhir.Core/Resources.resx Outdated
Comment thread src/Microsoft.Health.Fhir.Core/Resources.resx
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7769ecc). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5620   +/-   ##
=======================================
  Coverage        ?   76.90%           
=======================================
  Files           ?      997           
  Lines           ?    36621           
  Branches        ?     5530           
=======================================
  Hits            ?    28163           
  Misses          ?     7110           
  Partials        ?     1348           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. No-ADR ADR not needed No-PaaS-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants