Disable $includes for iterative includes#5620
Open
LTA-Thinking wants to merge 3 commits into
Open
Conversation
mikaelweave
reviewed
Jun 17, 2026
mikaelweave
left a comment
Contributor
There was a problem hiding this comment.
small comments - newline is moot - text is more important
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5620 +/- ##
=======================================
Coverage ? 76.90%
=======================================
Files ? 997
Lines ? 36621
Branches ? 5530
=======================================
Hits ? 28163
Misses ? 7110
Partials ? 1348 🚀 New features to boost your workflow:
|
mikaelweave
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
$includes never supported iterative includes, but it currently throws a 500 when a search with iterative includes exceeds the max includes count. This change prevents that 500 and returns a warning instead.
Related issues
Addresses Bug 194365
Testing
New E2E test
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)