Enlist transactions enabled only for Sequential Transactions#5611
Open
fhibf wants to merge 3 commits into
Open
Enlist transactions enabled only for Sequential Transactions#5611fhibf wants to merge 3 commits into
fhibf wants to merge 3 commits into
Conversation
fhibf
added
Enhancement
fhibf
added
Bug
| MergeOptions mergeOptions = new MergeOptions(enlistTransaction: true, ensureAtomicOperations: isBundleTransaction); | ||
| MergeOptions mergeOptions = new MergeOptions( | ||
| enlistTransaction: enlistTransaction, | ||
| ensureAtomicOperations: isBundleTransaction); |
Contributor
There was a problem hiding this comment.
ensureAtomicOperations always equals to isBundleTransaction. Why not to rename ensureAtomicOperations to match?
| // - EnlistTransaction: should be always false, and rely on SQL transactions. | ||
|
|
||
| IBundleOrchestratorOperation bundleOperation = _bundleOrchestrator.GetOperation(resource.BundleResourceContext.BundleOperationId); | ||
| SetAndClearPendingSearchParameterStatus(resource); |
Contributor
There was a problem hiding this comment.
It looks like SetAndClearPendingSearchParameterStatus(resource); can be moved outside any ifs to line 878. Do you mind moving it there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I'm setting "enlistTransaction" to false for most all operations, except by Sequential Bundle Transactions.
During last week, it was noticed that deadlocks were not retried in standalone operations as they were set to enlist in transaction. By setting that to false, it'll now: (1) be included as part of SQL transaction in MergeResources; (2) retry deadlock errors if any.
With these changes we should make standalone operations more stable and resilient to sporadic deadlocks (considered as retriable).
Related issues
Addresses AB#195581.
Testing
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)