Repository navigation
[Async stack 2/6] asyncio composition - #359
Closed
andystaples wants to merge 1 commit into
Closed
andystaples wants to merge 1 commit into
andystaples wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Superseded by #358, which is the canonical layer 2 of this stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge this PR, or any other PR in this stack, on its own. The stack exists only to make review easier. Once every PR in the stack is approved, the whole stack will be squash-merged together.
Part of the reviewability stack split from #293. This PR is based on the coroutine-dispatch layer (#357).
Scope
This PR extends the deterministic orchestration event loop in
durabletask/internal/asyncio_loop.py. It adds support for standard asyncio composition primitives inside async orchestrators:create_taskreturns a_DurableAsyncTaskthat is retired when it completes, so finished tasks and their payloads are released.call_soonkeeps FIFO order. While a task is being cancelled, callbacks scheduled during that cancellation are ordered deterministically. This keepsTaskGroupcancellation, and the durable actions it produces, stable across replays.call_laterandcall_atare backed by durable timers through_DurableTimerHandle.asyncio.sleep,asyncio.wait_for,asyncio.timeout,asyncio.gather, andasyncio.TaskGroupwork inside async orchestrators.Review focus
call_soonversus cancellation callbacks, and the durable actions they produce.Deferred to later layers
AsyncOrchestrationContextAPI surface.The tests in this layer use the existing
OrchestrationContextAPIs. Later layers move them to the async context.