build(release): npm publishConfig for all three packages - #338
Closed
YunchuWang wants to merge 1 commit into
Closed
Conversation
Split out of #335 as a standalone, independently reviewable change. Adds `publishConfig.registry` to all three package.json files, `publishConfig.access: "public"` to the two scoped packages (@microsoft/durabletask-js and @microsoft/durabletask-js-azuremanaged), and a `prepublishOnly` guard to core. This ensures the packages publish to the public npm registry during release. Content is byte-identical to the CI-green #335 branch at 8501bc0; this is a pure re-partition with no behavior change. Smallest of the four split PRs and the most urgent for publishing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d86f5f69-4e1a-4c1d-b017-5e290c85cc05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates per-package npm publishing settings so releases reliably publish to the public npm registry (and scoped packages publish as public) across the monorepo packages.
Changes:
- Adds
publishConfig.registry: https://registry.npmjs.org/to all three package manifests. - Adds
publishConfig.access: "public"to the two scoped packages (@microsoft/durabletask-js,@microsoft/durabletask-js-azuremanaged). - Adds a
prepublishOnlyguard (npm run build && npm run test) to the core SDK package.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/durabletask-js/package.json | Adds publishConfig (registry + public access) and adds prepublishOnly to guard publishing with build+test. |
| packages/durabletask-js-azuremanaged/package.json | Adds publishConfig (registry + public access) for correct scoped-package publishing defaults. |
| packages/azure-functions-durable/package.json | Adds publishConfig.registry to ensure publishing targets the public npm registry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the npm publish configuration out of #335. Smallest of the four split PRs and the most urgent for publishing.
What
publishConfig.registry: https://registry.npmjs.org/on all three packages.publishConfig.access: "public"on the two scoped packages (@microsoft/durabletask-js,@microsoft/durabletask-js-azuremanaged).prepublishOnlyguard (npm run build && npm run test) on core.Why
Ensures the packages publish to the public npm registry during release; scoped packages default to restricted access without an explicit
access: "public".Provenance
Content is byte-identical to the CI-green #335 branch at
8501bc0— a pure re-partition, no behavior change.npm run lintexits 0.Part of the #335 split
#335 is being decomposed into four mutually independent PRs that can merge in any order:
Together these carry every one of #335's 10 files with no overlap. #335 stays open until the file→PR mapping posted there is confirmed; these PRs neither merge nor close it.