Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/conductor/duration.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from __future__ import annotations

import math
import re

_DURATION_PATTERN = re.compile(r"^\s*(?P<value>\d+(?:\.\d+)?)\s*(?P<unit>ms|s|m|h)?\s*$")
Expand Down Expand Up @@ -64,6 +65,8 @@ def parse_duration(value: str | int | float) -> float:
raise ValueError(f"duration must be a number or duration string, not boolean: {value!r}")

if isinstance(value, (int, float)):
if not math.isfinite(value):
raise ValueError(f"duration must be finite, got {value!r}")
return float(value)

if not isinstance(value, str):
Expand All @@ -79,5 +82,7 @@ def parse_duration(value: str | int | float) -> float:
)

number = float(match.group("value"))
if not math.isfinite(number):
raise ValueError(f"duration must be finite, got {value!r}")
unit = match.group("unit") or "s"
return number * _UNIT_TO_SECONDS[unit]
11 changes: 11 additions & 0 deletions tests/test_engine/test_duration.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

from __future__ import annotations

import math

import pytest

from conductor.duration import parse_duration
Expand Down Expand Up @@ -118,3 +120,12 @@ def test_list(self) -> None:
def test_number_then_garbage(self) -> None:
with pytest.raises(ValueError):
parse_duration("5 minutes")

@pytest.mark.parametrize("value", [math.nan, math.inf, -math.inf])
def test_nonfinite_number(self, value: float) -> None:
with pytest.raises(ValueError, match="finite"):
parse_duration(value)

def test_overflowing_string_number(self) -> None:
with pytest.raises(ValueError, match="finite"):
parse_duration("9" * 400)