Skip to content

[codex] Make env-var default hint copyable #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zixuanguo786-ctrl wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] Make env-var default hint copyable #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/conductor/config/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def replace_env_var(match: re.Match) -> str:
raise ConfigurationError(
f"Required environment variable '{var_name}' is not set",
suggestion=f"Set the environment variable '{var_name}' or provide a default "
f"value using the syntax: ${{{{{{var_name}}}}:-default_value}}",
"value using the syntax: " + "${" + var_name + ":-default_value}",
)

# Perform substitution
Expand Down
1 change: 1 addition & 0 deletions tests/test_config/test_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def test_resolve_missing_required_env_var_raises(self) -> None:
resolve_env_vars("${REQUIRED_VAR}")
assert "REQUIRED_VAR" in str(exc_info.value)
assert "not set" in str(exc_info.value)
assert "${REQUIRED_VAR:-default_value}" in str(exc_info.value)

def test_resolve_empty_default(self) -> None:
"""Test that empty default is allowed."""
Expand Down