Migrate Calculator ViewModels from C++ to C# - #2491
Open
Gebril Fradj (gebrilfradj) wants to merge 6 commits into
Open
Migrate Calculator ViewModels from C++ to C##2491Gebril Fradj (gebrilfradj) wants to merge 6 commits into
Gebril Fradj (gebrilfradj) wants to merge 6 commits into
Conversation
Preserve the existing GitHub UI and the merged accessibility fixes while replacing the application ViewModel layer with its managed implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Port the parity, concurrency, lifetime, Recall, localization, and converter fixes without introducing the redesigned converter UI. Replace the skipped migration stubs with active managed coverage and add the suite to the existing CI paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Delete CalcViewModel and its copied test project now that the managed ViewModels have active parity coverage. Keep the remaining native engine tests and their resource provider. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Port the remaining graphing ViewModel behavior, make currency refresh retryable after initial load, restore localized default currencies and app licensing, and fix converter narration localization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Create a fresh CalculatorManager fixture before every test so mode-change state cannot leak into the Standard test under Release ordering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Etienne Baudoux (veler)
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calculator.ViewModelsin C# and the required managed/native interop.CalcViewModel,CalcViewModelCopyForUT, and the obsolete ViewModel-specific C++ tests while retaining the native calculation engine and its remaining tests.Validation
Calculator.Tests: 294 passed, 0 failed, 0 skipped.CalculatorUnitTests: 86 passed, 0 failed.