Skip to content

Fix clippy useless_borrows_in_formatting warnings #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnbatty merged 1 commit into from
Aug 1, 2026
Merged

Fix clippy useless_borrows_in_formatting warnings #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changes

- Fix `clippy::useless_borrows_in_formatting` warnings from the updated Rust
toolchain by removing redundant references in `format!` arguments (codegen,
hand-written source, and regenerated modules).

## [0.38.0]

### Changes
Expand Down
2 changes: 1 addition & 1 deletion autorust/codegen/src/codegen_operations/request_builder_send.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ impl ToTokens for RequestBuilderSendCode {
let request_builder = &self.request_builder;

let url_args = self.url_args.iter().map(|url_arg| {
quote! { &self.#url_arg }
quote! { self.#url_arg }
});
let url_str_args = quote! { #(#url_args),* };

Expand Down
2 changes: 1 addition & 1 deletion azure_devops_rust_api/examples/build_list_continuation_token.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ async fn get_builds(

let body_data = body.into_string()?;
let build_list: BuildList = serde_json::from_str(&body_data)
.with_context(|| format!("Failed to parse BuildList: {}", &body_data))?;
.with_context(|| format!("Failed to parse BuildList: {}", body_data))?;

println!("Received {} builds", build_list.count.unwrap_or(0));

Expand Down
74 changes: 37 additions & 37 deletions azure_devops_rust_api/src/approvals_and_checks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ pub mod pipeline_permissions {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/pipelinepermissions",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -391,10 +391,10 @@ pub mod pipeline_permissions {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/pipelinepermissions/{}/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.resource_type,
&self.resource_id
self.organization,
self.project,
self.resource_type,
self.resource_id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -497,10 +497,10 @@ pub mod pipeline_permissions {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/pipelinepermissions/{}/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.resource_type,
&self.resource_id
self.organization,
self.project,
self.resource_type,
self.resource_id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -761,8 +761,8 @@ pub mod check_configurations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/configurations",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -860,8 +860,8 @@ pub mod check_configurations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/configurations",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -970,9 +970,9 @@ pub mod check_configurations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/configurations/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.id
self.organization,
self.project,
self.id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1070,9 +1070,9 @@ pub mod check_configurations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/configurations/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.id
self.organization,
self.project,
self.id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1163,9 +1163,9 @@ pub mod check_configurations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/configurations/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.id
self.organization,
self.project,
self.id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1282,8 +1282,8 @@ pub mod check_configurations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/queryconfigurations",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1439,8 +1439,8 @@ pub mod check_evaluations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/runs",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1546,9 +1546,9 @@ pub mod check_evaluations {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/checks/runs/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.check_suite_id
self.organization,
self.project,
self.check_suite_id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1770,8 +1770,8 @@ pub mod approvals {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/approvals",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1868,8 +1868,8 @@ pub mod approvals {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/approvals",
self.client.endpoint(),
&self.organization,
&self.project
self.organization,
self.project
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down Expand Up @@ -1978,9 +1978,9 @@ pub mod approvals {
let mut url = azure_core::http::Url::parse(&format!(
"{}/{}/{}/_apis/pipelines/approvals/{}",
self.client.endpoint(),
&self.organization,
&self.project,
&self.approval_id
self.organization,
self.project,
self.approval_id
))?;
let has_api_version_already = url.query_pairs().any(|(k, _)| k == "api-version");
if !has_api_version_already {
Expand Down
Loading
Loading