Rename resource 'Export JSON' action to 'View JSON' and clarify secret warning scope#18107
Rename resource 'Export JSON' action to 'View JSON' and clarify secret warning scope#18107nanookclaw wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR renames the "Export JSON" resource menu item to "View JSON" and updates the text visualizer secret warning description to clarify that the preference is browser-specific ("In this browser, opening the text visualizer in the future...").
Changes:
- Renamed the resource menu item from "Export JSON" to "View JSON" in the resource menu builder and added a new
ViewJsonlocalization string across all language XLF files. - Updated the
TextVisualizerSecretWarningDescriptionsource string to clarify the scope is browser-specific, marking all translations asneeds-review-translation. - Updated tests to assert against the new
ViewJsonlocalized string.
Reviewed changes
Copilot reviewed 30 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/Model/ResourceMenuBuilder.cs | Changed menu item text reference from ExportJson to ViewJson |
| src/Aspire.Dashboard/Resources/ControlsStrings.resx | Added new ViewJson resource string |
| src/Aspire.Dashboard/Resources/Dialogs.resx | Updated TextVisualizerSecretWarningDescription source text |
| src/Aspire.Dashboard/Resources/xlf/ControlsStrings.*.xlf | Added ViewJson trans-unit with state="new" |
| src/Aspire.Dashboard/Resources/xlf/Dialogs.*.xlf | Updated source and set target state to needs-review-translation |
| tests/Aspire.Dashboard.Tests/Model/ResourceMenuBuilderTests.cs | Updated test assertions from ExportJson to ViewJson |
Files not reviewed (2)
- src/Aspire.Dashboard/Resources/ControlsStrings.Designer.cs: Language not supported
- src/Aspire.Dashboard/Resources/Dialogs.Designer.cs: Language not supported
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18107Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18107" |
| @@ -523,6 +523,9 @@ | |||
| <data name="ExportJson" xml:space="preserve"> | |||
There was a problem hiding this comment.
Is ExportJson used anymore? Can it be removed?
There was a problem hiding this comment.
Removed in 268b84b23; the menu code already moved to ViewJson, so the old ExportJson resource/designer/XLIFF entries are gone now.
| </data> | ||
| <data name="TextVisualizerSecretWarningDescription" xml:space="preserve"> | ||
| <value>Confirm you want to show the value. In the future, opening the text visualizer will automatically display all values</value> | ||
| <value>Confirm you want to show the value. In this browser, opening the text visualizer in the future will automatically display all values</value> |
There was a problem hiding this comment.
I like this more:
| <value>Confirm you want to show the value. In this browser, opening the text visualizer in the future will automatically display all values</value> | |
| <value>Confirm you want to show this value. Once confirmed, the text visualizer in the browser will show values automatically</value> |
There was a problem hiding this comment.
Applied in 268b84b23.
nanookclaw
force-pushed
the
fix/export-json-visualizer-text
branch
from
cfccb7f to
268b84b
Compare
|
Thanks! |
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
adamint
left a comment
adamint
left a comment
There was a problem hiding this comment.
Looks good to me. I reviewed the dashboard string/localization updates and didn't find any blocking issues.
What
Renames the resource Actions menu item
Export JSONtoView JSON, and clarifies the sensitive-value confirmation message in the Text Visualizer dialog. Closes #17690.Why
The
Export JSONaction does not export a file — it opens the Text Visualizer dialog. The name implies a direct download, which mismatches the actual behavior. This appliesView JSON(issue Option A: rename) to the resource menu, accurately describing what the action does. The braces icon and existing click behavior are unchanged.The confirmation message previously read "...In the future, opening the text visualizer will automatically display all values", where the scope of "in the future" was ambiguous (this session? this resource? permanent?). The acknowledgement is persisted in browser local storage, so the wording is updated to "In this browser, opening the text visualizer in the future will automatically display all values" to reflect the real, browser-scoped persistence.
Notes
ViewJsonresource string is added rather than repurposingExportJson, sinceExportJsonis still used by the traces/spans/structured-log menus. New.xlfunits are emitted withstate="new"; the changed Dialogs description resets affected locale targets toneeds-review-translation, matching the standard xliff-tasks output.ResourceMenuBuilderTestsassertions updated to the new key.Local build/test verification was blocked: the repo pins SDK
10.0.201viaglobal.jsonand./restore.shcannot fetch it in this offline environment. Changes were validated by static cross-checks (resx/Designer/xlf key consistency, XML well-formedness) and an independent diff review.