Skip to content

Update all workflow files to use Node 24-compatible github-script#16901

Merged
radical merged 3 commits into
mainfrom
copilot/update-github-actions-to-node24
Jun 12, 2026
Merged

Update all workflow files to use Node 24-compatible github-script#16901
radical merged 3 commits into
mainfrom
copilot/update-github-actions-to-node24

Conversation

Copilot AI commented May 9, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the Node.js 20 deprecation warning across all GitHub Actions workflows by updating every actions/github-script pin to the Node.js 24-compatible v9.0.0 SHA.

  • Workflow updates

    • Replace all deprecated actions/github-script v7 and v8 SHAs across all workflow files with the repo's pinned v9 SHA.
    • Script logic in all workflows is left unchanged.
  • Scope

    • Affects all workflows that referenced the old v7 (60a0d83039c74a4aee543508d2ffcb1c3799cdea) or v8 (ed597411d8f924073f98dfc5c65a23a2325f34cd) pins: apply-test-attributes.yml, auto-rerun-transient-ci-failures.yml, backmerge-release.yml, backport.yml, build-cli-e2e-image.yml, cli-e2e-recording-comment.yml, create-failing-test-issue.yml, deployment-cleanup.yml, deployment-test-command.yml, deployment-tests.yml, dogfood-comment.yml, tests-daily-smoke.yml, and update-dependencies.yml.
    • Does not touch workflow lock files.
    • Does not change any script logic, cache scopes, image build steps, artifact behavior, or retry behavior.
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
Original prompt

Update the GitHub Actions workflow in repository microsoft/aspire to eliminate the Node.js 20 deprecation warning emitted by actions/github-script in the CLI E2E image cache workflow chain.

Context:

  • The warning appears in workflow run 25540028444, job 74963758697 (workflow Warm CLI E2E Image Cache).
  • The reusable workflow .github/workflows/build-cli-e2e-image.yml currently uses:
    • actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
  • The specific step is Export GitHub Actions cache runtime.
  • This older pinned version runs on Node.js 20 and triggers the warning about the migration to Node.js 24.

Requested change:

  • Replace that deprecated actions/github-script reference in .github/workflows/build-cli-e2e-image.yml with an updated pinned version that supports Node.js 24 (prefer the current v9 pinned SHA, consistent with newer workflows in this repo when appropriate).
  • Keep the behavior of the script step unchanged.
  • Open a pull request with the fix.

Relevant file references:

  • .github/workflows/build-cli-e2e-image.yml
  • .github/workflows/warm-cli-e2e-image-cache.yml

Observed warning text:

  • Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea.

Notes:

  • The job log also contains transient GitHub Actions cache service 400 errors during BuildKit cache import/export; those are not the target of this change. Focus only on removing the Node.js 20 deprecation warning.
  • Preserve existing workflow functionality and pin-by-SHA style.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Let's fix this warning:


Warm CLI E2E image cache / Build CLI E2E Docker image
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/github-script@60a0d83. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Assistant: I’ve started the PR creation flow to update the pinned actions/github-script in microsoft/aspire, and we’re currently waiting for your response to the confirmation dialog before I can continue.

This pull request was created from Copilot chat.

Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/72d69096-2f69-4cd8-a1cc-104174267efa

Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com>
Copilot AI changed the title [WIP] Update GitHub Actions workflow to eliminate deprecation warning Update CLI E2E image workflow to use Node 24-compatible github-script May 9, 2026
Copilot AI requested a review from sebastienros May 9, 2026 01:26
@sebastienros sebastienros requested review from radical and removed request for sebastienros May 9, 2026 01:26
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16901

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16901"

@sebastienros sebastienros marked this pull request as ready for review May 9, 2026 01:30
Copilot AI review requested due to automatic review settings May 9, 2026 01:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable CLI E2E image build workflow to use a Node 24-compatible pinned actions/github-script version, eliminating the Node.js 20 deprecation warning in the CLI E2E image cache workflow chain while preserving the existing cache-runtime export behavior.

Changes:

  • Updated .github/workflows/build-cli-e2e-image.yml to use actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 (v9.0.0) instead of the older v7 pin.
  • Kept the “Export GitHub Actions cache runtime” script logic unchanged.

@radical

radical commented May 11, 2026

Copy link
Copy Markdown
Member

@copilot We should match the change in all the other references to github-script that we have. Except for the workflow lock files.

1 similar comment
@radical

radical commented Jun 11, 2026

Copy link
Copy Markdown
Member

@copilot We should match the change in all the other references to github-script that we have. Except for the workflow lock files.

Co-authored-by: radical <1472+radical@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot We should match the change in all the other references to github-script that we have. Except for the workflow lock files.

Done. Updated all actions/github-script references across the workflow files to the v9.0.0 SHA (3a2844b7e9c422d3c10d287c895573f7108da1b3). Files updated: apply-test-attributes.yml, auto-rerun-transient-ci-failures.yml, backmerge-release.yml, backport.yml, cli-e2e-recording-comment.yml, create-failing-test-issue.yml, deployment-cleanup.yml, deployment-test-command.yml, deployment-tests.yml, dogfood-comment.yml, tests-daily-smoke.yml, and update-dependencies.yml.

Copilot AI changed the title Update CLI E2E image workflow to use Node 24-compatible github-script Update all workflow files to use Node 24-compatible github-script Jun 11, 2026
@radical radical requested review from adamint and joperezr June 12, 2026 18:04
@radical radical merged commit 6a8d3a5 into main Jun 12, 2026
648 of 651 checks passed
@radical radical deleted the copilot/update-github-actions-to-node24 branch June 12, 2026 18:08
@github-actions github-actions Bot added this to the 13.5 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants