Upgrade mscclpp to v0.9.0 + multi-GPU device-pinning fixes#247
Merged
Conversation
Contributor
chhwang
commented
May 25, 2026
chhwang
commented
- Bump mscclpp pin from 7f3b0887 to v0.9.0 (225 commits ahead)
- Migrate executor.cpp to v0.9.0 Communicator API: connectOnSetup -> connect(EndpointConfig), SmDevice2DeviceSemaphore -> MemoryDevice2DeviceSemaphore, MemoryChannel ctor takes RegisteredMemory not raw ptr
- Add set_current() in Executor::compile and PlanResource::init_kernel to pin CUDA context before per-device allocations (fixes cudaErrorInvalidValue at TP>=4)
- Update executor pybind for v0.9.0 API changes
- Fix GPU architecture detection in cmake for newer CUDA toolkits
- Update CI workflow
- Bump mscclpp pin from 7f3b0887 to v0.9.0 (225 commits ahead) - Migrate executor.cpp to v0.9.0 Communicator API: connectOnSetup -> connect(EndpointConfig), SmDevice2DeviceSemaphore -> MemoryDevice2DeviceSemaphore, MemoryChannel ctor takes RegisteredMemory not raw ptr - Add set_current() in Executor::compile and PlanResource::init_kernel to pin CUDA context before per-device allocations (fixes cudaErrorInvalidValue at TP>=4) - Update executor pybind for v0.9.0 API changes - Fix GPU architecture detection in cmake for newer CUDA toolkits - Update CI workflow
…-review - Replace volatile pointer casts with mscclpp::atomicLoad/atomicStore from atomic_device.hpp for host-side flag polling - Remove .github/workflows/ut.yml (CI not runnable currently) - Add unit tests: test_executor_device_pinning (ReLU smoke), test_executor_recompile_cycle, test_executor_flag_polling - Fix Python max_spin_count default (100000000 -> -1 = infinite) - Move timer_begin_->record() after set_current() in launch() - Condense verbose set_current() comments per deep-review feedback - Clarify test comments: single-GPU smoke, not multi-GPU verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.