Skip to content

Skip filtered candidates in .NET porting workflows - #1316

Merged
Quim Muntal (qmuntal) merged 1 commit into
mainfrom
fix/porting-filtered-search-exclusions
Oct 21, 2026
Merged

Quim Muntal (qmuntal) merged 1 commit into
mainfrom
fix/porting-filtered-search-exclusions

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Summary

  • Treat integrity-filtered issue/PR duplicate searches as conservative candidate exclusions in both nightly .NET porting workflows, rather than attempting direct-read recovery or treating filtering as an incomplete review.
  • Record the undesired-approach assumption without claiming a confirmed maintainer rejection. Continue through the existing review budget and the fixes workflow's existing-Go fallback.
  • Apply the same exclusion rule before publication, discard only run-owned edits for disqualified approaches, and retain incomplete reporting for genuine tool, source, and validation failures.
  • Leave permissions and trust settings unchanged; regenerate only the workflow lock prompt hashes.

Validation

  • gh aw compile dotnet-port-api-nightly --strict --no-check-update — passed with zero warnings.
  • gh aw compile dotnet-port-fixes-nightly --strict --no-check-update — passed with zero warnings.
  • git diff --cached --check — passed.
  • Verified that generated lock changes affect only body_hash metadata.
  • No workflow reruns dispatched.

Fixes #1314
Fixes #1315

Treat filtered duplicate searches as conservative exclusions during selection and publication checks, while preserving trust settings and genuine failure reporting.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner October 21, 2026 09:20
Copilot AI balanced review requested due to automatic review settings October 21, 2026 09:20
@github-actions github-actions Bot added the area:github Changes files in the github area label Oct 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped changes consistently implement the exclusion policy while preserving safeguards and reporting genuine failures.

No open issues 🎉

What changed in this PR

Updates both nightly .NET porting workflows to skip integrity-filtered candidates rather than report incomplete reviews, addressing #1314 and #1315.

Changes:

  • Applies conservative exclusions during selection and final duplicate checks.
  • Preserves review budgets, existing-Go fallback, security safeguards, and genuine failure reporting.
  • Refreshes only generated prompt hashes in workflow locks.
File Description
.github/​workflows/​dotnet-port-fixes-nightly.md Updates exclusions, fallback handling, and completion reporting.
.github/​workflows/​dotnet-port-fixes-nightly.lock.yml Refreshes the fixes workflow prompt hash.
.github/​workflows/​dotnet-port-api-nightly.md Updates exclusions, final checks, and completion reporting.
.github/​workflows/​dotnet-port-api-nightly.lock.yml Refreshes the API workflow prompt hash.

Review effort: Balanced

@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 188cfd4 Oct 21, 2026
18 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the fix/porting-filtered-search-exclusions branch October 21, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:github Changes files in the github area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] .NET to Go API Porting Agent reported incomplete result [aw] .NET to Go Fixes and Test Porting Agent reported incomplete result

3 participants