Repository navigation
Harden API consistency reviews and scan GitHub Actions - #1310
Merged
Merged
Conversation
Make API reviews API-only with explicit native tool denials and a least-privilege fork dispatcher. Add Actions CodeQL analysis alongside Go and retain the staged gh-aw maintenance updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The privileged review path needs human validation of runtime tool restrictions and end-to-end safe-output behavior.
No open issues 🎉
What changed in this PR
Continues #1309’s automation hardening by making API-consistency reviews API-only and adding GitHub Actions security scanning.
Changes:
- Restrict reviewer tools, checkout, network access, and persistent memory; reduce dispatcher permissions.
- Add Actions CodeQL analysis alongside independent Go analysis.
- Pin gh-aw setup actions and refresh generated metadata, skill references, and the upgrade schedule.
| File | Description |
|---|---|
.github/workflows/symbolmap-maintenance-weekly.lock.yml |
Normalize action version metadata and comments. |
.github/workflows/go-api-consistency-review.md |
Define API-only review restrictions and evidence requirements. |
.github/workflows/go-api-consistency-review.lock.yml |
Regenerate restricted reviewer execution. |
.github/workflows/go-api-consistency-review-forks.yml |
Remove unused contents permission. |
.github/workflows/dotnet-port-fixes-nightly.lock.yml |
Normalize action version metadata and comments. |
.github/workflows/dotnet-port-api-nightly.lock.yml |
Normalize action version metadata and comments. |
.github/workflows/dotnet-code-portability-weekly.lock.yml |
Normalize action version metadata and comments. |
.github/workflows/copilot-setup-steps.yml |
Pin setup action to an immutable SHA. |
.github/workflows/codeql.yml |
Add Actions analysis with isolated Go build steps. |
.github/workflows/agentic-auto-upgrade.yml |
Pin setup actions and change weekly schedule. |
.github/skills/agentic-workflows/SKILL.md |
Add workflow guidance references. |
.github/aw/actions-lock.json |
Refresh action pins and version metadata. |
Review effort: Balanced
Quim Muntal (qmuntal)
enabled auto-merge
October 20, 2026 14:35
George Adams (gdams)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up to #1309 by further narrowing the permissions and execution surface of automation reached through
pull_request_target. The fork dispatcher remains a small trusted entry point, while the downstream API-consistency reviewer obtains evidence through GitHub APIs instead of checking out PR code or running native shell commands.Changes
contents: readpermission; retainactions: writefor dispatching the fixed review workflow.shellandwritetools, including automatically approved read-only shell commands.GITHUB_TOKENoverrides are not included.nonematrix leg alongside the existing Go/manualanalysis. Go setup/build steps remain Go-only, and one matrix failure does not cancel the other leg.Included gh-aw maintenance updates
Trade-offs
pull_request_targetor weaken checkout trust checks to bypass the previous checkout failure.Validation
gh aw compile go-api-consistency-review --strict --validate --no-check-update: passed with zero warnings.gh aw list --json: all five authored/generated workflow pairs are synchronized.