Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions provider/a2aprovider/a2a.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ func (a *a2aProvider) run(ctx context.Context, messages []*message.Message, opti
}, false, yield)
return
}
if len(messages) == 0 {
return
}
userMsg, err := messagesToA2AMessage(session, messages)
if err != nil {
yield(nil, err)
Expand Down Expand Up @@ -170,6 +167,9 @@ func messagesToA2AMessage(session *agent.Session, messages []*message.Message) (
maps.Copy(metadata, msg.AdditionalProperties)
}
}
if len(parts) == 0 {
return nil, errors.New("a2aprovider: the provided messages contain no content that can be sent to the remote agent")
}
combined := &message.Message{ID: msgID, AdditionalProperties: metadata}
return createA2AMessage(session, combined, parts), nil
}
Expand Down
28 changes: 28 additions & 0 deletions provider/a2aprovider/a2a_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,34 @@ func TestRunAllowsNonUserRoleMessages(t *testing.T) {
}
}

func TestRunRejectsMessagesWithoutSendableParts(t *testing.T) {
tests := []struct {
name string
messages []*message.Message
}{
{name: "empty messages"},
{name: "empty contents", messages: []*message.Message{{Role: message.RoleUser}}},
{name: "empty text", messages: []*message.Message{{Role: message.RoleUser, Contents: message.Contents{&message.TextContent{}}}}},
{name: "unsupported contents", messages: []*message.Message{{Role: message.RoleUser, Contents: message.Contents{&message.RawContent{}}}}},
}
for _, test := range tests {
for _, streaming := range []bool{false, true} {
t.Run(fmt.Sprintf("%s/streaming=%t", test.name, streaming), func(t *testing.T) {
transport := &mockA2ATransport{}
a := newTestAgent(transport, agent.Config{})

_, err := a.Run(t.Context(), test.messages, agent.Stream(streaming)).Collect()
if err == nil || !strings.Contains(err.Error(), "no content that can be sent to the remote agent") {
t.Fatalf("error = %v, want no-sendable-content error", err)
}
if transport.sendMessageCallCount != 0 || transport.sendStreamingCallCount != 0 {
t.Fatalf("A2A send calls = (%d, %d), want (0, 0)", transport.sendMessageCallCount, transport.sendStreamingCallCount)
}
})
}
}
}

// An ErrorContent must be sent to A2A as its human-readable text, not as an
// opaque JSON blob (the default-branch behavior), matching the Python client.
func TestRunSendsErrorContentAsText(t *testing.T) {
Expand Down
Loading