Skip to content

Fix nightly workflow completion and merge evidence - #1298

Closed
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
mainfrom
fix/agentic-workflow-results
Closed

Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
mainfrom
fix/agentic-workflow-results

Conversation

@michelle-clayton-work

@michelle-clayton-work Michelle Clayton (michelle-clayton-work) commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Prevent nightly .NET-to-Go porting runs from silently succeeding without a terminal result, and strengthen the evidence required to call work implemented.

Changes

  • Require exactly one terminal safe output: create_pull_request, noop, or report_incomplete. Missing, malformed, or contradictory results fail the agent job instead of leaving a misleading green run.
  • Snapshot the validator before the agent starts into runtime storage mounted read-only in the sandbox, so later checkout edits cannot replace the check.
  • Require current Go implementation evidence and a direct PR read confirming merged: true and a merge timestamp before citing a PR as implemented coverage. Closed, unmerged proposals do not count as implementations.
  • Keep required duplicate evidence blocked when integrity filtering hides references. Require structured incomplete reporting when no verified candidate can be selected, while preserving valid source-backed exclusions and independently verified selections.
  • Add 24 regression tests, wire them into CI, and regenerate both nightly workflow locks.

Fixes #1260
Fixes #1280

Validation

  • node --test .github/scripts/check-agent-result.test.cjs: 24 passed with Node 22.
  • Both nightly workflows compiled with gh-aw v0.89.21 using strict validation, with zero warnings.
  • Actionlint introduces no new diagnostics. The installed linter reports the same 11 baseline findings on main because it does not recognize copilot-requests and concurrency.queue; lint passes when only those two unsupported baseline messages are excluded.
  • git diff --check passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 20:41
@github-actions github-actions Bot added area:github Changes files in the github area size:large At most 300 changed lines across at most 10 files labels Oct 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking defects were identified; workflow wiring and regression coverage support the intended safeguards.

No open issues 🎉

What changed in this PR

Strengthens nightly .NET-to-Go porting workflows to prevent silent completion and unsupported implementation claims.

Changes:

  • Enforces exactly one terminal safe output using a protected validator snapshot.
  • Requires current Go implementation evidence, verified PR merges, and explicit reporting of unresolved evidence.
  • Adds 24 regression tests, CI integration, and regenerated workflow locks.
File Description
.github/​workflows/​test.yml Runs safeguard tests and includes them in CI completion.
.github/​workflows/​dotnet-port-fixes-nightly.md Adds result validation and stronger fix-selection evidence requirements.
.github/​workflows/​dotnet-port-fixes-nightly.lock.yml Regenerates fixes workflow validation steps.
.github/​workflows/​dotnet-port-api-nightly.md Adds result validation and stronger API-selection evidence requirements.
.github/​workflows/​dotnet-port-api-nightly.lock.yml Regenerates API workflow validation steps.
.github/​scripts/​check-agent-result.test.cjs Covers terminal-result validation and snapshot isolation.
.github/​scripts/​check-agent-result.cjs Validates terminal safe-output records.

Review effort: Balanced

@github-actions github-actions Bot added kind:ci Changes CI, build, or repository automation kind:tests Changes tests, fixtures, or test infrastructure labels Oct 16, 2026

@qmuntal Quim Muntal (qmuntal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh-aw v0.92.0 improved failure detections in github/gh-aw#65660. I would close this PR and see how our workflows operate with the gh-aw runtime improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:github Changes files in the github area kind:ci Changes CI, build, or repository automation kind:tests Changes tests, fixtures, or test infrastructure size:large At most 300 changed lines across at most 10 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] .NET to Go Fixes and Test Porting Agent produced no safe outputs [aw] .NET to Go API Porting Agent reported incomplete result

3 participants