Repository navigation
Fix nightly workflow completion and merge evidence - #1298
Closed
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
Closed
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michelle Clayton (michelle-clayton-work)
requested a review
from a team
as a code owner
October 16, 2026 20:41
Copilot started reviewing on behalf of
Michelle Clayton (michelle-clayton-work)
October 16, 2026 20:41
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking defects were identified; workflow wiring and regression coverage support the intended safeguards.
No open issues 🎉
What changed in this PR
Strengthens nightly .NET-to-Go porting workflows to prevent silent completion and unsupported implementation claims.
Changes:
- Enforces exactly one terminal safe output using a protected validator snapshot.
- Requires current Go implementation evidence, verified PR merges, and explicit reporting of unresolved evidence.
- Adds 24 regression tests, CI integration, and regenerated workflow locks.
| File | Description |
|---|---|
.github/workflows/test.yml |
Runs safeguard tests and includes them in CI completion. |
.github/workflows/dotnet-port-fixes-nightly.md |
Adds result validation and stronger fix-selection evidence requirements. |
.github/workflows/dotnet-port-fixes-nightly.lock.yml |
Regenerates fixes workflow validation steps. |
.github/workflows/dotnet-port-api-nightly.md |
Adds result validation and stronger API-selection evidence requirements. |
.github/workflows/dotnet-port-api-nightly.lock.yml |
Regenerates API workflow validation steps. |
.github/scripts/check-agent-result.test.cjs |
Covers terminal-result validation and snapshot isolation. |
.github/scripts/check-agent-result.cjs |
Validates terminal safe-output records. |
Review effort: Balanced
Quim Muntal (qmuntal)
requested changes
Oct 19, 2026
Quim Muntal (qmuntal)
left a comment
Member
There was a problem hiding this comment.
gh-aw v0.92.0 improved failure detections in github/gh-aw#65660. I would close this PR and see how our workflows operate with the gh-aw runtime improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent nightly .NET-to-Go porting runs from silently succeeding without a terminal result, and strengthen the evidence required to call work implemented.
Changes
create_pull_request,noop, orreport_incomplete. Missing, malformed, or contradictory results fail the agent job instead of leaving a misleading green run.merged: trueand a merge timestamp before citing a PR as implemented coverage. Closed, unmerged proposals do not count as implementations.Fixes #1260
Fixes #1280
Validation
node --test .github/scripts/check-agent-result.test.cjs: 24 passed with Node 22.copilot-requestsandconcurrency.queue; lint passes when only those two unsupported baseline messages are excluded.git diff --checkpassed.