Repository navigation
Record FileAccess experimental exclusions - #1296
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
All 20 assessment updates consistently document the experimental exclusions, with no runtime changes or unresolved issues.
0 open findings
What changed in this PR
Records experimental FileAccess APIs as intentional exclusions from the Go 0.2.0 non-experimental harness scope.
Changes:
- Marks all 20 assessments as intentional and removes their unreviewed flags.
- Adds MAAI001 exclusion notes without changing declarations or experimental metadata.
| File | Description |
|---|---|
_catalog/dotnet-go-sdk-symbol-mapping.json |
Records exclusions for FileAccessProvider, FileAccessProviderOptions, and their members. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Copilot fix linter errors |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: michelle-clayton-work <262183035+michelle-clayton-work@users.noreply.github.com>
Fixed the unchecked-error linter findings and verified with golangci-lint, targeted package tests, and catalog reconciliation. Commit: |
API consistency review
No parity review is needed: this PR only adds unchecked-error assertions inside existing test loops ( Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
FileAccessProvider and FileAccessProviderOptions are marked
MAAI001experimental in .NET, so they are outside the Go 0.2.0 non-experimental harness scope.Mark all 20 declaration assessments as intentional exclusions and remove their unreviewed flags. The declarations and experimental metadata are unchanged.
Validation:
go -C _catalog run ./cmd/symbolmap reconcile -summary -check.