Skip to content

Record FileAccess experimental exclusions - #1296

Merged
Quim Muntal (qmuntal) merged 2 commits into
mainfrom
dev/mclayton/fileaccess-inventory
Oct 16, 2026
Merged

Quim Muntal (qmuntal) merged 2 commits into
mainfrom
dev/mclayton/fileaccess-inventory

Conversation

@michelle-clayton-work

Copy link
Copy Markdown
Contributor

FileAccessProvider and FileAccessProviderOptions are marked MAAI001 experimental in .NET, so they are outside the Go 0.2.0 non-experimental harness scope.

Mark all 20 declaration assessments as intentional exclusions and remove their unreviewed flags. The declarations and experimental metadata are unchanged.

Validation: go -C _catalog run ./cmd/symbolmap reconcile -summary -check.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 18:33
@github-actions github-actions Bot added the size:medium At most 100 changed lines across at most 5 files label Oct 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All 20 assessment updates consistently document the experimental exclusions, with no runtime changes or unresolved issues.

0 open findings

What changed in this PR

Records experimental FileAccess APIs as intentional exclusions from the Go 0.2.0 non-experimental harness scope.

Changes:

  • Marks all 20 assessments as intentional and removes their unreviewed flags.
  • Adds MAAI001 exclusion notes without changing declarations or experimental metadata.
File Description
_catalog/​dotnet-go-sdk-symbol-mapping.json Records exclusions for FileAccessProvider, FileAccessProviderOptions, and their members.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@michelle-clayton-work

Copy link
Copy Markdown
Contributor Author

Copilot fix linter errors

@github-actions

This comment has been minimized.

Co-authored-by: michelle-clayton-work <262183035+michelle-clayton-work@users.noreply.github.com>

Copilot AI commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Copilot fix linter errors

Fixed the unchecked-error linter findings and verified with golangci-lint, targeted package tests, and catalog reconciliation. Commit: 6abc2cc.

@github-actions github-actions Bot added area:agent Changes files in the agent area area:provider Changes files in the provider area area:provider/openai Changes files in the provider / openai area area:provider/otel Changes files in the provider / otel area area:workflow Changes files in the workflow area size:large At most 300 changed lines across at most 10 files and removed size:medium At most 100 changed lines across at most 5 files labels Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

API consistency review

Result Scope
out of scope internal-only

No parity review is needed: this PR only adds unchecked-error assertions inside existing test loops (for _, err := range ...) and updates the internal _catalog/dotnet-go-sdk-symbol-mapping.json tracking metadata (marking FileAccessProvider entries as intentional exclusions, no mapping/status changes to reviewed symbols); it contains no exported Go API or user-visible behavior changes.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by Go API Consistency Review Agent for #1296 · copilot · auto · 24.9 AIC · ⌖ 7.82 AIC · ⊞ 13.9K · ◷

@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Oct 16, 2026
@github-actions github-actions Bot added kind:docs Changes documentation or comments kind:tests Changes tests, fixtures, or test infrastructure labels Oct 16, 2026
Merged via the queue into main with commit 8f4fb7f Oct 16, 2026
28 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the dev/mclayton/fileaccess-inventory branch October 16, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:agent Changes files in the agent area area:provider/openai Changes files in the provider / openai area area:provider/otel Changes files in the provider / otel area area:provider Changes files in the provider area area:workflow Changes files in the workflow area kind:docs Changes documentation or comments kind:tests Changes tests, fixtures, or test infrastructure size:large At most 300 changed lines across at most 10 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants