test: add unit tests for skillopt.optimizer.scheduler (edit-budget schedulers)#123
Open
nankingjing wants to merge 1 commit into
Open
test: add unit tests for skillopt.optimizer.scheduler (edit-budget schedulers)#123nankingjing wants to merge 1 commit into
nankingjing wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive unit tests for
skillopt/optimizer/scheduler.py— the edit-budget schedulers that control how many skill edits are allowed per optimisation step (analogous to gradient clipping / learning-rate annealing in neural-network training).This module had zero test coverage despite being a core part of the training loop. It is purely deterministic math with no LLM or network dependencies, making it ideal for precise unit tests.
Coverage
ConstantScheduler— step/state_dict/resume/arbitrary-step behaviourLinearScheduler— decay sequence, monotonicity, bounds, resume consistency, degenerate cases (total_steps=0/1, max_lr==min_lr)CosineScheduler— cosine annealing shape, midpoint exact value, early/late flat regions, monotonicity, boundsAutonomousScheduler— always returns NO_LIMIT, state dict round-tripbuild_scheduler— factory creates correct types, unknown mode raises ValueErrorLRScheduler— abstract base cannot be instantiated directlyStyle
Matches existing test conventions from
tests/test_scoring.pyandtests/test_types.py:from __future__ import annotationspytestwithpytest.raisesfor error pathsVerification
All test expectations are derived from the source formulas by reading — no execution was performed (tests cannot be run in this environment). Every arithmetic assertion has a comment deriving the expected value from the formula in
scheduler.py.Co-Authored-By: Claude noreply@anthropic.com