FEAT: Wire GCG extension protocol implementations#2070
Open
romanlutz wants to merge 7 commits into
Open
Conversation
…ft#1902) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add optional protocol fields on GCGAlgorithmConfig and wire GCGMultiPromptAttack.step to dispatch through protocol objects with default fallbacks that preserve legacy behavior when unset. Also wire suffix initialization through config and add unit coverage for config validation, manager wiring, default parity, and custom dispatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid failing the GCG step when logging tokenized control length for custom candidate-filter outputs that are not directly re-tokenizable by the active tokenizer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…handling - Add tests for __init__ with custom sampling/loss/filter protocols - Add tests for _resolve_* methods returning defaults - Add test for _get_control_length success and error paths - Add test for _resolve_control_init raising ValueError when suffix_init configured but no workers These tests cover previously uncovered lines in gcg_attack.py (lines 151, 163-165) and generator.py (line 463) to meet the 90% diff coverage requirement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align test_get_control_length_success with _get_control_length behavior, which intentionally drops the first token before measuring length. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover GCGMultiPromptAttack constructor wiring via real __init__, exercise gradient-shape mismatch sampling path in step(), and cover _resolve_control_init fallback when suffix_init is not configured. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use verbose=True in the gradient-shape mismatch step test so the prompt iteration yields integer indices (matching attack.step expectations) and avoids tuple indexing errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This continues the GCG protocol refactor by making the extension interfaces the active runtime path while preserving current behavior when callers do not provide custom implementations.
GCGAlgorithmConfig:sampling,loss,candidate_filter, andsuffix_init.GCGMultiPromptAttack.stepto dispatch through protocol objects.StandardGCGSampling,CrossEntropyLoss,LengthPreservingFilter) to preserve legacy behavior.GCGGeneratorsetup/orchestration so:sampling/loss/candidate_filterare bound into the MPA factory.suffix_initresolves the initial control string when provided, otherwisecontrol_initis used.Tests and Documentation
tests/unit/auxiliary_attacks/gcg/test_config.pytests/unit/auxiliary_attacks/gcg/test_generator.pytests/unit/auxiliary_attacks/gcg/test_gcg_core.pyuv run pytest ...): 30 passed, 7 skipped.uv run pre-commit run --files ...).