CmdPal: filter static pages in the background - #50397
CmdPal: filter static pages in the background#50397Michael Jolley (michaeljolley) wants to merge 5 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🧭 PR intakeVisual evidence: Not needed — The changed files do not indicate a visible UI change. No visual evidence is expected. Recommendation
✅ Ready for reviewThis PR passed the automated intake checks and is ready for maintainer review. Automated PR intake; PowerToys maintainers make final decisions. |
Jiří Polášek (jiripolasek)
left a comment
There was a problem hiding this comment.
Let me check this in detail, looks like this is has a lot of protentional make our lives miserable in more than one way.
How is that different than anything I submit in a PR? 😄 |
|
Do we have an actual problem that would require this change? Because when I run tests with 1000s of items, I don't remember the search being an issue. |
Not necessarily. These last 4 PR "ideas" were generated by Astra reviewing the CmdPal codebase and suggesting areas to improve performance. Granted, it was a theoretical vs profiled choice. It is logical that querying thousands of items on the UI thread could be dangerous over time (as the list grows) but at this point, there's no bug report or whatever that precipitated the change. ^ I realize I used words that are larger than this Alabama boy might normally use (precipitated, theoretical, etc.), but I assure you those are my words and not generated by a clanker. 🤖 /signed Michael 😄 |
CmdPal now filters static lists in the background so large lists don't hold up typing. It keeps the same matching and ranking, makes Enter wait for the right selection, and keeps search working when an extension refresh fails.
The new background filtering applies only to static
ListPagepages.DynamicListPage, including CmdPal's main page, still handles its own searches; the shared selection and cancellation changes don't alter dynamic-page filtering or ranking.