Skip to content

CmdPal: filter static pages in the background - #50397

Open
Michael Jolley (michaeljolley) wants to merge 5 commits into
mainfrom
dev/mjolley/cmdpal-background-filtering
Open

CmdPal: filter static pages in the background#50397
Michael Jolley (michaeljolley) wants to merge 5 commits into
mainfrom
dev/mjolley/cmdpal-background-filtering

Conversation

@michaeljolley

@michaeljolley Michael Jolley (michaeljolley) commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

CmdPal now filters static lists in the background so large lists don't hold up typing. It keeps the same matching and ranking, makes Enter wait for the right selection, and keeps search working when an extension refresh fails.

The new background filtering applies only to static ListPage pages. DynamicListPage, including CmdPal's main page, still handles its own searches; the shared selection and cancellation changes don't alter dynamic-page filtering or ranking.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@michaeljolley Michael Jolley (michaeljolley) added the Product-Command Palette Refers to the Command Palette utility label Sep 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@michaeljolley
Michael Jolley (michaeljolley) marked this pull request as ready for review September 7, 2026 21:21
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

🧭 PR intake

Visual evidence: Not needed — The changed files do not indicate a visible UI change. No visual evidence is expected.

Recommendation

Link the issue this PR fixes using a closing keyword such as Closes #123.

✅ Ready for review

This PR passed the automated intake checks and is ready for maintainer review.

Automated PR intake; PowerToys maintainers make final decisions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check this in detail, looks like this is has a lot of protentional make our lives miserable in more than one way.

@michaeljolley

Copy link
Copy Markdown
Contributor Author

Let me check this in detail, looks like this is has a lot of protentional make our lives miserable in more than one way.

How is that different than anything I submit in a PR? 😄

@jiripolasek

Copy link
Copy Markdown
Collaborator

Do we have an actual problem that would require this change? Because when I run tests with 1000s of items, I don't remember the search being an issue.

@michaeljolley

Copy link
Copy Markdown
Contributor Author

Do we have an actual problem that would require this change? Because when I run tests with 1000s of items, I don't remember the search being an issue.

Not necessarily. These last 4 PR "ideas" were generated by Astra reviewing the CmdPal codebase and suggesting areas to improve performance. Granted, it was a theoretical vs profiled choice. It is logical that querying thousands of items on the UI thread could be dangerous over time (as the list grows) but at this point, there's no bug report or whatever that precipitated the change.

^ I realize I used words that are larger than this Alabama boy might normally use (precipitated, theoretical, etc.), but I assure you those are my words and not generated by a clanker. 🤖

/signed Michael 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Command Palette Refers to the Command Palette utility Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants